ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "mame (Yusuke Endoh) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "mame (Yusuke Endoh)" <noreply@ruby-lang.org>
Subject: [ruby-core:117371] [Ruby master Bug#20401] Duplicated when clause warning line number
Date: Fri, 29 Mar 2024 04:43:45 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-107529.20240329044344.10206@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-20401.20240329015510.10206@ruby-lang.org

Issue #20401 has been updated by mame (Yusuke Endoh).


This behavior was discovered and briefly discussed during the previous dev meeting. The actual warning is

```
test.rb:4: warning: duplicated 'when' clause with line 2 is ignored
```

According to @nobu, this reads "The 'when' clause at line 4 duplicates (conflicts) with (a 'when' clause at) line 2. This is ignored."

Anyway I agree that it is too confusing. I think it would be good if they could improve the English.

----------------------------------------
Bug #20401: Duplicated when clause warning line number
https://bugs.ruby-lang.org/issues/20401#change-107529

* Author: kddnewton (Kevin Newton)
* Status: Open
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
When you have a duplicated when clause, you get a warning for it. For example:

```ruby
case foo
when :bar
when :baz
when :bar
end
```

you get `warning: duplicated `when' clause with line 2 is ignored`.

But the when clause that is ignored is the one on line 4, not line 2. It seems like it's warning for the wrong line.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

      parent reply	other threads:[~2024-03-29  4:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29  1:55 [ruby-core:117368] [Ruby master Bug#20401] Duplicated when clause warning line number kddnewton (Kevin Newton) via ruby-core
2024-03-29  1:56 ` [ruby-core:117369] " kddnewton (Kevin Newton) via ruby-core
2024-03-29  4:43 ` mame (Yusuke Endoh) via ruby-core [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-107529.20240329044344.10206@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    --cc=ruby-core@ml.ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).