From: "jeremyevans0 (Jeremy Evans) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "jeremyevans0 (Jeremy Evans)" <noreply@ruby-lang.org>
Subject: [ruby-core:117295] [Ruby master Bug#20388] super + ruby2_keywords isn't working
Date: Fri, 22 Mar 2024 22:31:58 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-107437.20240322223158.73@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-20388.20240322214451.73@ruby-lang.org
Issue #20388 has been updated by jeremyevans0 (Jeremy Evans).
jeremyevans0 (Jeremy Evans) wrote in #note-3:
> jeremyevans0 (Jeremy Evans) wrote in #note-2:
> > tenderlovemaking (Aaron Patterson) wrote in #note-1:
> > > Sorry, I should be more specific. The code sample returns `nil` before 4f77d8d3, and since 4f77d8d3 it will raise an exception (it tries to mutate the `args` array)
> >
> > Thanks for the report. I'll work on fixing this in the compiler.
>
> Actually, compiler is fine, this is due to the anonymous splat optimization. Fix appears simple enough, I'll submit a PR shortly:
PR: https://github.com/ruby/ruby/pull/10338
----------------------------------------
Bug #20388: super + ruby2_keywords isn't working
https://bugs.ruby-lang.org/issues/20388#change-107437
* Author: tenderlovemaking (Aaron Patterson)
* Status: Open
* Assignee: jeremyevans0 (Jeremy Evans)
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
```ruby
class A
def process action, ...
end
end
class B < A
def process method_name, *args
args.freeze
super
end
ruby2_keywords(:process)
end
p B.new.process(:foo, bar: :baz)
```
The above code started breaking at revision 4f77d8d3
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
prev parent reply other threads:[~2024-03-22 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 21:44 [ruby-core:117291] [Ruby master Bug#20388] super + ruby2_keywords isn't working tenderlovemaking (Aaron Patterson) via ruby-core
2024-03-22 21:46 ` [ruby-core:117292] " tenderlovemaking (Aaron Patterson) via ruby-core
2024-03-22 21:52 ` [ruby-core:117293] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-03-22 22:24 ` [ruby-core:117294] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-03-22 22:31 ` jeremyevans0 (Jeremy Evans) via ruby-core [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-107437.20240322223158.73@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=noreply@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).