From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D48051F44D for ; Thu, 14 Mar 2024 15:16:10 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=doDF92rN; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=lzPnsBRr; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 8599F8341E; Thu, 14 Mar 2024 15:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1710429363; bh=IkTaUmCUq7gVID4cfbR+1c6y+1fnYWDPSGMa6oS42as=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=doDF92rNCq0CFLpmojpmf0xEEilYC8OIFk85buWRJBAhRmdfV4olT8+c5xK4Q9GUj 0nDrRi6SbA/TIfAPgyRamtfW3sIaMoFug9anOnQYkjW2Sb2GhxdaWsRq+FTq83AsE0 JCM6a8kVsoW9T5stOo3wims795c3ffR9J2+CEiIg= Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 5BA1283411 for ; Thu, 14 Mar 2024 15:15:52 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=lzPnsBRr; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=jXinO9FuOKPsYi3PPjprZnBFcL0wZDV0JhTg2/Ykizk=; b=lzPnsBRrTOb8qECxnZbfa7kKJjfIGFQ+N5M3tsXVaFC7AJU8smVyYnd+Z2dgHxsvIJGQ EN5R1/aQnQAjQ5gzr9RWSj5LpTpC627N/kwdms6XXjTOuuZAaGE8deuV1D27J+eXdkAn/v pdMOGjCF6n9oMnsRcQtSe6wSH+cRp/UIWnoWgxj31WzaFoc6aog9JckymnHi/joHJUIWlJ uOG/WIgZuYT+CH8YGC1gvpMsJHZxvKdRiQ0mkkyYqxLykfqfjB1QzWTxUVRPDqp/QsNbTQ QPb5shHvIG4mYmkNxvDLIyuQdxkiN378A52LdOJnsCY1vjPL0VPGaeMsj7zCMbMw== Received: by recvd-c464bfb6d-k6n67 with SMTP id recvd-c464bfb6d-k6n67-1-65F314A6-33 2024-03-14 15:15:50.853619296 +0000 UTC m=+1272277.575484040 Received: from herokuapp.com (unknown) by geopod-ismtpd-2 (SG) with ESMTP id aCmeX8n9QPejPufi2e7DsA for ; Thu, 14 Mar 2024 15:15:50.766 +0000 (UTC) Date: Thu, 14 Mar 2024 15:15:50 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20335 X-Redmine-Issue-Author: byroot X-Redmine-Issue-Priority: Normal X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 93748 X-SG-EID: =?us-ascii?Q?u001=2EByjZWvxTCjdoV8K03xEuhE7KqN4thWULFLM7+oH78KY30oYB3qFthsDpL?= =?us-ascii?Q?4w4cbYa3ttBh8bAHPOnE=2FkzPba67JNu7Lnrked2?= =?us-ascii?Q?O7K9VQ=2FJax2LEAZI6ARriJ8EtVzsIscZn8jbbhu?= =?us-ascii?Q?5p5OeqFcaCrGHfzLEGEWij1ImvJgf4As0zHoESb?= =?us-ascii?Q?ES1i6qJ7+pSEeLZ89w1RQl4ALd5e5ejD2r7msFR?= =?us-ascii?Q?WRtmhGxfSvo27XAc5B=2FPsI+n76vtPO+7wpxWK78?= =?us-ascii?Q?NIMpVngXEzzaAFeQXF=2F4a6Tk1w=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: TC5ZZC3ADIBRHSEIAQXM52QTSK5P7YZT X-Message-ID-Hash: TC5ZZC3ADIBRHSEIAQXM52QTSK5P7YZT X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117182] [Ruby master Feature#20335] `Thread.each_caller_location` should accept the same arguments as `caller` and `caller_locations` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Eregon (Benoit Daloze) via ruby-core" Cc: "Eregon (Benoit Daloze)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20335 has been updated by Eregon (Benoit Daloze). Right, Range is problematic, and only Range with positive indices seems an weird restriction so I think better no Range. `Thread.each_caller_location(1, 20)` I think there are basically no use cases for this, so I wouldn't add it to keep things simple. If one wants to e.g. detect the boundary between an app and a gem they should look at locations, not hardcode some frame depth limit. It's kind of the purpose of `Thread.each_caller_location` to be able to dynamically detect the limit, and then an extra Integer limit feels redundant. Could you change your proposal to only add `start = 1`, unless you have/find some good use cases for `Thread.each_caller_location(1, 20)`? ---------------------------------------- Feature #20335: `Thread.each_caller_location` should accept the same arguments as `caller` and `caller_locations` https://bugs.ruby-lang.org/issues/20335#change-107272 * Author: byroot (Jean Boussier) * Status: Open ---------------------------------------- `Thread.each_caller_location` was added to Ruby 3.2 as part of [Feature #16663] and is a very useful API for emitting warnings with a proper source location and similar use cases. However in many of the cases where I used it, or seen it used, it was needed to skip the first, or a couple frames: Examples: Sorbet: https://github.com/Shopify/sorbet/blob/b27a14c247ace7cabdf0f348bfb11fdf0b7e9ab4/gems/sorbet-runtime/lib/types/private/caller_utils.rb#L6-L18 ```ruby def self.find_caller skiped_first = false Thread.each_caller_location do |loc| unless skiped_first skiped_first = true next end next if loc.path&.start_with?("= 1 frames_to_skip -= 1 next end # snipp... ``` ### Proposal I think it would be very useful if `Thread.each_caller_location` accepted the same arguments as `caller` and `caller_locations`: ```ruby #each_caller_location(start = 1, length = nil) #each_caller_location(range) ``` @jeremyevans0 what do you think? -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/