From: "mame (Yusuke Endoh) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "mame (Yusuke Endoh)" <noreply@ruby-lang.org>
Subject: [ruby-core:117155] [Ruby master Feature#4247] New features for Array#sample, Array#choice
Date: Thu, 14 Mar 2024 10:08:10 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-107242.20240314100810.2342@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-4247.20110107192051.2342@ruby-lang.org
Issue #4247 has been updated by mame (Yusuke Endoh).
Status changed from Assigned to Rejected
Assignee deleted (mame (Yusuke Endoh))
We discussed this at the dev meeting. No one remembered the discussion from over 10 years ago, so we discussed it anew and concluded that this was a no-go.
A naive API design could be `ary.sample(k, weights: [Float])`, but this would be an O(ary.size * k) time-consuming algorithm.
There are many more efficient algorithms for weighted sampling. (We read Julia's [StatsBase.jl](https://juliastats.org/StatsBase.jl/stable/sampling/) and Python's [random](https://docs.python.org/3.13/library/random.html).) However, these require additional information, such as the sum of the weights, cumulative weight table, the need to build the table in advance, etc.
We want to avoid an API design that only allows slow algorithm, but it seems overkill to introduce an API that allows advanced algorithms as a built-in feature. We concluded that it would be better to make a gem, instead of a built-in feature, for such things.
----------------------------------------
Feature #4247: New features for Array#sample, Array#choice
https://bugs.ruby-lang.org/issues/4247#change-107242
* Author: oj (Yoji Ojima)
* Status: Rejected
----------------------------------------
=begin
We are planning to add the following features of the random sampling to Array.
1. Weighted random sampling.
2. Sampling with replacement.
3. Iteration.
It is discussed in ruby-dev (Feature #3647 and #4147).
API will be:
Array#sample([size, [opt]])
- Random selection without replacement.
- Returns a new array when size is specified.
- opt:
weight: proc or array
random: Random instance
Array#choice([size, [opt]])
- Random selection with replacement.
- Returns a new array when size is specified.
- opt: same as above.
Array#each_sample([opt])
- Random selection iterator without replacement.
- Choose a random element and yield it.
- Returns an Enumerator if a block is not given.
- opt: same as above.
Array#each_choice([opt])
- Random selection iterator with replacement.
- Choose a random element and yield it.
- Returns an Enumerator if a block is not given.
- opt: same as above.
Comments?
=end
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
parent reply other threads:[~2024-03-14 10:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <redmine.issue-4247.20110107192051.2342@ruby-lang.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-107242.20240314100810.2342@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=noreply@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).