ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "Eregon (Benoit Daloze) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "Eregon (Benoit Daloze)" <noreply@ruby-lang.org>
Subject: [ruby-core:117099] [Ruby master Bug#20319] Singleton class is being frozen lazily in some cases
Date: Mon, 11 Mar 2024 13:35:10 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-107172.20240311133509.13553@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-20319.20240301115212.13553@ruby-lang.org

Issue #20319 has been updated by Eregon (Benoit Daloze).


jeremyevans0 (Jeremy Evans) wrote in #note-4:
> I disagree.  If you do not freeze the object's singleton class, then you can define or undefine any method in the singleton class, which is almost the same as being able to modify the object (from a Ruby perspective, not a C perspective).

One can still define or undefine any method in one of the ancestors (except the singleton class), or use `prepend`/`include` on any of these or even `refine` to change the behavior of that object.
Freezing the singleton class achieves very little IMO and is inconsistent with `Kernel#freeze` being a shallow freeze (that is, only freeze the immediate object, not other objects, which AFAIK holds for all other cases).

----------------------------------------
Bug #20319: Singleton class is being frozen lazily in some cases
https://bugs.ruby-lang.org/issues/20319#change-107172

* Author: andrykonchin (Andrew Konchin)
* Status: Open
* ruby -v: 3.2.2
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I've noticed suspicious behaviour (it doesn't affect anything in practice for me though) when an object becomes frozen only its own singleton class becomes frozen immediately.

A singleton class of the object immediate singleton class becomes frozen lazily after `#singleton_class` method call:

```ruby
o = Object.new
klass = o.singleton_class.singleton_class

o.freeze

puts klass.frozen?                              # false <== here we expect true
puts o.singleton_class.singleton_class.frozen?  # true
puts klass.frozen?                              # true
```

I would expect all created (and visible to user) singleton classes in an object singleton classes chain to become frozen immediately when the object gets frozen.




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2024-03-11 13:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 11:52 [ruby-core:117027] [Ruby master Bug#20319] Singleton class is being frozen lazily in some cases andrykonchin (Andrew Konchin) via ruby-core
2024-03-01 12:04 ` [ruby-core:117028] " Eregon (Benoit Daloze) via ruby-core
2024-03-04 17:46 ` [ruby-core:117054] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-03-11 13:35 ` Eregon (Benoit Daloze) via ruby-core [this message]
2024-03-11 13:37 ` [ruby-core:117100] " Eregon (Benoit Daloze) via ruby-core
2024-03-14  1:37 ` [ruby-core:117134] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-04-18 11:44 ` [ruby-core:117597] " Eregon (Benoit Daloze) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-107172.20240311133509.13553@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    --cc=ruby-core@ml.ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).