From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BDDB91F44D for ; Sun, 25 Feb 2024 09:29:48 +0000 (UTC) Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 5053E82AD8; Sun, 25 Feb 2024 09:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1708853378; bh=eR++XWaItKSCDwAj4zWv4QK/rQXM6RcYPAB/l6wYKRc=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=MAtYyMC3jPaQTKXyoTZRFlRpHaeefIwOJQyeBym8INAZgR/3OnDYyLF3jOMndc6t9 N6mKEDjFNOejj5wHuqlplAfVDuMCp1LTMdrgijjUjjaybkKnB+LzyCTsIsGIwCBq2q 9s+lbA31NBDJUNrgA5CUYYqLXF37p18PErEa5oZQ= Received: from s.wfbtzhsv.outbound-mail.sendgrid.net (s.wfbtzhsv.outbound-mail.sendgrid.net [159.183.224.104]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 8BDE18291B for ; Sun, 25 Feb 2024 09:29:34 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=NwFn2UhQ; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=6tTN8QbI0uPLOUD4lYLYTMyVM6YIvLxQgoUHmQf4RRk=; b=NwFn2UhQ8X08KQO7e00FvV6R8T8knYfG1qL1O5wUK0IinsXsfWfBS99eRDCDRrPlsUKT U6gTZwuPb4FIY8Dk2+g9gRcLMYurNkFdLl5qgMAdHFrfT5KYC32kNLkq9RA6AX+0JSvI2U Hie7IH3/jkihvtfwsnB3xxPKwrxHtW+wffGlqWlYZFRKIJun/LFlAhWnn/ReV/EUoUngzf LE5dC7T27cvlqm3NPJI0Razt7oUMrpzJAjDF7/6sr5x83sPllEvElx/LwUH6Pd795uKzMZ FrPQH3tVLg/rmfPCb4/SeEoIzyFNNO9Xe7y8AlXr+Rn0BtBRCPWUsxV1Bb8X4uBg== Received: by recvd-8f9f6ff74-94jjk with SMTP id recvd-8f9f6ff74-94jjk-1-65DB087D-4 2024-02-25 09:29:33.558928321 +0000 UTC m=+220388.273205776 Received: from herokuapp.com (unknown) by geopod-ismtpd-10 (SG) with ESMTP id jkRishePTGuj87RNUtJewA for ; Sun, 25 Feb 2024 09:29:33.534 +0000 (UTC) Date: Sun, 25 Feb 2024 09:29:33 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 18743 X-Redmine-Issue-Author: sos4nt X-Redmine-Issue-Assignee: ko1 X-Redmine-Issue-Priority: Normal X-Redmine-Sender: nagachika X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 93491 X-SG-EID: =?us-ascii?Q?5tswmMdpuZtWC+SIdASU151b2aqPGWt2MCGiK8FM5waeDDbfOiDH=2FZvzDCybLH?= =?us-ascii?Q?ac5aUpPkJl2qsSCwuuhJa5kBFsc=2FNuo8RbFzwG3?= =?us-ascii?Q?LHWVN+gjm7ni=2FkyFWIFnV+qU4RSpeo94pvkGAmO?= =?us-ascii?Q?=2FuKXrVFMimqcuK3KXtqGBlJPMeqWKhECH1aaeD+?= =?us-ascii?Q?P22r85jJpKOi=2FMulnAQry5nf+VFN0xhOrqsqOcZ?= =?us-ascii?Q?5KbtOrdXdvNK50jGm5HDNkMUqRdo54BWWjUoEHj?= =?us-ascii?Q?d9xHrCI3Bij3DL5y3FxtA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: J6SEAHRUVNZL2QKQVMAL5OSKEYHRDUKX X-Message-ID-Hash: J6SEAHRUVNZL2QKQVMAL5OSKEYHRDUKX X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:116935] [Ruby master Bug#18743] Enumerator#next / peek re-use each others stacktraces List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nagachika (Tomoyuki Chikanaga) via ruby-core" Cc: "nagachika (Tomoyuki Chikanaga)" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Issue #18743 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 3.0: REQUIRED, 3.1: REQUIRED, 3.2: REQUIRED to 3.0: R= EQUIRED, 3.1: REQUIRED, 3.2: DONE ruby_3_2 5e4606423da96c2e26b00981c22bddfce0d970bf merged revision(s) f15123= c34ce80f3928612befe2a9aaf4c9d27fda. ---------------------------------------- Bug #18743: Enumerator#next / peek re-use each others stacktraces https://bugs.ruby-lang.org/issues/18743#change-106970 * Author: sos4nt (Stefan Sch=FC=DFler) * Status: Closed * Assignee: ko1 (Koichi Sasada) * Backport: 3.0: REQUIRED, 3.1: REQUIRED, 3.2: DONE ---------------------------------------- I encountered an odd behavior. If I rescue the `StopIteration` exception from `peek` and call `next` after= wards: (or vice-versa) ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next # 5 ``` it will show the stacktrace from the rescued `peek` call: ``` $ ruby enum.rb enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` Whereas the error should refer to `next` on line number 5. The same happens when calling `peek` after `next` or when having muliple `p= eek` / `next` calls: ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next rescue nil # 5 enum.peek rescue nil # 6 puts "line #{__LINE__}" # 7 enum.next # 8 ``` The stacktrace from the first (rescued) `peek` or `next` call will be shown= which doesn't reflect the actual error location: ``` $ ruby enum.rb line 7 enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` This is very confusing when debugging code. ---Files-------------------------------- 01-Recreate-stacktrace-enumerator.patch (1.29 KB) --=20 https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-c= ore.ml.ruby-lang.org/