From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 256961F44D for ; Wed, 14 Feb 2024 05:10:38 +0000 (UTC) Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 300328291B; Wed, 14 Feb 2024 05:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1707887431; bh=Td1Yy2rLPSl5kJvt2I+SZhBuyITZ9dWWy22Lp52wp5Y=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=IuB7tW/VUao5OUEd7Jc5IHRcrM1cD6lF4bnwqmPHW2oVbYcK2mr0Dm+HT+x7PuvM8 E/xW4WrhCBdFSwEBKGjyxp3aSZqIe18mVHZAjPkZRxmkiPyfYMteQuk5LT8HVtu28M GhGPcrNeVy3qikHvt7T7FwHMQ7HZK/A0XCXFwXcM= Received: from wrqvtvtt.outbound-mail.sendgrid.net (wrqvtvtt.outbound-mail.sendgrid.net [149.72.120.119]) by nue.mailmanlists.eu (Postfix) with ESMTPS id B93947F57F for ; Wed, 14 Feb 2024 05:10:27 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=lHBgKDKX; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=kJVBNcglC1jFzd9CaSyZsBHz+sVBgwQIgfh0cYl4UQ4=; b=lHBgKDKXgZXy+V9gYmK9mSZZTvE2wgJIlZPTfs8AmnPGBZO3DL9uMkqNE+sREuJbbfUE uj4BX4SDGvOy6GeFy+XhqOUhMYGgnxYIV2YoPYrVMLAOV9YrCSZTkHZjUOutvb6eY09oGq yrVR/6p1VSkZWbWoFSZjG9F5xFEeMcl14k57WDKAH1WAzbr9Qe05jwmEGrG7Cmz24uEhFn 0B1PPhvgw1dzJ2RX3HkpA3xNycRDffTXazu/Y9GapyF3XbKw5snKupXBaR4hUMMZwc2OxS OzlPKaTO2JT8eKiEx4yhxZLu3OlKdyG3OrPqgYLP9OWXzwD6MuQ/bEaahh8j0SGQ== Received: by recvd-8556d987bf-rpzkr with SMTP id recvd-8556d987bf-rpzkr-1-65CC4B42-6 2024-02-14 05:10:26.429473748 +0000 UTC m=+20121.542687716 Received: from herokuapp.com (unknown) by geopod-ismtpd-13 (SG) with ESMTP id e2BpgDuUQpGwZbgWBzuCeQ for ; Wed, 14 Feb 2024 05:10:26.387 +0000 (UTC) Date: Wed, 14 Feb 2024 05:10:26 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 19117 X-Redmine-Issue-Author: byroot X-Redmine-Sender: matz X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 93285 X-SG-EID: =?us-ascii?Q?SqOeWfVKFgkgw8cVgc6MYslIG5ZBbSbWU3opJ5u4yBsU3yWoizgPd1Pss4ZMTd?= =?us-ascii?Q?OLBRodnvQO26=2FFyqng1x72rdTkbmTHg5l1+yKA9?= =?us-ascii?Q?AQWjb7sDHuGnIgUcxj7RJXtbA4O7jS60ZaoY+eQ?= =?us-ascii?Q?b1DsO7Lk3GHFy9DKUMsfIk1xhc3zCCi7tt3V7rt?= =?us-ascii?Q?8pVY0sp4etYQ+IBWQO8vSua21mBf9ihnBOWAuJc?= =?us-ascii?Q?tC7bMznlaoMHrm+5l3Bl5pxsoaGz2UP=2FFAbN1zu?= =?us-ascii?Q?7s0Oqb1zg=2FkOzHtxAduwg=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: 3CICJTVKI67IWCPQA62BPBAM4LEUT7FK X-Message-ID-Hash: 3CICJTVKI67IWCPQA62BPBAM4LEUT7FK X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:116729] [Ruby master Feature#19117] Include the method owner in backtraces, not just the method name List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "matz (Yukihiro Matsumoto) via ruby-core" Cc: "matz (Yukihiro Matsumoto)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #19117 has been updated by matz (Yukihiro Matsumoto). I am OK with adding method owner. I am against removing quote signs. Matz. ---------------------------------------- Feature #19117: Include the method owner in backtraces, not just the method name https://bugs.ruby-lang.org/issues/19117#change-106748 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal * Target version: 3.4 ---------------------------------------- ``` module Foo class Bar def inspect 1 + '1' end end end p Foo::Bar.new ``` This code produce the following backtrace: ``` /tmp/foo.rb:4:in `+': String can't be coerced into Integer (TypeError) from /tmp/foo.rb:4:in `inspect' from /tmp/foo.rb:9:in `p' from /tmp/foo.rb:9:in `
' ``` This works, but on large codebases and large backtraces the method name isn't always all that revealing, most of the time you need to open many of the locations listed in the backtrace to really understand what is going on. I propose that we also include the owner name: ``` /tmp/foo.rb:4:in `Integer#+': String can't be coerced into Integer (TypeError) from /tmp/foo.rb:4:in `Foo::Bar#inspect' from /tmp/foo.rb:9:in `Kernel#p' from /tmp/foo.rb:9:in `
' ``` I believe that in many case it would allow to much better understand the backtrace without having to jump back and forth between it and the source code. This is inspired by @ivoanjo 's `backtracie` gem: https://github.com/ivoanjo/backtracie -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/