From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1D8AB1F405 for ; Sat, 3 Feb 2024 19:53:13 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=rFxCKIsC; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Lu5zRjbK; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 70E818268A; Sat, 3 Feb 2024 19:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1706989985; bh=cdAhuQkU/QVr1LTElGUdiH4uwkmyxKmC7xv46njUiZw=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=rFxCKIsC5JnWzVYcJwsNvM7r4frztV4i00kOkjuMpWUE7w794yHs1C+clo/LGRjSw 5EGzuILyzglY8a3cKp4BXU+p95MMi38fer1sVrGaYfp5w1oEPtw0GtctPFLEQ7GPj4 vHWdTSDEczJlaO/vrKe2fw3r0zEItyJg2b7qkbws= Received: from wrqvtvtt.outbound-mail.sendgrid.net (wrqvtvtt.outbound-mail.sendgrid.net [149.72.120.119]) by nue.mailmanlists.eu (Postfix) with ESMTPS id CA5BF81A87 for ; Sat, 3 Feb 2024 19:53:01 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Lu5zRjbK; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=aYoy9VAEeAqO9biEL3v6TJmJHSYvEDXEeBkI5hoL2Ck=; b=Lu5zRjbKCvBng+Gr9Jkj9k0p+IcfZiHlilB8k1/cSc1PCRr+jPIl4ofxbPbdl57s8oNa vQNSIBKk0DESb0CqeY6VvT4Ex+Art24hbgZEGOW4yF8rDKVz+QR6jemLaCSttZ/gd8aA97 W5fGkG7TK+rcAsyi0xEW37QPM0irig9swOX/Yyd2dEE4NQxdcRkPD/iy0MpFsRgKozk0KN 9A1vd0fT1tIiexIO0nnR7UDZjV0guDKVWqr3pSWlpj12Rz7y9j+UjkuvecD+Siv4utyZKc 7sFFsrpzRqqPTeE++Rt14s5zuleNhJAmP0aX9efQXFHtSBlD6nfJykEvzvrjPJJA== Received: by filterdrecv-5bbdbb56cd-h9hcp with SMTP id filterdrecv-5bbdbb56cd-h9hcp-1-65BE999C-1 2024-02-03 19:53:00.142751211 +0000 UTC m=+2010965.634426890 Received: from herokuapp.com (unknown) by geopod-ismtpd-20 (SG) with ESMTP id -SPgRSQiSlKDmE0EkT4jhQ for ; Sat, 03 Feb 2024 19:53:00.075 +0000 (UTC) Date: Sat, 03 Feb 2024 19:53:00 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20215 X-Redmine-Issue-Author: ioquatix X-Redmine-Sender: Dan0042 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 93124 X-SG-EID: =?us-ascii?Q?9vnO9kNFlf1pwhty1clU3mt9eNWYniufdXqocdsQQtaDTWZk4+b5g5js0Akvaj?= =?us-ascii?Q?32LW=2F+fGSAom3tt8Jo+=2FGW3uDD0ktbmu7qAbln0?= =?us-ascii?Q?uJrjICIfyYFrVwrf7pE83dvG9oa90Ppc5=2F42rd5?= =?us-ascii?Q?2y=2FGxLo9ELkbOgjTvVx9LadLp4BHkLoThJ53uZh?= =?us-ascii?Q?gAyohuZ83UV1q2OwqWTQfBCTlHpfmNWv1jmFuPW?= =?us-ascii?Q?eCzRA8Jfg7Ldei2sIV7kgImI6ZJqB0FeNMgh5kN?= =?us-ascii?Q?Q4w0ABzSnyyp7OrqXFBhw=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: N27XJCJZRWUMMNFMLVUKOV4CNE42EPR4 X-Message-ID-Hash: N27XJCJZRWUMMNFMLVUKOV4CNE42EPR4 X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:116567] [Ruby master Feature#20215] Introduce `IO#readable?` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Dan0042 (Daniel DeLorme) via ruby-core" Cc: "Dan0042 (Daniel DeLorme)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20215 has been updated by Dan0042 (Daniel DeLorme). Actually if I think about it a little, I can work around that like this: ```ruby loop do if $stdin.wait_readable(0) str = $stdin.gets or abort("") p str else puts "no input, let's wait a bit..." sleep 1 end end ``` And I now realize this is the same as `IO.select`; not sure why I didn't think of using that before. Which brings me to understand what @ioquatix has in mind is a bit different from what I thought. It looks like it can be implemented like this? ```ruby class IO def readable? if IO.select([self],[],[],0).nil? true #no data available but not eof else !eof? #will not hang due to check above end end #or, what about adding an argument to eof? def eof?(non_blocking=false) if non_blocking return nil if IO.select([self],[],[],0).nil? end super end end ``` ---------------------------------------- Feature #20215: Introduce `IO#readable?` https://bugs.ruby-lang.org/issues/20215#change-106583 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal ---------------------------------------- There are some cases where, as an optimisation, it's useful to know whether more data is potentially available. We already have `IO#eof?` but the problem with using `IO#eof?` is that it can block indefinitely for sockets. Therefore, code which uses `IO#eof?` to determine if there is potentially more data, may hang. ```ruby def make_request(path = "/") client = connect_remote_host # HTTP/1.0 request: client.write("GET #{path} HTTP/1.0\r\n\r\n") # Read response client.gets("\r\n") # => "HTTP/1.0 200 OK\r\n" # Assuming connection close, there are two things the server can do: # 1. peer.close # 2. peer.write(...); peer.close if client.eof? # <--- Can hang here! puts "Connection closed" # Avoid yielding as we know there definitely won't be any data. else puts "Connection open, data may be available..." # There might be data available, so yield. yield(client) end ensure client&.close end make_request do |client| puts client.read # <--- Prefer to wait here. end ``` The proposed `IO#readable?` is similar to `IO#eof?` but rather than blocking, would simply return false. The expectation is the user will subsequently call `read` which may then wait. The proposed implementation would look something like this: ```ruby class IO def readable? !self.closed? end end class BasicSocket # Is it likely that the socket is still connected? # May return false positive, but won't return false negative. def readable? return false unless super # If we can wait for the socket to become readable, we know that the socket may still be open. result = self.recv_nonblock(1, MSG_PEEK, exception: false) # No data was available - newer Ruby can return nil instead of empty string: return false if result.nil? # Either there was some data available, or we can wait to see if there is data avaialble. return !result.empty? || result == :wait_readable rescue Errno::ECONNRESET # This might be thrown by recv_nonblock. return false end end ``` For `IO` itself, when there is buffered data, `readable?` would also return true immediately, similar to `eof?`. This is not shown in the above implementation as I'm not sure if there is any Ruby method which exposes "there is buffered data". -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/