From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1D3451F405 for ; Sat, 3 Feb 2024 17:13:44 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=L1bFLgPi; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=aMjDOx3T; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 7FF148276D; Sat, 3 Feb 2024 17:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1706980416; bh=RysCiF26+SDUZyCbx54APicTGQf3csRX5JIM94MO364=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=L1bFLgPibjj4LDO6DD5Ao9MV1/8po9eSUzac5nJxvS6V0x8Wo03PIT2QByjvyUs99 rqKBrdhsaV0fKQknXV7djl5N/Wp6L/88nStZBgIjXZOJsmmTx2feX6blcE+psP7mht jYiEHDr7+yrOgsY/VsmO7TxWwzogt0odo+wS5N44= Received: from s.csnrwnwx.outbound-mail.sendgrid.net (s.csnrwnwx.outbound-mail.sendgrid.net [198.37.146.154]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 0750A82749 for ; Sat, 3 Feb 2024 17:13:32 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=aMjDOx3T; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=c2R8YJdlr5egasZzLS+XiAw75HdWbvgidaaQtPbTFm8=; b=aMjDOx3TOuAhWWvmV/J7byZIU1D91gRgc+DEZZ6ndBXNyDdwJB71PKhbiydYKY7W51LY CpnoFSYKZPduM+MOhvY6LiuDkR3Ol5QXu8Nm1I8NDNufqxud2hUbARiTHu9vTfLSuycOa0 r2XHEExdjIZSjQv03tH3lVEijiDuWmPKvsiG4Jb1zBNd35cOBgz14T69UtnVAzbCeUmtWd 7U+ev7c+ly41lXY1GZHHkjNoWUZt201GTlN0rOTe+FxmuBkv1xsID/J4fH3sjB9E6VxYez H6hJ8/8Jrd4hgQWcBL7dKSeD+7nc/1bY/yX8uQE3UYXwgZ0O2jmc+hXKIcoLTGog== Received: by filterdrecv-5bbdbb56cd-52lf9 with SMTP id filterdrecv-5bbdbb56cd-52lf9-1-65BE743A-18 2024-02-03 17:13:30.922035151 +0000 UTC m=+2001364.046700156 Received: from herokuapp.com (unknown) by geopod-ismtpd-canary-0 (SG) with ESMTP id or-MjH4xRzqI_6uhDzq87A for ; Sat, 03 Feb 2024 17:13:30.852 +0000 (UTC) Date: Sat, 03 Feb 2024 17:13:30 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20215 X-Redmine-Issue-Author: ioquatix X-Redmine-Sender: Dan0042 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 93123 X-SG-EID: =?us-ascii?Q?9vnO9kNFlf1pwhty1clU3mt9eNWYniufdXqocdsQQtaDTWZk4+b5g5js0Akvaj?= =?us-ascii?Q?32LW=2F+fGSAom3tt8Jo+=2FGW3uDD0ktbmu7qAbln0?= =?us-ascii?Q?uJrjIDqgnDDyNjdrS=2FqyN83cZ2d5rj1ED2ZuYC9?= =?us-ascii?Q?cAXODhixXpdow+nHorKjwWdp79cpkqenYZmaLvW?= =?us-ascii?Q?qg5MwgS2a+9sWqAufo=2F8YXY+VDjNezFfWuMAIsp?= =?us-ascii?Q?LYcB1KpQ09PsIDQzV2926DnMChaAEXmmwQ57Xf+?= =?us-ascii?Q?37NYO5IwCpDOaQ4ENnCkw=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: EJ6WLGKBGUOI3JRYKA2ZHCFT2HPBXT5K X-Message-ID-Hash: EJ6WLGKBGUOI3JRYKA2ZHCFT2HPBXT5K X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:116566] [Ruby master Feature#20215] Introduce `IO#readable?` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Dan0042 (Daniel DeLorme) via ruby-core" Cc: "Dan0042 (Daniel DeLorme)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20215 has been updated by Dan0042 (Daniel DeLorme). Interesting, I didn't know about #wait_readable. Looks like previously it needed `require "io/wait"` but it was integrated in Ruby 3.2 core. Unfortunately it doesn't work for my use case: ``` (echo 1;sleep 1;echo 2)|3.2 ruby -e '8.times{p(gets:$stdin.gets, closed:$stdin.closed?) if p $stdin.wait_readable(0); sleep 0.2}' #> {:gets=>"1\n", :closed=>false} nil nil nil nil #> {:gets=>"2\n", :closed=>false} #> {:gets=>nil, :closed=>false} #> {:gets=>nil, :closed=>false} ``` If #wait_readable returns `#>`, the subsequent #gets should never return nil. ---------------------------------------- Feature #20215: Introduce `IO#readable?` https://bugs.ruby-lang.org/issues/20215#change-106582 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal ---------------------------------------- There are some cases where, as an optimisation, it's useful to know whether more data is potentially available. We already have `IO#eof?` but the problem with using `IO#eof?` is that it can block indefinitely for sockets. Therefore, code which uses `IO#eof?` to determine if there is potentially more data, may hang. ```ruby def make_request(path = "/") client = connect_remote_host # HTTP/1.0 request: client.write("GET #{path} HTTP/1.0\r\n\r\n") # Read response client.gets("\r\n") # => "HTTP/1.0 200 OK\r\n" # Assuming connection close, there are two things the server can do: # 1. peer.close # 2. peer.write(...); peer.close if client.eof? # <--- Can hang here! puts "Connection closed" # Avoid yielding as we know there definitely won't be any data. else puts "Connection open, data may be available..." # There might be data available, so yield. yield(client) end ensure client&.close end make_request do |client| puts client.read # <--- Prefer to wait here. end ``` The proposed `IO#readable?` is similar to `IO#eof?` but rather than blocking, would simply return false. The expectation is the user will subsequently call `read` which may then wait. The proposed implementation would look something like this: ```ruby class IO def readable? !self.closed? end end class BasicSocket # Is it likely that the socket is still connected? # May return false positive, but won't return false negative. def readable? return false unless super # If we can wait for the socket to become readable, we know that the socket may still be open. result = self.recv_nonblock(1, MSG_PEEK, exception: false) # No data was available - newer Ruby can return nil instead of empty string: return false if result.nil? # Either there was some data available, or we can wait to see if there is data avaialble. return !result.empty? || result == :wait_readable rescue Errno::ECONNRESET # This might be thrown by recv_nonblock. return false end end ``` For `IO` itself, when there is buffered data, `readable?` would also return true immediately, similar to `eof?`. This is not shown in the above implementation as I'm not sure if there is any Ruby method which exposes "there is buffered data". -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/