ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "joshuap (Josh Wood) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "joshuap (Josh Wood)" <noreply@ruby-lang.org>
Subject: [ruby-core:116002] [Ruby master Feature#16495] Inconsistent quotes in error messages
Date: Thu, 04 Jan 2024 00:31:22 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-105997.20240104003122.32676@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16495.20200109215418.32676@ruby-lang.org

Issue #16495 has been updated by joshuap (Josh Wood).


ivoanjo (Ivo Anjo) wrote in #note-25:
> matz (Yukihiro Matsumoto) wrote in #note-7:
> > It was something cultural. I admit nowadays very few people use backquote as a left-hand quote, but it used to be. I also admit consistent quotes are easier for our eyes when using recent major fonts. But changing those quotes may affect existing log parsers. We have to estimate how big is the influence of the changes.
> > 
> > Matz.
> 
> On the topic of impacting the ecosystem, there have been quite a few changes to how exceptions have been displayed recently:
> 
> * https://bugs.ruby-lang.org/issues/17930
> * https://bugs.ruby-lang.org/issues/18564
> 
> and even more being discussed https://bugs.ruby-lang.org/issues/19117 .
> 
> Overall the impact on the ecosystem seemed quite small, and the gain in usability was nice. So changing the `` ` `` to a `'` doesn't seem like it would be worse than any of those changes.

To chime in here, at Honeybadger we use this regular expression to parse the Ruby backtrace: https://github.com/honeybadger-io/honeybadger-ruby/blob/edc815c136c5d61fb4e8363b2ffafedef246e4fc/lib/honeybadger/backtrace.rb#L10

I don't think it should be too difficult for us to support both the old and new quote formats. As a Ruby user myself, I always found the backtick to be odd, and wasn't aware of the history, which is fascinating.

----------------------------------------
Feature #16495: Inconsistent quotes in error messages
https://bugs.ruby-lang.org/issues/16495#change-105997

* Author: Kolano (Kenneth Kolano)
* Status: Open
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
----------------------------------------
Error messages use inconsistent pairs of quotes, for instance:

```
-e:1:in `<main>': undefined local variable or method `foo' for main:Object (NameError)
```

where a back tick is used on the left-hand side, and a single quote is used on the right.

The same quotes should be used on either side of the elements being quoted.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2024-01-04  0:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16495.20200109215418.32676@ruby-lang.org>
2020-08-07  0:27 ` [ruby-core:99506] [Ruby master Feature#16495] Inconsistent quotes in error messages naumovvladislav
2022-06-10  2:24 ` [ruby-core:108840] " ioquatix (Samuel Williams)
2022-06-15  3:23 ` [ruby-core:108923] " nobu (Nobuyoshi Nakada)
2022-06-15 10:03 ` [ruby-core:108926] " ioquatix (Samuel Williams)
2022-06-15 11:28 ` [ruby-core:108927] " nobu (Nobuyoshi Nakada)
2022-06-15 12:09 ` [ruby-core:108929] " ioquatix (Samuel Williams)
2022-06-15 12:49 ` [ruby-core:108930] " nobu (Nobuyoshi Nakada)
2022-06-15 13:02 ` [ruby-core:108932] " zverok (Victor Shepelev)
2022-06-15 14:20 ` [ruby-core:108933] " sawa (Tsuyoshi Sawada)
2022-06-15 15:43 ` [ruby-core:108934] " austin (Austin Ziegler)
2022-06-15 16:21 ` [ruby-core:108935] " zverok (Victor Shepelev)
2024-01-03 13:28 ` [ruby-core:115993] " ivoanjo (Ivo Anjo) via ruby-core
2024-01-03 13:33 ` [ruby-core:115994] " mdalessio (Mike Dalessio) via ruby-core
2024-01-04  0:31 ` joshuap (Josh Wood) via ruby-core [this message]
2024-01-18  7:54 ` [ruby-core:116295] " matz (Yukihiro Matsumoto) via ruby-core
2024-01-18 13:43 ` [ruby-core:116296] " Dan0042 (Daniel DeLorme) via ruby-core
2024-01-18 15:24 ` [ruby-core:116299] " Eregon (Benoit Daloze) via ruby-core
2024-01-18 20:28 ` [ruby-core:116310] " mame (Yusuke Endoh) via ruby-core
2024-01-19  7:45 ` [ruby-core:116313] " mame (Yusuke Endoh) via ruby-core
2024-02-14  5:05 ` [ruby-core:116728] " matz (Yukihiro Matsumoto) via ruby-core
2024-02-17 22:22 ` [ruby-core:116828] " ioquatix (Samuel Williams) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-105997.20240104003122.32676@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    --cc=ruby-core@ml.ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).