From: "kjtsanaktsidis (KJ Tsanaktsidis) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "kjtsanaktsidis (KJ Tsanaktsidis)" <noreply@ruby-lang.org>
Subject: [ruby-core:115173] [Ruby master Bug#18991] False LocalJumpError when branch coverage is enabled
Date: Thu, 26 Oct 2023 00:22:09 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-105084.20231026002208.31364@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-18991.20220902032206.31364@ruby-lang.org
Issue #18991 has been updated by kjtsanaktsidis (KJ Tsanaktsidis).
Thank you for the fix mame! Would it be possible for this to be backported to the 3.1 branch? The fix seems to apply cleanly and resolves our issue.
I opened a backport PR here: https://github.com/ruby/ruby/pull/8768.
----------------------------------------
Bug #18991: False LocalJumpError when branch coverage is enabled
https://bugs.ruby-lang.org/issues/18991#change-105084
* Author: qnighy (Masaki Hara)
* Status: Closed
* Priority: Normal
* Assignee: mame (Yusuke Endoh)
* ruby -v: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin21]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
Enabling branch coverage leads to a false LocalJumpError where it should not be raised.
```ruby
# test.rb
require "coverage"
Coverage.start(branches: true)
# Coverage.start(lines: true)
load "./test2.rb"
```
```ruby
# test2.rb
1&.tap do break end
```
Output:
```
$ ruby test.rb
/Users/qnighy/workdir/branch-coverage-bug/test2.rb:1:in `block in <top (required)>': break from proc-closure (LocalJumpError)
from <internal:kernel>:90:in `tap'
from /Users/qnighy/workdir/branch-coverage-bug/test2.rb:1:in `<top (required)>'
from test.rb:5:in `load'
from test.rb:5:in `<main>'
```
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
next prev parent reply other threads:[~2023-10-26 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 3:22 [ruby-core:109822] [Ruby master Bug#18991] False LocalJumpError when branch coverage is enabled qnighy (Masaki Hara)
2022-09-02 10:19 ` [ruby-core:109824] " mame (Yusuke Endoh)
2022-11-08 2:59 ` [ruby-core:110649] " mame (Yusuke Endoh)
2023-10-26 0:22 ` kjtsanaktsidis (KJ Tsanaktsidis) via ruby-core [this message]
2023-11-06 11:14 ` [ruby-core:115262] " usa (Usaku NAKAMURA) via ruby-core
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-105084.20231026002208.31364@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=noreply@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).