ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:114847] [Ruby master Bug#19896] Ruby method refinement memory leak
@ 2023-09-20 18:05 HParker (Adam Hess) via ruby-core
  2023-09-30  7:07 ` [ruby-core:114929] " nagachika (Tomoyuki Chikanaga) via ruby-core
  0 siblings, 1 reply; 2+ messages in thread
From: HParker (Adam Hess) via ruby-core @ 2023-09-20 18:05 UTC (permalink / raw
  To: ruby-core; +Cc: HParker (Adam Hess)

Issue #19896 has been reported by HParker (Adam Hess).

----------------------------------------
Bug #19896: Ruby method refinement memory leak
https://bugs.ruby-lang.org/issues/19896

* Author: HParker (Adam Hess)
* Status: Open
* Priority: Normal
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN
----------------------------------------
GitHub pull request: https://github.com/ruby/ruby/pull/8487

When method redefinitions happen, sometimes the final definition does not get cleaned up,

Reproducable with the same script from: https://bugs.ruby-lang.org/issues/19894

``` ruby
10.times do
  20_000.times do
    $c = Class.new do
      def foo; end
    end

    $m = Module.new do
      refine $c do
        def foo; end
      end
    end

    Class.new do
      using $m

      def initialize
        o = $c.new
        o.method(:foo).unbind
      end
    end.new
  end

  puts `ps -o rss= -p #{$$}`
end
```

before:

```
19792
20944
22224
23504
24784
26064
27344
28624
29776
31056
```

after:

```
18560
18560
18560
18560
18560
18560
18560
18560
18560
18560
```




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [ruby-core:114929] [Ruby master Bug#19896] Ruby method refinement memory leak
  2023-09-20 18:05 [ruby-core:114847] [Ruby master Bug#19896] Ruby method refinement memory leak HParker (Adam Hess) via ruby-core
@ 2023-09-30  7:07 ` nagachika (Tomoyuki Chikanaga) via ruby-core
  0 siblings, 0 replies; 2+ messages in thread
From: nagachika (Tomoyuki Chikanaga) via ruby-core @ 2023-09-30  7:07 UTC (permalink / raw
  To: ruby-core; +Cc: nagachika (Tomoyuki Chikanaga)

Issue #19896 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: REQUIRED to 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: DONE

ruby_3_2 97b7070ebd5493de8d3a6a9b0ecc91bef5068d3f merged revision(s) 8b236e0c66da8f92e9fc33de66cfbc8e4b0c0763.

----------------------------------------
Bug #19896: Ruby method refinement memory leak
https://bugs.ruby-lang.org/issues/19896#change-104797

* Author: HParker (Adam Hess)
* Status: Closed
* Priority: Normal
* Backport: 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: DONE
----------------------------------------
GitHub pull request: https://github.com/ruby/ruby/pull/8487

When method redefinitions happen, sometimes the final definition does not get cleaned up,

Reproducable with the same script from: https://bugs.ruby-lang.org/issues/19894

``` ruby
10.times do
  20_000.times do
    $c = Class.new do
      def foo; end
    end

    $m = Module.new do
      refine $c do
        def foo; end
      end
    end

    Class.new do
      using $m

      def initialize
        o = $c.new
        o.method(:foo).unbind
      end
    end.new
  end

  puts `ps -o rss= -p #{$$}`
end
```

before:

```
19792
20944
22224
23504
24784
26064
27344
28624
29776
31056
```

after:

```
18560
18560
18560
18560
18560
18560
18560
18560
18560
18560
```




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-30  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-20 18:05 [ruby-core:114847] [Ruby master Bug#19896] Ruby method refinement memory leak HParker (Adam Hess) via ruby-core
2023-09-30  7:07 ` [ruby-core:114929] " nagachika (Tomoyuki Chikanaga) via ruby-core

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).