From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3A8111F545 for ; Fri, 14 Jul 2023 12:09:45 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=TMeZrySO; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=FoHxsjz5; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id C6C4A7FD80; Fri, 14 Jul 2023 12:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1689336576; bh=tdLZj5ghyPjzkyNENbyu+Wx0WM96JyiM8jYnvN+kbK0=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=TMeZrySO3XKbKaq3Ox/et54bt22kkf1yrtyeTDIbcgBrn/l4BJcNEj6sNRBBvgy7J ZBhWkEXP5nHPeXfeXvn5EzasxL0iDE/YxPvEVcyCSVvErwUWahtEpTt3NUka9ja/Ol ER0i6nfBWZmHtIaJWScwvkg5TRHNfUw1aFOwR9tA= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 366B97FD72 for ; Fri, 14 Jul 2023 12:09:33 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=FoHxsjz5; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=TJ6g52MCvkcFBbMjRfsO9vxHa+wxNKy8zqRoxQngRWo=; b=FoHxsjz5O8De7nFmedfnuOHw51kXxPfH+5KhNUac4uFivFpUewn4ZvD0f7rSryEMMLtH TJiIqHSQDQ4mac6wIzFzFTNyukFDsWnQB24l0xkUQjKyhSJqwvN4KJgxZMUXq0D14/WotW vRYuXKpXzCPmp9mqfCnp4a+oqYidovYtIvzWmv9+ymx7+PpgZI8iv9PbQwjjmd8RAvprwM C07Q87wKCiKZCA/BE/nTUNiYJvAdkkvNY+2Yi+g+P2C3Tu5qt5YgvuH+h9XcBDauKclowK fzoM9TDqPm1eZHZ9gJNfsXkx7U/+Y4u3TRmWWgrtI0N6OER/2TTCxHCEpcDSK9vg== Received: by filterdrecv-77869f68cc-qgx7h with SMTP id filterdrecv-77869f68cc-qgx7h-1-64B13AFB-C 2023-07-14 12:09:31.265082582 +0000 UTC m=+5574799.447329771 Received: from herokuapp.com (unknown) by geopod-ismtpd-14 (SG) with ESMTP id WIknMSrmTaWTy4Rtz-qiJg for ; Fri, 14 Jul 2023 12:09:31.216 +0000 (UTC) Date: Fri, 14 Jul 2023 12:09:31 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 18743 X-Redmine-Issue-Author: sos4nt X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: marcper X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 90647 X-SG-EID: =?us-ascii?Q?K75VH2vpOfoVyRxqri=2Fbc2AnHyPKhUg16ACPeXJfGEz39=2FTNvGpagDzNEi=2FKeC?= =?us-ascii?Q?r8dg8TetuvH53sI5+QoRllE1he5CBUy5I3e4uiK?= =?us-ascii?Q?JQaNzeJtGb9t+F1mEvwQsHKkBTBXNV1=2F+fv2jTg?= =?us-ascii?Q?q9SWxd1DjHsp7p6oqT2HTNBcB27Ttv+7vuJ2LpA?= =?us-ascii?Q?sRj+fXn1NoTobD+edmaBI883DdI8hOHz0=2FMwdFO?= =?us-ascii?Q?vo1CgFoqIlockhZPz5IQqqPzcAQqTkRl0kW13Y=2F?= =?us-ascii?Q?5Nn2MlzywGSXlDV56KYbw=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: VLESRZQ2VSAVJUXI5FG3WC6D6M3QFKG3 X-Message-ID-Hash: VLESRZQ2VSAVJUXI5FG3WC6D6M3QFKG3 X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:114185] [Ruby master Bug#18743] Enumerator#next / peek re-use each others stacktraces List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "marcper (Marcelo Pereira) via ruby-core" Cc: "marcper (Marcelo Pereira)" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Issue #18743 has been updated by marcper (Marcelo Pereira). Hello again, @ko1. Please let me know if this patch is acceptable. I follow= ed the suggestions from @nobu already. Best ---------------------------------------- Bug #18743: Enumerator#next / peek re-use each others stacktraces https://bugs.ruby-lang.org/issues/18743#change-103872 * Author: sos4nt (Stefan Sch=FC=DFler) * Status: Open * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- I encountered an odd behavior. If I rescue the `StopIteration` exception from `peek` and call `next` after= wards: (or vice-versa) ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next # 5 ``` it will show the stacktrace from the rescued `peek` call: ``` $ ruby enum.rb enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` Whereas the error should refer to `next` on line number 5. The same happens when calling `peek` after `next` or when having muliple `p= eek` / `next` calls: ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next rescue nil # 5 enum.peek rescue nil # 6 puts "line #{__LINE__}" # 7 enum.next # 8 ``` The stacktrace from the first (rescued) `peek` or `next` call will be shown= which doesn't reflect the actual error location: ``` $ ruby enum.rb line 7 enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` This is very confusing when debugging code. ---Files-------------------------------- 01-Recreate-stacktrace-enumerator.patch (1.29 KB) --=20 https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-c= ore.ml.ruby-lang.org/