From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 81AB91F545 for ; Mon, 26 Jun 2023 19:41:41 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=W1fU7TEL; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=aEb4wMVB; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id A323A7FA67; Mon, 26 Jun 2023 19:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1687808492; bh=Yxt5k/yCOY6x6ovXvNrWagJ2KXdPmtISRO+R2NlsxIE=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=W1fU7TELxMDDNzJSDaohb12kfxaOSqw+fwo34ObKkelFCMHxrNbnYpGL0E+IPdLMq AzkZy5x/dcIZLRsq1t2ZerYTcG7Rb9jjLL2ZkO5B42Lb7m2j0LS4yN3IqQi8h+82dF WGDH+jDEvkE8Abtm4xNakbyfNCgF/HRGrMEZGQsw= Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by nue.mailmanlists.eu (Postfix) with ESMTPS id CB7C27FA5A for ; Mon, 26 Jun 2023 19:41:28 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=aEb4wMVB; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=r5/5B3jWXBNpZMQPuuwgG0s2hEDTDU/2VLMERFCSJJ0=; b=aEb4wMVBdYhj/ZbpHGYoDkWa+73b62e4A094gOsOvV6sd+JmmVgasenH7+VPMGVF5KkP YRunN0KMjgxBnbzb4WXj8Ars1KlamkmWUGYQ0qUipGRlAVXMGEXOPYz2uWlPUTtF582ysy DIafbQEUWuVY8TEqXNETptzKOwu0cx8nSlQfueZvb+32cggB0a5xr6YmsE852ib39L92Cx wggLcbR2/IL/wArgQ8DSjacHws1om2dYZz0LJOh9xpWwLBrHAg5LgkIhZ933qgSFNFm2J5 Tm2CB/4k7ahJVmPAXrZGvXJAM0oLq34pgIsuA6j2C4fzpDCqO6FQH1Z7hBzcPV1w== Received: by filterdrecv-84b96456cb-nmfzw with SMTP id filterdrecv-84b96456cb-nmfzw-1-6499E9E6-24 2023-06-26 19:41:26.728389192 +0000 UTC m=+4046561.458607167 Received: from herokuapp.com (unknown) by geopod-ismtpd-4 (SG) with ESMTP id qEGfMpArTYOwUMjZNhiCpw for ; Mon, 26 Jun 2023 19:41:26.492 +0000 (UTC) Date: Mon, 26 Jun 2023 19:41:26 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 18743 X-Redmine-Issue-Author: sos4nt X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: marcper X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 90487 X-SG-EID: =?us-ascii?Q?K75VH2vpOfoVyRxqri=2Fbc2AnHyPKhUg16ACPeXJfGEz39=2FTNvGpagDzNEi=2FKeC?= =?us-ascii?Q?r8dg8TetuvH53sI5+QoRllE1he5CBUy5I3e4uiK?= =?us-ascii?Q?JQaNzcWdPCAPN2H5T6SEQF3h1Z=2F27Oc+8sEvnI6?= =?us-ascii?Q?KCCivDW7ECvn7yslNma00g6FNYvYAXa2GBBud6B?= =?us-ascii?Q?gyGsYaVQUL8HGIKF+xzWqn=2FutP5WZNdxhRjMX=2FK?= =?us-ascii?Q?R=2Foe2vkmFhWA31bVCOYEcncqDq=2FZYRcT67KJnHt?= =?us-ascii?Q?Bb88qZDszw5ICYBHftrOw=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: YUBVQLPBALXO26Q4P3NRO4MHBGZK4A3T X-Message-ID-Hash: YUBVQLPBALXO26Q4P3NRO4MHBGZK4A3T X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:114024] [Ruby master Bug#18743] Enumerator#next / peek re-use each others stacktraces List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "marcper (Marcelo Pereira) via ruby-core" Cc: "marcper (Marcelo Pereira)" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Issue #18743 has been updated by marcper (Marcelo Pereira). Oh, I understood from Matz's initial suggestion that the exceptions should = be chained, but I see now what he meant. I've applied the changes you sugge= sted, @nobu. Thank you for clarifying, and for reviewing. ---------------------------------------- Bug #18743: Enumerator#next / peek re-use each others stacktraces https://bugs.ruby-lang.org/issues/18743#change-103688 * Author: sos4nt (Stefan Sch=FC=DFler) * Status: Open * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- I encountered an odd behavior. If I rescue the `StopIteration` exception from `peek` and call `next` after= wards: (or vice-versa) ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next # 5 ``` it will show the stacktrace from the rescued `peek` call: ``` $ ruby enum.rb enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` Whereas the error should refer to `next` on line number 5. The same happens when calling `peek` after `next` or when having muliple `p= eek` / `next` calls: ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next rescue nil # 5 enum.peek rescue nil # 6 puts "line #{__LINE__}" # 7 enum.next # 8 ``` The stacktrace from the first (rescued) `peek` or `next` call will be shown= which doesn't reflect the actual error location: ``` $ ruby enum.rb line 7 enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` This is very confusing when debugging code. ---Files-------------------------------- 01-Recreate-stacktrace-enumerator.patch (1.29 KB) --=20 https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-c= ore.ml.ruby-lang.org/