From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2218F1F542 for ; Wed, 7 Jun 2023 06:48:40 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=W8Qhov3e; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=WXuETG4B; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id A46797F87A; Wed, 7 Jun 2023 06:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1686120511; bh=Xqpr/rwBtvXJOCLB4T/Epq3jfifap6qu+VtYAXsBQYI=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=W8Qhov3eEkYGH4rC4ufjqe3w5YU7RqrI6m5+pV5W009NlSHeSdqEPYe0pgBTxABoB 3G/gLWv4miOZUgo8QCbtT6f9VTlWz/tstuKigccbUC/5o1fVJBuaa6RUNobgcJ/FXE O/nxw2kr0gaE9dYL6zQyqmyFgVGyf1XS1xJGMmNo= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 6370B7F84E for ; Wed, 7 Jun 2023 06:48:27 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=WXuETG4B; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=jxOzFE5fPKSiVyTQ9ozhL5HZTq1M2kI12iD/RLqnvhs=; b=WXuETG4BIlAANmQPNB98OEtD/DNOlSD39/wZB0912AFtJw8GCyzVPcZd1vt8r254lNdy RxZTZzCDclREcK8gITsHkf4rQLnSqSZl0cDOpIY22+lyleLMuE86EPvOaehAp/LCfqUYlX bDebOYBb/qHtF/FgJLItX72aktTepeBJkPmfQW8mCRUzn1A+R/SwopIfg1uRTw9D62khm2 2eq4sn+aE8/574SuaPRht2iHOGVKrODntnEzAZ29vY8wKuusMJ/ZwBL6uA5auiZ+Gt2P8R qxLOQBS/+D7crW/ZqOJ2j77cgqXsV/SUBVOgyqM9mKARWDbdOKVaH+9nJAOebNhw== Received: by filterdrecv-d7bbbc8bf-hf4lw with SMTP id filterdrecv-d7bbbc8bf-hf4lw-1-64802839-6 2023-06-07 06:48:25.122751187 +0000 UTC m=+2358518.995314353 Received: from herokuapp.com (unknown) by geopod-ismtpd-11 (SG) with ESMTP id sQ3PO3TMT_GWs85gSrUZDA for ; Wed, 07 Jun 2023 06:48:25.108 +0000 (UTC) Date: Wed, 07 Jun 2023 06:48:25 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 18743 X-Redmine-Issue-Author: sos4nt X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 90253 X-SG-EID: =?us-ascii?Q?rA5eEsXeCy+asKowYcicHxhOSUaOWYD+XnPnBc7LFC8Re9tNQ4Sv5BA=2FOz+glG?= =?us-ascii?Q?+50K4steq4vSjkkyeSAt=2FQpZK6mQgZdK22n=2FlxG?= =?us-ascii?Q?4Fre1AlNDXKxHGWWgSG6qS4RI=2FzfzfTLScxKxOQ?= =?us-ascii?Q?R+F6FIFgybN3XeA48tlIVmxzBD1gJ9ABGV5zf+l?= =?us-ascii?Q?Zuog3qRWiYOdtI5wRxofzUssxJD=2Fs1By6neK1MD?= =?us-ascii?Q?LtWbkmWEYd1wsQSmTPPIHwcmE7b0rxWLTt44lqr?= =?us-ascii?Q?avngYLg8uteAYTGHU6Cng=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: HKEPQOZH6QZ5HTRMJ7XXRGP576ZNX5DR X-Message-ID-Hash: HKEPQOZH6QZ5HTRMJ7XXRGP576ZNX5DR X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:113786] [Ruby master Bug#18743] Enumerator#next / peek re-use each others stacktraces List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nobu (Nobuyoshi Nakada) via ruby-core" Cc: "nobu (Nobuyoshi Nakada)" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Issue #18743 has been updated by nobu (Nobuyoshi Nakada). Your PR makes `stop_exc` to be overwritten for each `StopIteration`. IMO, it should not change and the `cause` of all subsequent `StopIteration`= s should be the same first exception. ---------------------------------------- Bug #18743: Enumerator#next / peek re-use each others stacktraces https://bugs.ruby-lang.org/issues/18743#change-103434 * Author: sos4nt (Stefan Sch=FC=DFler) * Status: Open * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- I encountered an odd behavior. If I rescue the `StopIteration` exception from `peek` and call `next` after= wards: (or vice-versa) ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next # 5 ``` it will show the stacktrace from the rescued `peek` call: ``` $ ruby enum.rb enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` Whereas the error should refer to `next` on line number 5. The same happens when calling `peek` after `next` or when having muliple `p= eek` / `next` calls: ```ruby # enum.rb # 1 # 2 enum =3D [].each # 3 enum.peek rescue nil # 4 enum.next rescue nil # 5 enum.peek rescue nil # 6 puts "line #{__LINE__}" # 7 enum.next # 8 ``` The stacktrace from the first (rescued) `peek` or `next` call will be shown= which doesn't reflect the actual error location: ``` $ ruby enum.rb line 7 enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `
' ``` This is very confusing when debugging code. ---Files-------------------------------- 01-Recreate-stacktrace-enumerator.patch (1.29 KB) --=20 https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-c= ore.ml.ruby-lang.org/