From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5DC0E1F626 for ; Thu, 23 Feb 2023 03:43:46 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=fIVfz4mR; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=ZjGFQK+y; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 2F0E47F408; Thu, 23 Feb 2023 03:43:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1677123820; bh=UZQawCMbJ1EMYE5XNZqhRN3/OMnercxC0MdaGp6SNE4=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=fIVfz4mRMQD3TIawqe2JrWjtuPYZys0QcOHPW8GyNstXF9PSRLA/V3z/1dfJ/Entv XhsK0So/yLAmPhwAyAVSFixLkTd4lMPk98jC+clTpZ5C202ViuxWLVh234LOa36xhh 7gnlD+bFIstXTZelrvEdUIIVYouOmrQ7YiU3QHP8= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 3224B7F405 for ; Thu, 23 Feb 2023 03:43:35 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=ZjGFQK+y; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=i+kmnN5XgQqFuLbDM3kzDYWJSzP0XKJWwPip5EGULXI=; b=ZjGFQK+ySpag+lieXZ8iMNJiXJbzMknoJTI9C3lVT96iNVq8E6CMpBBNeoARTQhCQ6wb 8w8rDnNVVM+R09aGW9KqGyPbTGDsciNKoRQsD5Mt0LSPyKTVGeEMe1wu2hVC5lhn4PYVPY mxfATe8WglaspjlJ8INgZnO5Sxj9er/g5p+zFVqrvU+y/ADHndf4DPxjo4V/A/eiRHgOSB BJujVmm7Ysw491WjmZgKy5DeRMpplQBb4dIGiuhQ1e5+yrfPBgCaq0BBbcK8ySswlceqly PtB6CvmqSBcjfE92PBQOpU3zEUoeLcwlLeU7f61KKSd8WjGV7BUS89bXuuNeWlbA== Received: by filterdrecv-5848969764-q8gbw with SMTP id filterdrecv-5848969764-q8gbw-1-63F6E0E5-5 2023-02-23 03:43:33.287218505 +0000 UTC m=+101524.895053721 Received: from herokuapp.com (unknown) by geopod-ismtpd-2-3 (SG) with ESMTP id b8zRmy6aR2So6EHXOXeK2w for ; Thu, 23 Feb 2023 03:43:33.184 +0000 (UTC) Date: Thu, 23 Feb 2023 03:43:33 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 19153 X-Redmine-Issue-Author: cpinto X-Redmine-Sender: nagachika X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 88930 X-SG-EID: =?us-ascii?Q?5tswmMdpuZtWC+SIdASU151b2aqPGWt2MCGiK8FM5waeDDbfOiDH=2FZvzDCybLH?= =?us-ascii?Q?ac5aUpPkJl2qsSCwuuhJa5kBFsc=2FNuo8RbFzwG3?= =?us-ascii?Q?LHWVN8DXRfdWhVMKUqc2ZZQ51Z4egg4F2VwQBlG?= =?us-ascii?Q?LxGVCbJhncD4IeAn2b2cnqRVKrKXQuYEdORrJBO?= =?us-ascii?Q?NgG+16UD8qshTN581GNFGuxHqKhTtELp0kRF85y?= =?us-ascii?Q?KW9+jBl+2yg+DSx6+rKSIMZSi0cpQ5j15lt3+=2FF?= =?us-ascii?Q?MOpWkkXcRx03eS8pQQ3NA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: HM7V5C7OXZYNDYIBGQGOKF64V7W3KBCV X-Message-ID-Hash: HM7V5C7OXZYNDYIBGQGOKF64V7W3KBCV X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:112544] [Ruby master Bug#19153] Since 2.7.7 CGI::Cookie raises ArgumentError when cookie domains is prefixed with a dot List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nagachika (Tomoyuki Chikanaga) via ruby-core" Cc: "nagachika (Tomoyuki Chikanaga)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #19153 has been updated by nagachika (Tomoyuki Chikanaga). Updated the bundled cgi to 0.3.6 on ruby_3_1 branch. ---------------------------------------- Bug #19153: Since 2.7.7 CGI::Cookie raises ArgumentError when cookie domains is prefixed with a dot https://bugs.ruby-lang.org/issues/19153#change-101989 * Author: cpinto (Celso Pinto) * Status: Closed * Priority: Normal * ruby -v: ruby 2.7.7p221 (2022-11-24 revision 168ec2b1e5) [arm64-darwin22] * Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE ---------------------------------------- The rspec tests of our Rails app started failing with an ArgumentError after upgrading to 2.7.7. On inspection, the issue seems to be caused by CGI::Cookie.domain=: ``` def domain=(str) if str and ((str = str.b).bytesize > 255 or !DOMAIN_VALUE_RE.match?(str)) raise ArgumentError, "invalid domain: #{str.dump}" end @domain = str end ``` Setting a breakpoint: 0> str => ".example.com" 0> DOMAIN_VALUE_RE => /\A(?