From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS24940 94.130.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5484D1F626 for ; Thu, 23 Feb 2023 03:42:38 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=Xw991Bcd; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=JZ949n7f; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 30C3F7F404; Thu, 23 Feb 2023 03:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1677123750; bh=SAQA58qZdR7kTQn2n77sexGt4PBPsYJ+U4iL0nY3YxA=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=Xw991BcdnKnMkYK15Owka5M+4xoCXz5bx+8GO0pLk7DrVPmhAGhb5eEEMi9HkGTce 4E1B8p2/j0qoUucPCIPlE7Dq61q91q0+hNDFSJ5jLqQ8Coe55HajDunxKG+i9xCviZ MPQB6p3W6IHKDEXHd3/dUV6j/kM1sjiiWmutT5RU= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id C870A7F3F7 for ; Thu, 23 Feb 2023 03:42:24 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=JZ949n7f; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=7RQWUQifMfO6rNlWO2HuqD/xUyWKZOpibjd/St/n6ck=; b=JZ949n7f5xiQru4XPPCe5HSY8CYSkgF6rl8KsZUhEoLakYzhBhuL9O6fssmE0qjW2drA 0RAy2tuJZBdxf8jhkpaYi/iQFEci46SDQU3flHBXvmo0U160yYy8HZYve9MCVLfvSWzyah Mv3w/dE/vzdaYzVGCI2S1lSgL8TkYiptxcLA9vByxzYr4nq4hACdNv7JNGOytKjTxdMO95 jhNQRM/Iz7XBtes1EYPli7rvWEMH8Ltj0zbmGvBSRpVmGrk1hlaITXOhaznyoIhCllUjxt Zy8dAdg1YQj3KfVCUxYCfOd192KdJmdaeK4hUoul9zLo/JkAwIAV8gvjUVllFgbw== Received: by filterdrecv-5848969764-s8rvl with SMTP id filterdrecv-5848969764-s8rvl-1-63F6E09E-10 2023-02-23 03:42:22.564323343 +0000 UTC m=+101457.398067066 Received: from herokuapp.com (unknown) by geopod-ismtpd-2-0 (SG) with ESMTP id Vwk6dTx3Rl-hm-z-eU2BQg for ; Thu, 23 Feb 2023 03:42:22.534 +0000 (UTC) Date: Thu, 23 Feb 2023 03:42:22 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 19153 X-Redmine-Issue-Author: cpinto X-Redmine-Sender: nagachika X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 88929 X-SG-EID: =?us-ascii?Q?5tswmMdpuZtWC+SIdASU151b2aqPGWt2MCGiK8FM5waeDDbfOiDH=2FZvzDCybLH?= =?us-ascii?Q?ac5aUpPkJl2qsSCwuuhJa5kBFsc=2FNuo8RbFzwG3?= =?us-ascii?Q?LHWVN8=2FcEFEdQzwvV9LoObGKK2IAb+NWUrRLAEd?= =?us-ascii?Q?QawErZiRW86brAd451PLKInAvvL+mCvOlGLu3ig?= =?us-ascii?Q?+f=2FIP4HeMP07ZtXWad+Fhp702mlTjFsDLWTwEtN?= =?us-ascii?Q?kILzRv2CuN0qaKot7ynR=2Fe2gz+K9ND8OBoo=2FCu7?= =?us-ascii?Q?3L0QkgToLugvpVUwCdNtTajKUKhTcTK5D4gtNEx?= =?us-ascii?Q?tIE=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: XFY2PRGL4HP446GAEOAVRZ6GBF6S5KKN X-Message-ID-Hash: XFY2PRGL4HP446GAEOAVRZ6GBF6S5KKN X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:112543] [Ruby master Bug#19153] Since 2.7.7 CGI::Cookie raises ArgumentError when cookie domains is prefixed with a dot List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nagachika (Tomoyuki Chikanaga) via ruby-core" Cc: "nagachika (Tomoyuki Chikanaga)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #19153 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE ruby_3_1 4141989b2aef2993bb19140a4be355d1c68b8be1 merged revision(s) 656f25987cf2885104d5b13c8d3f5b7d32f1b333,98074a57ca9f3169fe9da9af6c49b636d37db16f,745dcf5326ea2c8e2047a3bddeb0fbb7e7d07649,b335d899fff3cc22b022c9ee2ceb636d714bf1a7. ---------------------------------------- Bug #19153: Since 2.7.7 CGI::Cookie raises ArgumentError when cookie domains is prefixed with a dot https://bugs.ruby-lang.org/issues/19153#change-101988 * Author: cpinto (Celso Pinto) * Status: Closed * Priority: Normal * ruby -v: ruby 2.7.7p221 (2022-11-24 revision 168ec2b1e5) [arm64-darwin22] * Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE ---------------------------------------- The rspec tests of our Rails app started failing with an ArgumentError after upgrading to 2.7.7. On inspection, the issue seems to be caused by CGI::Cookie.domain=: ``` def domain=(str) if str and ((str = str.b).bytesize > 255 or !DOMAIN_VALUE_RE.match?(str)) raise ArgumentError, "invalid domain: #{str.dump}" end @domain = str end ``` Setting a breakpoint: 0> str => ".example.com" 0> DOMAIN_VALUE_RE => /\A(?