From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS24940 94.130.0.0/16 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F18C51F5A0 for ; Fri, 10 Feb 2023 01:37:03 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=1llUINei; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=c0TiuVQO; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id CD4717F1C6; Fri, 10 Feb 2023 01:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1675993016; bh=1796OVNBcuP4D/jhV9DL2IenuF53NbOo/qHsxun0Hgg=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=1llUINei5Ba+P43tKgZOOjE4fP74ehXzuoWd6HLuOhgztEIndZDhJicCELnYfOcyy Pe4XwD5WFGMWEOoZIaqjUN25+Gr12k+zn4qIOifFsPtFm72LIzcjXL1fxhyA6BbGjM lr5F1B6fK4PTwX01zjlaUK8MudIijoGxZNwc/Esc= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 0CB937F1C4 for ; Fri, 10 Feb 2023 01:36:52 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=c0TiuVQO; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=p2lcWAD3tBBg2o+gqh9Y1Ildpjh59op78B4xvboXkgI=; b=c0TiuVQOvWeN3hV3aLElG6Ro0ZakIe5/Dnivbb8TvuqPm1rWfdIjEWWJjrEP5BDBpO5s Pg/+q+uuFypvqfWur1nU8ha4oD+5keiSQ9BHo0z3ppRhaGTcaToENiXrTEDPFYFclL/aYZ fFgzPKgrI14M9zUG5lkhiCe8JWxRBlIyUaE9tiwgKjKbsSI5+80UrSF4DmEcleCLIpG9O9 k3pU4fAI4U1TDqz/DCLHJVK3TxbwnRQG/X3v20H2AFkAO9WbJcw+b57p5Ap/CwmDDtgEFT OQE0GTgSnHu88r0E8KIQmQS52RGhAc/+1FflHdizGpHeP2nLx8RqGxB9xST+U6CA== Received: by filterdrecv-69c5db5cf4-rldx9 with SMTP id filterdrecv-69c5db5cf4-rldx9-1-63E59FB3-5 2023-02-10 01:36:51.096258373 +0000 UTC m=+7266526.231505680 Received: from herokuapp.com (unknown) by geopod-ismtpd-3-1 (SG) with ESMTP id oc0FGLrHTfeyS-ORjzt87g for ; Fri, 10 Feb 2023 01:36:51.066 +0000 (UTC) Date: Fri, 10 Feb 2023 01:36:51 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 11230 X-Redmine-Issue-Author: Eregon X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 88706 X-SG-EID: =?us-ascii?Q?YbSlef6ZOa=2FS=2FuqSxXRzl42MttQDxKOujGe43WuBjI7JKMg2OkmRsyzG5za6L9?= =?us-ascii?Q?e1flZkYZ9OViVy5Lc4acvpZq7f7MJHBwVU12a0E?= =?us-ascii?Q?m2swdd3DKS44=2FMkCORk+I20I1QtUp3Eukz90bp+?= =?us-ascii?Q?zV8CFY4HlW+=2FfsERUrL+6FvmNa9ATCHEZwQUWq8?= =?us-ascii?Q?KNax5OXcezjBE5UXJOB6hFHKj8U8z09ov8dpG86?= =?us-ascii?Q?X22ceSny+9KobRz1q9r1+x8bo+9QfzlLSQKcC5=2F?= =?us-ascii?Q?bX7YICC7GnklKjBPIj5cA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: RDMT2M7DPDLYVGTFZNPBP3OFWWI6LBUQ X-Message-ID-Hash: RDMT2M7DPDLYVGTFZNPBP3OFWWI6LBUQ X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:112318] [Ruby master Bug#11230] Should rb_struct_s_members() be public API? List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "mame (Yusuke Endoh) via ruby-core" Cc: "mame (Yusuke Endoh)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #11230 has been updated by mame (Yusuke Endoh). Discussed at the dev meeting. When we considered removing rb_struct_s_members two years ago, we did not find its use in a major gem. Therefore, we agreed to remove it once. However, two years have passed since then, and now we have found that oj gem is using it. ``` $ gem-codesearch rb_struct_s_members | sort ... 2023-02-01 /srv/gems/oj-3.14.1/ext/oj/custom.c: ma = rb_struct_s_members(clas); 2023-02-01 /srv/gems/oj-3.14.1/ext/oj/dump_object.c: VALUE ma = rb_struct_s_members(clas); 2023-02-01 /srv/gems/oj-3.14.1/ext/oj/rails.c: ma = rb_struct_s_members(rb_obj_class(obj)); ``` It's possible to fix oj gem and have a deprecation warning period. However, it would be easier to just keep this C API, unless there is a strong reason why we really have to remove it. ---------------------------------------- Bug #11230: Should rb_struct_s_members() be public API? https://bugs.ruby-lang.org/issues/11230#change-101759 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal * ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- rb_struct_s_members() is declared in include/ruby/intern.h. However it seems this is a fairly internal API as it returns an hidden Array. For instance, there was a try to specify the behavior in https://github.com/rubinius/rubinius/commit/2642a30c57973987d2a7b7e85b3ce1e78100a31b but that produces only erratic behavior on MRI because that usage is not intended. A valid usage might be: static VALUE get_struct_member(VALUE self, VALUE obj, VALUE i) { return RARRAY_AREF(rb_struct_s_members(obj), NUM2INT(i)); } p get_struct_member(Struct.new(:a, :bb), 1) But do we need such access and is it worth exposing a potentially dangerous function like this? -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/