From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2A9C21F852 for ; Thu, 22 Dec 2022 06:27:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.b="jm1Lqx11"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.b="R6iFPxbv"; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id B5C0F7E61C; Thu, 22 Dec 2022 06:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1671690458; bh=Ym7N769ylyrpx8GzImGquR8DZgBfahparapHkOM9hhA=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=jm1Lqx11+pT/q2god+poAUFpMe8QQdXYdm8bKMpo7NbuIKWbRtoCDT+tAO5ihO8/+ tSc3qRSet+wWH0PgbfK1kwAg3vq0jUgiZsEVzkhj8/2rydWTi99xBhqq5WFh6BdT/Q JnNSB7w6kBMAx2nbZLrcw8wIjRqC8x4IFcuiFpiU= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id B21027E5EF for ; Thu, 22 Dec 2022 06:27:33 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=R6iFPxbv; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=fWxlCuEGjv7XnFvKDmUqvsZlIvnf6NJQDlOPZ3cfpyg=; b=R6iFPxbvxI55NsdO0dEH71zQEp2F/yTCJM8/DTncg/spMBVcMKs4v29IdaseDiGU/kwH yrMAMqvteaNc8lyoHZXsKVbqPU7sDv4EwVYWgcI4GLfs/oR0PVEzNXHt7rIGqFmITgEA5Y qq0GtV03wIz4bKE8pbpYdetYNIMM2l1ENefHn9T8wFF2mc5Fo12JsdKbh5ywaG6usvgIa4 MyM9AKhXwrqcflFsLxigIWO5VQMMixRLkLOZ1hEnkidtd7JKzo66/z74pMFTLD4FkLP2jG nbce5j7BCfnwgyIzMdlC0cb5WDLTxXE99wwMgvC/2E0ogo/mB+MHLITAAE0FJAVA== Received: by filterdrecv-8569859b9-lj5g6 with SMTP id filterdrecv-8569859b9-lj5g6-1-63A3F8D4-D 2022-12-22 06:27:32.539638679 +0000 UTC m=+2964043.713478034 Received: from herokuapp.com (unknown) by geopod-ismtpd-3-3 (SG) with ESMTP id 2p9gqPzzTauijUOCMopjyA for ; Thu, 22 Dec 2022 06:27:32.478 +0000 (UTC) Date: Thu, 22 Dec 2022 06:27:32 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 19187 X-Redmine-Issue-Author: coolo X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 87780 X-SG-EID: =?us-ascii?Q?rA5eEsXeCy+asKowYcicHxhOSUaOWYD+XnPnBc7LFC8Re9tNQ4Sv5BA=2FOz+glG?= =?us-ascii?Q?+50K4steq4vSjkkyeSAt=2FQpZK6mQgZdK22n=2FlxG?= =?us-ascii?Q?4Fre1Au8kzIotlkhBHpo6ZzpyGhOAX1uUorTZcV?= =?us-ascii?Q?0UZiCXeC8nAl4ItEH=2F=2FLRUkTDeq540GN3UbEkit?= =?us-ascii?Q?7damy+R6bB1mXBuVa9JC7Q9tmIdHc3xPk34SyVN?= =?us-ascii?Q?JHrpKHRRdt5r8ZAfmZIEpBgjsDBTyfyRgLxkGBT?= =?us-ascii?Q?sJizBr8o+a3BYpJCq8NFQ=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: SRK4LJXRY4X44UDIIWTN6R34QSS4AYZX X-Message-ID-Hash: SRK4LJXRY4X44UDIIWTN6R34QSS4AYZX X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:111380] [Ruby master Bug#19187] Ruby 3.1.3 testsuite fails after timezone 2022g update is applied List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nobu (Nobuyoshi Nakada) via ruby-core" Cc: "nobu (Nobuyoshi Nakada)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #19187 has been updated by nobu (Nobuyoshi Nakada). mame (Yusuke Endoh) wrote in #note-7: > We need to test our logic to handle leap seconds, etc. > If we remove the dependency on tzdata, I think we need to mock tzdata and test our logic. I understand your concern, but the changes in [GH-6990] should be unrelated to leap seconds. [GH-6990]: https://github.com/ruby/ruby/pull/6990 ---------------------------------------- Bug #19187: Ruby 3.1.3 testsuite fails after timezone 2022g update is applied https://bugs.ruby-lang.org/issues/19187#change-100755 * Author: coolo (Stephan Kulow) * Status: Closed * Priority: Normal * ruby -v: ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux-gnu] * Backport: 2.7: DONE, 3.0: DONE, 3.1: DONE ---------------------------------------- The timezone database changed incompatible to what ruby's testsuite expects. See the announcement here: http://mm.icann.org/pipermail/tz-announce/2022-November/000076.html and note the little detail Singapore's 1981-12-31 change was at 16:00 UTC (23:30 local time), not 24:00 local time. (Thanks to Geoff Clare via Robert Elz.) Problem is that test/ruby/test_time_tz.rb tests this very detail in 3 places - and breaks. 1) Failure: TestTimeTZ#test_asia_singapore [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:143]: TZ=Asia/Singapore Time.local(1981, 12, 31, 23, 59, 59). <"1981-12-31 23:59:59 +0730"> expected but was <"1982-01-01 00:29:59 +0800">. 2) Failure: TestTimeTZ#test_gen_Asia_Singapore_22 [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:382]: TZ=Asia/Singapore Time.utc(1981, 12, 31, 16, 29, 59).localtime. <"1981-12-31 23:59:59 +0730"> expected but was <"1982-01-01 00:29:59 +0800">. 3) Failure: TestTimeTZ#test_gen_Asia_Singapore_45 [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:400]: TZ=Asia/Singapore Time.local(1981, 12, 31, 23, 59, 59). <"1981-12-31 23:59:59 +0730"> expected but was <"1982-01-01 00:29:59 +0800">. I can see no other option than not to test this detail - because relying on correct timezone data (either way) is barely possible. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/