From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 75FD41F852 for ; Wed, 21 Dec 2022 14:09:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.b="s931Kwj1"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.b="fsSwlAuf"; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 758D17F04B; Wed, 21 Dec 2022 14:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1671631759; bh=H8W90l4QD0FFSB8o0ZZ57qReK98lZTkNnVF+f4zTrYo=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=s931Kwj1+vRBkGsW+9L6czvqoChOm1GBgS5LLSzLWDqP0a/mS8H1kj4PjKjTGTs8+ IRIH+7v0hJJ9FjLqEWDZfBtFRB4tjxGOHeKhfcoGbvrjgfKKYeSgr6r7wM8Or96hc7 hDbfwQMWp25heA6A/27s7TbaQ7XMIpbUBqrcUO7A= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id E660E7F041 for ; Wed, 21 Dec 2022 14:09:14 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=fsSwlAuf; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=Rc5H5hk8TPGkc8xYmP4svPZqjq9TKo+NvfVVSVfhbQU=; b=fsSwlAuf74dNrOyrsCJly9KP1OQpkeGMWx+y4xivLsNcQP9zBYhLbeoX5jBUZkWw1fAT qrOqRKTcRB0uuqEY9ESr+Yovz+wa+eeLtcmYmAXY/xF4+agAT7IcRewjhXhS5svhY7QpMw OobiUYmeDQQVOpRaCn9Hh5ZRmm5Z1D/fDaTc2N652LKMRVd90MSHYiq/WmqqOr5/wzcmKd lGivRvKs9egytmX2pOnijX1fDdLHE6HY6PqYaw9UZLrAmjHRSiRauVDxoZCtFsToPR6pza xA5OLmBbE1qInh3HUVPdKM4MvalLlc9fT/wLl6D/MczXncVS+zac+lBaC5D6v1eg== Received: by filterdrecv-6c4ccfbdd8-wnrfr with SMTP id filterdrecv-6c4ccfbdd8-wnrfr-1-63A31389-E 2022-12-21 14:09:13.192411773 +0000 UTC m=+2905421.644525929 Received: from herokuapp.com (unknown) by geopod-ismtpd-1-2 (SG) with ESMTP id bgnWFYLCTNaGQCL8M4OotQ for ; Wed, 21 Dec 2022 14:09:13.065 +0000 (UTC) Date: Wed, 21 Dec 2022 14:09:13 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 19187 X-Redmine-Issue-Author: coolo X-Redmine-Sender: vo.x X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 87760 X-SG-EID: =?us-ascii?Q?1BO5E1LXHcjbGn447qx9J3bLqJckwjkYxnet3qAAIKG0Q+gfRSAYCxFkjK=2FtB1?= =?us-ascii?Q?M2=2FIxYQQYM565yajRHmjHwlWWifNFqHIeuPYBip?= =?us-ascii?Q?ePGhaOOvTFaaA8wu7QAJ4aMLhyGu9FLk7IUKk1q?= =?us-ascii?Q?B4BwYyLhNluJ18NmDxiOKBEQxJQsgPRCcbwDOIS?= =?us-ascii?Q?9=2F=2F3iTvk=2FOxRx+xHAEjf7VkIjdW63WsFqljaM5F?= =?us-ascii?Q?+AjPgGH3SxjB0QkokOgSyRLXdJ3y+K8VOSVQsJ=2F?= =?us-ascii?Q?VQTl8jfqYA7K7vEdlxk9Q=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: PZ25PH54CNRTW5WH44MEZYQPV7JXLHA2 X-Message-ID-Hash: PZ25PH54CNRTW5WH44MEZYQPV7JXLHA2 X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:111360] [Ruby master Bug#19187] Ruby 3.1.3 testsuite fails after timezone 2022g update is applied List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "vo.x (Vit Ondruch) via ruby-core" Cc: "vo.x (Vit Ondruch)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #19187 has been updated by vo.x (Vit Ondruch). nobu (Nobuyoshi Nakada) wrote in #note-2: > coolo (Stephan Kulow) wrote: > > I can see no other option than not to test this detail - because relying on correct timezone data (either way) is barely possible. > > I agree that we should not test tzdata itself. > https://github.com/nobu/ruby/tree/tzdata-nitpick Was this proposal forgotten or is this going to land? ---------------------------------------- Bug #19187: Ruby 3.1.3 testsuite fails after timezone 2022g update is applied https://bugs.ruby-lang.org/issues/19187#change-100736 * Author: coolo (Stephan Kulow) * Status: Closed * Priority: Normal * ruby -v: ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux-gnu] * Backport: 2.7: DONE, 3.0: DONE, 3.1: DONE ---------------------------------------- The timezone database changed incompatible to what ruby's testsuite expects. See the announcement here: http://mm.icann.org/pipermail/tz-announce/2022-November/000076.html and note the little detail Singapore's 1981-12-31 change was at 16:00 UTC (23:30 local time), not 24:00 local time. (Thanks to Geoff Clare via Robert Elz.) Problem is that test/ruby/test_time_tz.rb tests this very detail in 3 places - and breaks. 1) Failure: TestTimeTZ#test_asia_singapore [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:143]: TZ=Asia/Singapore Time.local(1981, 12, 31, 23, 59, 59). <"1981-12-31 23:59:59 +0730"> expected but was <"1982-01-01 00:29:59 +0800">. 2) Failure: TestTimeTZ#test_gen_Asia_Singapore_22 [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:382]: TZ=Asia/Singapore Time.utc(1981, 12, 31, 16, 29, 59).localtime. <"1981-12-31 23:59:59 +0730"> expected but was <"1982-01-01 00:29:59 +0800">. 3) Failure: TestTimeTZ#test_gen_Asia_Singapore_45 [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:400]: TZ=Asia/Singapore Time.local(1981, 12, 31, 23, 59, 59). <"1981-12-31 23:59:59 +0730"> expected but was <"1982-01-01 00:29:59 +0800">. I can see no other option than not to test this detail - because relying on correct timezone data (either way) is barely possible. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/