From: "usa (Usaku NAKAMURA)" <noreply@ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Subject: [ruby-core:111236] [Ruby master Bug#19187] Ruby 3.1.3 testsuite fails after timezone 2022g update is applied
Date: Thu, 08 Dec 2022 03:35:01 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-100525.20221208033500.52588@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-19187.20221206113353.52588@ruby-lang.org
Issue #19187 has been updated by usa (Usaku NAKAMURA).
Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: DONE, 3.0: REQUIRED, 3.1: REQUIRED
ruby_2_7 36cadad6434bc31bc2d60697698cd5b930c097ce merged revision(s) 58cc3c9f.
----------------------------------------
Bug #19187: Ruby 3.1.3 testsuite fails after timezone 2022g update is applied
https://bugs.ruby-lang.org/issues/19187#change-100525
* Author: coolo (Stephan Kulow)
* Status: Closed
* Priority: Normal
* ruby -v: ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux-gnu]
* Backport: 2.7: DONE, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
The timezone database changed incompatible to what ruby's testsuite expects.
See the announcement here: http://mm.icann.org/pipermail/tz-announce/2022-November/000076.html and note the little detail
Singapore's 1981-12-31 change was at 16:00 UTC (23:30 local time),
not 24:00 local time. (Thanks to Geoff Clare via Robert Elz.)
Problem is that test/ruby/test_time_tz.rb tests this very detail in 3 places - and breaks.
1) Failure:
TestTimeTZ#test_asia_singapore [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:143]:
TZ=Asia/Singapore Time.local(1981, 12, 31, 23, 59, 59).
<"1981-12-31 23:59:59 +0730"> expected but was
<"1982-01-01 00:29:59 +0800">.
2) Failure:
TestTimeTZ#test_gen_Asia_Singapore_22 [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:382]:
TZ=Asia/Singapore Time.utc(1981, 12, 31, 16, 29, 59).localtime.
<"1981-12-31 23:59:59 +0730"> expected but was
<"1982-01-01 00:29:59 +0800">.
3) Failure:
TestTimeTZ#test_gen_Asia_Singapore_45 [/home/abuild/rpmbuild/BUILD/ruby-3.1.3/test/ruby/test_time_tz.rb:400]:
TZ=Asia/Singapore Time.local(1981, 12, 31, 23, 59, 59).
<"1981-12-31 23:59:59 +0730"> expected but was
<"1982-01-01 00:29:59 +0800">.
I can see no other option than not to test this detail - because relying on correct timezone data (either way) is barely possible.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
next prev parent reply other threads:[~2022-12-08 3:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 11:33 [ruby-core:111220] [Ruby master Bug#19187] Ruby 3.1.3 testsuite fails after timezone 2022g update is applied coolo (Stephan Kulow)
2022-12-07 10:41 ` [ruby-core:111230] " nagachika (Tomoyuki Chikanaga)
2022-12-07 12:47 ` [ruby-core:111231] " nobu (Nobuyoshi Nakada)
2022-12-08 3:35 ` usa (Usaku NAKAMURA) [this message]
2022-12-08 3:35 ` [ruby-core:111237] " usa (Usaku NAKAMURA)
2022-12-09 12:12 ` [ruby-core:111245] " nagachika (Tomoyuki Chikanaga)
2022-12-21 14:09 ` [ruby-core:111360] " vo.x (Vit Ondruch) via ruby-core
2022-12-22 4:53 ` [ruby-core:111378] " mame (Yusuke Endoh) via ruby-core
2022-12-22 6:00 ` [ruby-core:111379] " duerst via ruby-core
2022-12-22 6:27 ` [ruby-core:111380] " nobu (Nobuyoshi Nakada) via ruby-core
2022-12-22 8:19 ` [ruby-core:111382] " vo.x (Vit Ondruch) via ruby-core
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-100525.20221208033500.52588@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).