From: "mame (Yusuke Endoh)" <noreply@ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Subject: [ruby-core:111226] [Ruby master Bug#19188] Ruby 2.7.7 CGI Cookie Processing
Date: Wed, 07 Dec 2022 03:55:10 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-100515.20221207035509.51925@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-19188.20221206182642.51925@ruby-lang.org
Issue #19188 has been updated by mame (Yusuke Endoh).
You may want to use cgi gem 0.3.6
----------------------------------------
Bug #19188: Ruby 2.7.7 CGI Cookie Processing
https://bugs.ruby-lang.org/issues/19188#change-100515
* Author: apremdas@yahoo.co.uk (Andrew Premdas)
* Status: Closed
* Priority: Normal
* ruby -v: ruby 2.7.7p221 (2022-11-24 revision 168ec2b1e5) [arm64-darwin22]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
This is my first bug report here, apologies if I mess things up.
Ruby 2.7.7 introduced a code change in lib/ruby/2.7.0/cgi/cookie.rb. There is now a custom setter for the domain attribute. You can see me debugging this below
```
126: def domain=(str)
127: byebug
=> 128: if str and ((str = str.b).bytesize > 255 or !DOMAIN_VALUE_RE.match?(str))
129: raise ArgumentError, "invalid domain: #{str.dump}"
130: end
```
When you are running a test on rails using capybara and rspec the value of domain will be ".example.com". This value is the same on ruby 2.7.6. The new code in 2.7.7 rejects this code as an invalid domain because `DOMAIN_VALUE_RE.match?(str)` is false.
I think `DOMAIN_VALUE_RE` needs to be changed so it matches ".example.com" otherwise lots of tests on Rails applications are going to fail
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
prev parent reply other threads:[~2022-12-07 3:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 18:26 [ruby-core:111221] [Ruby master Bug#19188] Ruby 2.7.7 CGI Cookie Processing apremdas@yahoo.co.uk (Andrew Premdas)
2022-12-06 18:39 ` [ruby-core:111223] " alanwu (Alan Wu)
2022-12-07 3:55 ` mame (Yusuke Endoh) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-100515.20221207035509.51925@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).