* [ruby-core:61441] [ruby-trunk - Bug #9627] [Open] SMTP does not properly dot-stuff an unterminated last line
[not found] <redmine.issue-9627.20140312201024@ruby-lang.org>
@ 2014-03-12 20:10 ` me
2014-03-13 21:08 ` [ruby-core:61479] [ruby-trunk - Bug #9627] " me
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: me @ 2014-03-12 20:10 UTC (permalink / raw
To: ruby-core
Issue #9627 has been reported by Josh Goebel.
----------------------------------------
Bug #9627: SMTP does not properly dot-stuff an unterminated last line
https://bugs.ruby-lang.org/issues/9627
* Author: Josh Goebel
* Status: Open
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
* ruby -v: ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-linux]
* Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
```
str = "Date: Wed, 12 Mar 2014 16:02:26 -0400\r\nFrom: someone@aol.com\r\nTo: someone@aol.com\r\nMessage-ID: <5320bd52be4d3_6d653fd3d8c339e458df@Joshs-MacBook-Pro.local.mail>\r\nMime-Version: 1.0\r\nContent-Type: text/plain;\r\n charset=UTF-8\r\nContent-Transfer-Encoding: 7bit\r\n\r\nlook, a period with no endline\r\n."
smtp = Net::SMTP.new(...)
smtp.start(...) do |smtp_obj|
response = smtp_obj.sendmail(message, "someone@aol.com","someone@aol.com")
end
```
The SMTP server is going to throw a 400 or 500 error (depending on it's configuration) because the last period is send un-stuffed in the DATA block:
```
look, a period with no endline
.
.
```
When it should be:
```
look, a period with no end line
..
.
```
(ie, not dot-stuffed) and the second period the SMTP server doesn't know what to do with. Adding an additional new-line fixes the problem, but I the in-line documentation for SMTP send_message does not say anything about a new-line being requires for message sending to work.
Sorry, I can't test against the latest Ruby right now, but this is confirmed against 1.9.3 r448. If someone can confirm against newer that would be great.
I did do a search for "SMTP" and did not see this reported anywhere in the Issues database.
I had originally filed a pull request against Mail: https://github.com/mikel/mail/pull/683
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:61479] [ruby-trunk - Bug #9627] SMTP does not properly dot-stuff an unterminated last line
[not found] <redmine.issue-9627.20140312201024@ruby-lang.org>
2014-03-12 20:10 ` [ruby-core:61441] [ruby-trunk - Bug #9627] [Open] SMTP does not properly dot-stuff an unterminated last line me
@ 2014-03-13 21:08 ` me
2014-05-23 12:36 ` [ruby-core:62709] [ruby-trunk - Bug #9627] [Closed] " nobu
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: me @ 2014-03-13 21:08 UTC (permalink / raw
To: ruby-core
Issue #9627 has been updated by Josh Goebel.
If I'm understanding this properly I think this monkey-patch is all it takes to fix it:
```
module Net
class InternetMessageIO
def using_each_crlf_line
@wbuf = ''
yield
if not @wbuf.empty? # unterminated last line
write0 dot_stuff(@wbuf.chomp) + "\r\n"
elsif @written_bytes == 0 # empty src
write0 "\r\n"
end
write0 ".\r\n"
@wbuf = nil
end
def dot_stuff(s)
s.sub(/\A\./, '..')
end
end
end
```
You simply have to dot-stuff the remaining buffer if necessary...
----------------------------------------
Bug #9627: SMTP does not properly dot-stuff an unterminated last line
https://bugs.ruby-lang.org/issues/9627#change-45770
* Author: Josh Goebel
* Status: Open
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
* ruby -v: ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-linux]
* Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
```
str = "Date: Wed, 12 Mar 2014 16:02:26 -0400\r\nFrom: someone@aol.com\r\nTo: someone@aol.com\r\nMessage-ID: <5320bd52be4d3_6d653fd3d8c339e458df@Joshs-MacBook-Pro.local.mail>\r\nMime-Version: 1.0\r\nContent-Type: text/plain;\r\n charset=UTF-8\r\nContent-Transfer-Encoding: 7bit\r\n\r\nlook, a period with no endline\r\n."
smtp = Net::SMTP.new(...)
smtp.start(...) do |smtp_obj|
response = smtp_obj.sendmail(message, "someone@aol.com","someone@aol.com")
end
```
The SMTP server is going to throw a 400 or 500 error (depending on it's configuration) because the last period is send un-stuffed in the DATA block:
```
look, a period with no endline
.
.
```
When it should be:
```
look, a period with no end line
..
.
```
(ie, not dot-stuffed) and the second period the SMTP server doesn't know what to do with. Adding an additional new-line fixes the problem, but I the in-line documentation for SMTP send_message does not say anything about a new-line being requires for message sending to work.
Sorry, I can't test against the latest Ruby right now, but this is confirmed against 1.9.3 r448. If someone can confirm against newer that would be great.
I did do a search for "SMTP" and did not see this reported anywhere in the Issues database.
I had originally filed a pull request against Mail: https://github.com/mikel/mail/pull/683
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:62709] [ruby-trunk - Bug #9627] [Closed] SMTP does not properly dot-stuff an unterminated last line
[not found] <redmine.issue-9627.20140312201024@ruby-lang.org>
2014-03-12 20:10 ` [ruby-core:61441] [ruby-trunk - Bug #9627] [Open] SMTP does not properly dot-stuff an unterminated last line me
2014-03-13 21:08 ` [ruby-core:61479] [ruby-trunk - Bug #9627] " me
@ 2014-05-23 12:36 ` nobu
2014-05-23 21:26 ` [ruby-core:62711] [ruby-trunk - Bug #9627] " drbrain
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: nobu @ 2014-05-23 12:36 UTC (permalink / raw
To: ruby-core
Issue #9627 has been updated by Nobuyoshi Nakada.
Status changed from Open to Closed
% Done changed from 0 to 100
Applied in changeset r46060.
----------
net/protocol.rb: fix SMTP dot stuffing
* net/protocol.rb (using_each_crlf_line): fix SMTP dot-stuffing
for messages not ending with a new-line.
[ruby-core:61441] [Bug #9627] [fix GH-616]
----------------------------------------
Bug #9627: SMTP does not properly dot-stuff an unterminated last line
https://bugs.ruby-lang.org/issues/9627#change-46833
* Author: Josh Goebel
* Status: Closed
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
* ruby -v: ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-linux]
* Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
```
str = "Date: Wed, 12 Mar 2014 16:02:26 -0400\r\nFrom: someone@aol.com\r\nTo: someone@aol.com\r\nMessage-ID: <5320bd52be4d3_6d653fd3d8c339e458df@Joshs-MacBook-Pro.local.mail>\r\nMime-Version: 1.0\r\nContent-Type: text/plain;\r\n charset=UTF-8\r\nContent-Transfer-Encoding: 7bit\r\n\r\nlook, a period with no endline\r\n."
smtp = Net::SMTP.new(...)
smtp.start(...) do |smtp_obj|
response = smtp_obj.sendmail(message, "someone@aol.com","someone@aol.com")
end
```
The SMTP server is going to throw a 400 or 500 error (depending on it's configuration) because the last period is send un-stuffed in the DATA block:
```
look, a period with no endline
.
.
```
When it should be:
```
look, a period with no end line
..
.
```
(ie, not dot-stuffed) and the second period the SMTP server doesn't know what to do with. Adding an additional new-line fixes the problem, but I the in-line documentation for SMTP send_message does not say anything about a new-line being requires for message sending to work.
Sorry, I can't test against the latest Ruby right now, but this is confirmed against 1.9.3 r448. If someone can confirm against newer that would be great.
I did do a search for "SMTP" and did not see this reported anywhere in the Issues database.
I had originally filed a pull request against Mail: https://github.com/mikel/mail/pull/683
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:62711] [ruby-trunk - Bug #9627] SMTP does not properly dot-stuff an unterminated last line
[not found] <redmine.issue-9627.20140312201024@ruby-lang.org>
` (2 preceding siblings ...)
2014-05-23 12:36 ` [ruby-core:62709] [ruby-trunk - Bug #9627] [Closed] " nobu
@ 2014-05-23 21:26 ` drbrain
2014-06-22 16:54 ` [ruby-core:63276] " nagachika00
2014-06-23 9:45 ` [ruby-core:63293] " usa
5 siblings, 0 replies; 6+ messages in thread
From: drbrain @ 2014-05-23 21:26 UTC (permalink / raw
To: ruby-core
Issue #9627 has been updated by Eric Hodel.
Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
Bug #9627: SMTP does not properly dot-stuff an unterminated last line
https://bugs.ruby-lang.org/issues/9627#change-46835
* Author: Josh Goebel
* Status: Closed
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
* ruby -v: ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-linux]
* Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
```
str = "Date: Wed, 12 Mar 2014 16:02:26 -0400\r\nFrom: someone@aol.com\r\nTo: someone@aol.com\r\nMessage-ID: <5320bd52be4d3_6d653fd3d8c339e458df@Joshs-MacBook-Pro.local.mail>\r\nMime-Version: 1.0\r\nContent-Type: text/plain;\r\n charset=UTF-8\r\nContent-Transfer-Encoding: 7bit\r\n\r\nlook, a period with no endline\r\n."
smtp = Net::SMTP.new(...)
smtp.start(...) do |smtp_obj|
response = smtp_obj.sendmail(message, "someone@aol.com","someone@aol.com")
end
```
The SMTP server is going to throw a 400 or 500 error (depending on it's configuration) because the last period is send un-stuffed in the DATA block:
```
look, a period with no endline
.
.
```
When it should be:
```
look, a period with no end line
..
.
```
(ie, not dot-stuffed) and the second period the SMTP server doesn't know what to do with. Adding an additional new-line fixes the problem, but I the in-line documentation for SMTP send_message does not say anything about a new-line being requires for message sending to work.
Sorry, I can't test against the latest Ruby right now, but this is confirmed against 1.9.3 r448. If someone can confirm against newer that would be great.
I did do a search for "SMTP" and did not see this reported anywhere in the Issues database.
I had originally filed a pull request against Mail: https://github.com/mikel/mail/pull/683
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:63276] [ruby-trunk - Bug #9627] SMTP does not properly dot-stuff an unterminated last line
[not found] <redmine.issue-9627.20140312201024@ruby-lang.org>
` (3 preceding siblings ...)
2014-05-23 21:26 ` [ruby-core:62711] [ruby-trunk - Bug #9627] " drbrain
@ 2014-06-22 16:54 ` nagachika00
2014-06-23 9:45 ` [ruby-core:63293] " usa
5 siblings, 0 replies; 6+ messages in thread
From: nagachika00 @ 2014-06-22 16:54 UTC (permalink / raw
To: ruby-core
Issue #9627 has been updated by Tomoyuki Chikanaga.
Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: DONE
Backported into `ruby_2_1` branch at r46496.
----------------------------------------
Bug #9627: SMTP does not properly dot-stuff an unterminated last line
https://bugs.ruby-lang.org/issues/9627#change-47323
* Author: Josh Goebel
* Status: Closed
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
* ruby -v: ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-linux]
* Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: DONE
----------------------------------------
```
str = "Date: Wed, 12 Mar 2014 16:02:26 -0400\r\nFrom: someone@aol.com\r\nTo: someone@aol.com\r\nMessage-ID: <5320bd52be4d3_6d653fd3d8c339e458df@Joshs-MacBook-Pro.local.mail>\r\nMime-Version: 1.0\r\nContent-Type: text/plain;\r\n charset=UTF-8\r\nContent-Transfer-Encoding: 7bit\r\n\r\nlook, a period with no endline\r\n."
smtp = Net::SMTP.new(...)
smtp.start(...) do |smtp_obj|
response = smtp_obj.sendmail(message, "someone@aol.com","someone@aol.com")
end
```
The SMTP server is going to throw a 400 or 500 error (depending on it's configuration) because the last period is send un-stuffed in the DATA block:
```
look, a period with no endline
.
.
```
When it should be:
```
look, a period with no end line
..
.
```
(ie, not dot-stuffed) and the second period the SMTP server doesn't know what to do with. Adding an additional new-line fixes the problem, but I the in-line documentation for SMTP send_message does not say anything about a new-line being requires for message sending to work.
Sorry, I can't test against the latest Ruby right now, but this is confirmed against 1.9.3 r448. If someone can confirm against newer that would be great.
I did do a search for "SMTP" and did not see this reported anywhere in the Issues database.
I had originally filed a pull request against Mail: https://github.com/mikel/mail/pull/683
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:63293] [ruby-trunk - Bug #9627] SMTP does not properly dot-stuff an unterminated last line
[not found] <redmine.issue-9627.20140312201024@ruby-lang.org>
` (4 preceding siblings ...)
2014-06-22 16:54 ` [ruby-core:63276] " nagachika00
@ 2014-06-23 9:45 ` usa
5 siblings, 0 replies; 6+ messages in thread
From: usa @ 2014-06-23 9:45 UTC (permalink / raw
To: ruby-core
Issue #9627 has been updated by Usaku NAKAMURA.
Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: DONE to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE
backported into `ruby_2_0_0` at r46515.
----------------------------------------
Bug #9627: SMTP does not properly dot-stuff an unterminated last line
https://bugs.ruby-lang.org/issues/9627#change-47342
* Author: Josh Goebel
* Status: Closed
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
* ruby -v: ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-linux]
* Backport: 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE
----------------------------------------
```
str = "Date: Wed, 12 Mar 2014 16:02:26 -0400\r\nFrom: someone@aol.com\r\nTo: someone@aol.com\r\nMessage-ID: <5320bd52be4d3_6d653fd3d8c339e458df@Joshs-MacBook-Pro.local.mail>\r\nMime-Version: 1.0\r\nContent-Type: text/plain;\r\n charset=UTF-8\r\nContent-Transfer-Encoding: 7bit\r\n\r\nlook, a period with no endline\r\n."
smtp = Net::SMTP.new(...)
smtp.start(...) do |smtp_obj|
response = smtp_obj.sendmail(message, "someone@aol.com","someone@aol.com")
end
```
The SMTP server is going to throw a 400 or 500 error (depending on it's configuration) because the last period is send un-stuffed in the DATA block:
```
look, a period with no endline
.
.
```
When it should be:
```
look, a period with no end line
..
.
```
(ie, not dot-stuffed) and the second period the SMTP server doesn't know what to do with. Adding an additional new-line fixes the problem, but I the in-line documentation for SMTP send_message does not say anything about a new-line being requires for message sending to work.
Sorry, I can't test against the latest Ruby right now, but this is confirmed against 1.9.3 r448. If someone can confirm against newer that would be great.
I did do a search for "SMTP" and did not see this reported anywhere in the Issues database.
I had originally filed a pull request against Mail: https://github.com/mikel/mail/pull/683
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-23 9:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <redmine.issue-9627.20140312201024@ruby-lang.org>
2014-03-12 20:10 ` [ruby-core:61441] [ruby-trunk - Bug #9627] [Open] SMTP does not properly dot-stuff an unterminated last line me
2014-03-13 21:08 ` [ruby-core:61479] [ruby-trunk - Bug #9627] " me
2014-05-23 12:36 ` [ruby-core:62709] [ruby-trunk - Bug #9627] [Closed] " nobu
2014-05-23 21:26 ` [ruby-core:62711] [ruby-trunk - Bug #9627] " drbrain
2014-06-22 16:54 ` [ruby-core:63276] " nagachika00
2014-06-23 9:45 ` [ruby-core:63293] " usa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).