* [ruby-core:57024] [ruby-trunk - Bug #8865][Assigned] OptionParser acceptable bugs
@ 2013-09-04 21:00 drbrain (Eric Hodel)
2013-09-05 0:20 ` [ruby-core:57029] [ruby-trunk - Bug #8865] " drbrain (Eric Hodel)
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: drbrain (Eric Hodel) @ 2013-09-04 21:00 UTC (permalink / raw
To: ruby-core
Issue #8865 has been reported by drbrain (Eric Hodel).
----------------------------------------
Bug #8865: OptionParser acceptable bugs
https://bugs.ruby-lang.org/issues/8865
Author: drbrain (Eric Hodel)
Status: Assigned
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: lib
Target version:
ruby -v: -
Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED
I have found a few bugs in OptionParser's accept feature:
Hexadecimal and binary numbers are not properly supported for Integer
OptionParser::DecimalInteger, OptionParser::OctalInteger and OptionParser::DecimalNumeric convert invalid input to 0 or nil instead of raising InvalidArgument.
The attached patch fixes the validation regular expression for handling binary and hexadecimal arguments and adds verification for DecimalInteger, OctalInteger and DecimalNumeric
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:57029] [ruby-trunk - Bug #8865] OptionParser acceptable bugs
2013-09-04 21:00 [ruby-core:57024] [ruby-trunk - Bug #8865][Assigned] OptionParser acceptable bugs drbrain (Eric Hodel)
@ 2013-09-05 0:20 ` drbrain (Eric Hodel)
2013-09-05 0:47 ` [ruby-core:57030] " drbrain (Eric Hodel)
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: drbrain (Eric Hodel) @ 2013-09-05 0:20 UTC (permalink / raw
To: ruby-core
Issue #8865 has been updated by drbrain (Eric Hodel).
File optparse.rb.accept.2.patch added
Updated with patch 2 that includes tests
----------------------------------------
Bug #8865: OptionParser acceptable bugs
https://bugs.ruby-lang.org/issues/8865#change-41624
Author: drbrain (Eric Hodel)
Status: Assigned
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: lib
Target version:
ruby -v: -
Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED
I have found a few bugs in OptionParser's accept feature:
Hexadecimal and binary numbers are not properly supported for Integer
OptionParser::DecimalInteger, OptionParser::OctalInteger and OptionParser::DecimalNumeric convert invalid input to 0 or nil instead of raising InvalidArgument.
The attached patch fixes the validation regular expression for handling binary and hexadecimal arguments and adds verification for DecimalInteger, OctalInteger and DecimalNumeric
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:57030] [ruby-trunk - Bug #8865] OptionParser acceptable bugs
2013-09-04 21:00 [ruby-core:57024] [ruby-trunk - Bug #8865][Assigned] OptionParser acceptable bugs drbrain (Eric Hodel)
2013-09-05 0:20 ` [ruby-core:57029] [ruby-trunk - Bug #8865] " drbrain (Eric Hodel)
@ 2013-09-05 0:47 ` drbrain (Eric Hodel)
2013-09-05 4:29 ` [ruby-core:57034] " drbrain (Eric Hodel)
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: drbrain (Eric Hodel) @ 2013-09-05 0:47 UTC (permalink / raw
To: ruby-core
Issue #8865 has been updated by drbrain (Eric Hodel).
File optparse.rb.accept.3.patch added
Here is patch 3 that uses end-of-string anchoring to ensure the entire number is bad.
----------------------------------------
Bug #8865: OptionParser acceptable bugs
https://bugs.ruby-lang.org/issues/8865#change-41625
Author: drbrain (Eric Hodel)
Status: Assigned
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: lib
Target version:
ruby -v: -
Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED
I have found a few bugs in OptionParser's accept feature:
Hexadecimal and binary numbers are not properly supported for Integer
OptionParser::DecimalInteger, OptionParser::OctalInteger and OptionParser::DecimalNumeric convert invalid input to 0 or nil instead of raising InvalidArgument.
The attached patch fixes the validation regular expression for handling binary and hexadecimal arguments and adds verification for DecimalInteger, OctalInteger and DecimalNumeric
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:57034] [ruby-trunk - Bug #8865] OptionParser acceptable bugs
2013-09-04 21:00 [ruby-core:57024] [ruby-trunk - Bug #8865][Assigned] OptionParser acceptable bugs drbrain (Eric Hodel)
2013-09-05 0:20 ` [ruby-core:57029] [ruby-trunk - Bug #8865] " drbrain (Eric Hodel)
2013-09-05 0:47 ` [ruby-core:57030] " drbrain (Eric Hodel)
@ 2013-09-05 4:29 ` drbrain (Eric Hodel)
2014-02-14 4:52 ` [ruby-core:60702] " usa
2014-02-19 16:38 ` [ruby-core:60871] " nagachika00
4 siblings, 0 replies; 6+ messages in thread
From: drbrain (Eric Hodel) @ 2013-09-05 4:29 UTC (permalink / raw
To: ruby-core
Issue #8865 has been updated by drbrain (Eric Hodel).
Assignee changed from nobu (Nobuyoshi Nakada) to drbrain (Eric Hodel)
From #ruby-core IRC:
19:46 nokada: drbrain: seems fine, and add tests 1234xyz fails, plz
----------------------------------------
Bug #8865: OptionParser acceptable bugs
https://bugs.ruby-lang.org/issues/8865#change-41631
Author: drbrain (Eric Hodel)
Status: Assigned
Priority: Normal
Assignee: drbrain (Eric Hodel)
Category: lib
Target version:
ruby -v: -
Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED
I have found a few bugs in OptionParser's accept feature:
Hexadecimal and binary numbers are not properly supported for Integer
OptionParser::DecimalInteger, OptionParser::OctalInteger and OptionParser::DecimalNumeric convert invalid input to 0 or nil instead of raising InvalidArgument.
The attached patch fixes the validation regular expression for handling binary and hexadecimal arguments and adds verification for DecimalInteger, OctalInteger and DecimalNumeric
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:60702] [ruby-trunk - Bug #8865] OptionParser acceptable bugs
2013-09-04 21:00 [ruby-core:57024] [ruby-trunk - Bug #8865][Assigned] OptionParser acceptable bugs drbrain (Eric Hodel)
` (2 preceding siblings ...)
2013-09-05 4:29 ` [ruby-core:57034] " drbrain (Eric Hodel)
@ 2014-02-14 4:52 ` usa
2014-02-19 16:38 ` [ruby-core:60871] " nagachika00
4 siblings, 0 replies; 6+ messages in thread
From: usa @ 2014-02-14 4:52 UTC (permalink / raw
To: ruby-core
Issue #8865 has been updated by Usaku NAKAMURA.
Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED to 1.9.3: DONE, 2.0.0: REQUIRED
backported into ruby_1_9_3 at r44935.
----------------------------------------
Bug #8865: OptionParser acceptable bugs
https://bugs.ruby-lang.org/issues/8865#change-45123
* Author: Eric Hodel
* Status: Closed
* Priority: Normal
* Assignee: Eric Hodel
* Category: lib
* Target version:
* ruby -v: -
* Backport: 1.9.3: DONE, 2.0.0: REQUIRED
----------------------------------------
I have found a few bugs in OptionParser's accept feature:
Hexadecimal and binary numbers are not properly supported for Integer
OptionParser::DecimalInteger, OptionParser::OctalInteger and OptionParser::DecimalNumeric convert invalid input to 0 or nil instead of raising InvalidArgument.
The attached patch fixes the validation regular expression for handling binary and hexadecimal arguments and adds verification for DecimalInteger, OctalInteger and DecimalNumeric
---Files--------------------------------
optparse.rb.accept.patch (1.63 KB)
optparse.rb.accept.2.patch (6.85 KB)
optparse.rb.accept.3.patch (7.77 KB)
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:60871] [ruby-trunk - Bug #8865] OptionParser acceptable bugs
2013-09-04 21:00 [ruby-core:57024] [ruby-trunk - Bug #8865][Assigned] OptionParser acceptable bugs drbrain (Eric Hodel)
` (3 preceding siblings ...)
2014-02-14 4:52 ` [ruby-core:60702] " usa
@ 2014-02-19 16:38 ` nagachika00
4 siblings, 0 replies; 6+ messages in thread
From: nagachika00 @ 2014-02-19 16:38 UTC (permalink / raw
To: ruby-core
Issue #8865 has been updated by Tomoyuki Chikanaga.
Backport changed from 1.9.3: DONE, 2.0.0: REQUIRED to 1.9.3: DONE, 2.0.0: DONE
r42844 and r42845 were backported to ruby_2_0_0 at r45050.
----------------------------------------
Bug #8865: OptionParser acceptable bugs
https://bugs.ruby-lang.org/issues/8865#change-45282
* Author: Eric Hodel
* Status: Closed
* Priority: Normal
* Assignee: Eric Hodel
* Category: lib
* Target version:
* ruby -v: -
* Backport: 1.9.3: DONE, 2.0.0: DONE
----------------------------------------
I have found a few bugs in OptionParser's accept feature:
Hexadecimal and binary numbers are not properly supported for Integer
OptionParser::DecimalInteger, OptionParser::OctalInteger and OptionParser::DecimalNumeric convert invalid input to 0 or nil instead of raising InvalidArgument.
The attached patch fixes the validation regular expression for handling binary and hexadecimal arguments and adds verification for DecimalInteger, OctalInteger and DecimalNumeric
---Files--------------------------------
optparse.rb.accept.patch (1.63 KB)
optparse.rb.accept.2.patch (6.85 KB)
optparse.rb.accept.3.patch (7.77 KB)
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-19 16:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 21:00 [ruby-core:57024] [ruby-trunk - Bug #8865][Assigned] OptionParser acceptable bugs drbrain (Eric Hodel)
2013-09-05 0:20 ` [ruby-core:57029] [ruby-trunk - Bug #8865] " drbrain (Eric Hodel)
2013-09-05 0:47 ` [ruby-core:57030] " drbrain (Eric Hodel)
2013-09-05 4:29 ` [ruby-core:57034] " drbrain (Eric Hodel)
2014-02-14 4:52 ` [ruby-core:60702] " usa
2014-02-19 16:38 ` [ruby-core:60871] " nagachika00
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).