From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B02471F44D for ; Wed, 24 Apr 2024 11:12:19 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=OEX8Z65z; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=fcRiqCWk; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 75C6981343; Wed, 24 Apr 2024 11:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1713957128; bh=vOinJVhjTCN6Qcw4n8zOAYWUkXfmMaqFtCnGlqZ2RA4=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=OEX8Z65zT6n5LgMTdbOeNpcJIxwyjrEEJI/bEJDRSMkEMT+m6300IXnbR2VQp+rYt biBDp197YB8tjWZzhMbbadJKuXWNX/bAwtfmrnMUgS5zQU0kRKa9elgsGfL25aCxLW jcUsPLQRhRImsFKFGBYwnxiMykdNMLQwnS7s7FEs= Received: from s.wfbtzhsv.outbound-mail.sendgrid.net (s.wfbtzhsv.outbound-mail.sendgrid.net [159.183.224.104]) by nue.mailmanlists.eu (Postfix) with ESMTPS id B9C847EE05 for ; Wed, 24 Apr 2024 11:12:04 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=fcRiqCWk; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=zjRiCNEPCuhtTna+DJ4oTo6eO6Zhpixdumz6cjMm6qo=; b=fcRiqCWkI78JjR1Iix1LU3jVlmlYTQUL5cg6duwWkvuq+BX8yBfjcd3hvzVLwOYQ1Yx0 rbhQ2GG6sbuq3tNWWOwRKP6TPLy6Fg2l5bGGMubzRrkUC0pMvHmY5Q++k23gHMh4uWsI6f 0O5xypk1+36J8fezvJGNaLImhgxoSisVhWD8AjeIF8Mnx2fFju5IC7VeniiOYP7yxS+gyZ 3ltPlrgLonTzlSz2dSAITxqILyIkyXJEmbPGVGAy8D7A2JyZQrw5H43o5W7NuOQXYKwBZA QnYWetoN/s2PjYBr+0XpJpoejzs6/xslf6cJ+DYL32RHaNqQgnkzbVHDrMtlpCwQ== Received: by filterdrecv-854b845bd5-xlv9j with SMTP id filterdrecv-854b845bd5-xlv9j-1-6628E902-A 2024-04-24 11:12:02.259410646 +0000 UTC m=+998544.201206027 Received: from herokuapp.com (unknown) by geopod-ismtpd-10 (SG) with ESMTP id w-YMJrLHRf2kFocoJYN4CA for ; Wed, 24 Apr 2024 11:12:03.800 +0000 (UTC) Date: Wed, 24 Apr 2024 11:12:03 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20451 X-Redmine-Issue-Author: Bo98 X-Redmine-Issue-Priority: Normal X-Redmine-Sender: Bo98 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 94276 X-SG-EID: =?us-ascii?Q?u001=2EGO=2FPARXNBlwrs50BQIyVOFPC0siVckKTsvha+qy1SaYnteXRhHBWDGmOf?= =?us-ascii?Q?oKTOeF2uXqwI6x50d1qFs0tvRifpp461jGZkZ7o?= =?us-ascii?Q?0aNOR6blXLCJpqZXGkki1B+lg0nTYyPwRx4rxr8?= =?us-ascii?Q?fYM5WxY9893gYeDX0V9QY4s7Tk=2FinOgjN3xxpEC?= =?us-ascii?Q?6hELvnlsc5cSjGkFFZj+Gax58y=2FIG1FS=2FuTx91S?= =?us-ascii?Q?YAJplxGtFUuIVSpQJabWqp+AtrlKfXRCWEShoyO?= =?us-ascii?Q?Po9sn9UJ0erQ7TRHc11s=2FTQppw=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: IV4X3PHYDIUF4MSE7M6B3F7HHPVEGFXB X-Message-ID-Hash: IV4X3PHYDIUF4MSE7M6B3F7HHPVEGFXB X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117680] [Ruby master Bug#20451] Bad Ruby 3.1.5 backport causes fiddle to fail to build List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Bo98 (Bo Anderson) via ruby-core" Cc: "Bo98 (Bo Anderson)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20451 has been reported by Bo98 (Bo Anderson). ---------------------------------------- Bug #20451: Bad Ruby 3.1.5 backport causes fiddle to fail to build https://bugs.ruby-lang.org/issues/20451 * Author: Bo98 (Bo Anderson) * Status: Open * ruby -v: 3.1.5p252 * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- Ruby 3.1.5 shipped with the following backport: https://github.com/ruby/ruby/commit/84f2aabd272a54e79979795d2d405090704a1d07 However this backport directly breaks the build: ``` closure.c:279:60: error: use of undeclared identifier 'data' result = ffi_prep_closure(pcl, cif, callback, (void *)(data->self)); ^ ``` The original commit (https://github.com/ruby/fiddle/commit/2530496602) was updating the second branch to match the change in the first branch a couple lines up. However that change in the other branch does not exist in Ruby 3.1. The commit in question requires a previous commit of https://github.com/ruby/fiddle/commit/81a8a56239973ab7559229830a449d201955b494. The backport should either be reverted or an other commit should also be backported. Note that these commits were in a series of many commits made to fix an upstream issue https://github.com/ruby/fiddle/issues/102 so I cannot vouch whether or not the two commits are sufficient to fix the originally reported issue. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/