From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F02791F44D for ; Thu, 14 Mar 2024 19:39:51 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=XxyGtlm0; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=igfltzQL; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 01EEA83301; Thu, 14 Mar 2024 19:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1710445185; bh=aDYttGMsf9SIZ3GgY8Aj4k3cGPscxmws/f2trLtv2wE=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=XxyGtlm04yI7ca3rYQuIpCzBAJafGScwk8nW3YexuPvPX+XqFMzQs6IeiI8cP4xI9 tgHVqy05GRssVD7pRvEleTz1GgLGUVtBZ7ivBMM2DzKf1gdNLPN35Bz2R+nUL/xg4q qn86ISlSHGB2gYJJdkMw4ZXNoyhUAAzkt5UkRebU= Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 131CE832CE for ; Thu, 14 Mar 2024 19:39:41 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=igfltzQL; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=C3f0QZKu6SRLx2T82sBehyWMV2reKwG8vQDTUc8VMVU=; b=igfltzQL4FYgsFFrgKdldIQa3G7Rm2WrwU4TE2iZcOvLhoylTkCzJGVL/9+MOEIu66hg BowEzB7e5JkbmxHGGArcOM9VrNy4I29pYjpjDg83yNuu1NLbev+ZnSKktroCXnMS9X18A6 Zx0SHSEdk7raXak1GGRiWv65EvKRzHpCxz8By0ScQ1Oo1q9+c2JZofKwSK5SjXYQQamLxd f+zAZGA9ZDb000mKT0pZCesAT0WltC/Gys6wT94agRtTfAIA+jaXjlXdiFhiFnrZBmCT1u XFBSR4Z97foTmcXyKGQJhJOpL2WADITtBmPDQiklYbGWw0gfw4r0hlJ79wu5IKrw== Received: by filterdrecv-6b965fd7fb-x767w with SMTP id filterdrecv-6b965fd7fb-x767w-1-65F3527C-15 2024-03-14 19:39:40.873876388 +0000 UTC m=+852309.268704862 Received: from herokuapp.com (unknown) by geopod-ismtpd-16 (SG) with ESMTP id D3F39XFyRGi0_9p73LxbDg for ; Thu, 14 Mar 2024 19:39:40.820 +0000 (UTC) Date: Thu, 14 Mar 2024 19:39:40 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20340 X-Redmine-Issue-Author: kddnewton X-Redmine-Issue-Priority: Normal X-Redmine-Sender: kddnewton X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 93754 X-SG-EID: =?us-ascii?Q?u001=2E41nWPij=2FD1kdGmpgWeHScbb9X8tZePZrQQx3bl8Vy2odBuMhLMhId2kIq?= =?us-ascii?Q?I4MmMJ43lNHfKPNNds=2Fb3JsTYpYoWyQb3+sPV4d?= =?us-ascii?Q?vscaSKwkBzV2EuYisWOIOU6CRnd46RttLMQUv6U?= =?us-ascii?Q?AXE4w961aoxTI3lcuq8PtR4RSWmQq8xlpg3w+Xc?= =?us-ascii?Q?qcj86qc3dQPgL+xih0LGeOtKNJv=2F0v6mdw+KfFb?= =?us-ascii?Q?DaV8x8Ay5=2F5QtAA1glo2YlMReS+I3LDCcPGKowb?= =?us-ascii?Q?YE5dX1XLrN58o9mbvWzZ+3O95g=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: PYP5T3JYDGOMKMNBGKBDAPB6RMPVL6A6 X-Message-ID-Hash: PYP5T3JYDGOMKMNBGKBDAPB6RMPVL6A6 X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117188] [Ruby master Bug#20340] Ractor comments not applying to constant targets List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "kddnewton (Kevin Newton) via ruby-core" Cc: "kddnewton (Kevin Newton)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20340 has been reported by kddnewton (Kevin Newton). ---------------------------------------- Bug #20340: Ractor comments not applying to constant targets https://bugs.ruby-lang.org/issues/20340 * Author: kddnewton (Kevin Newton) * Status: Open * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- In this example: ```ruby C, = { foo: bar } ``` You get: ``` == disasm: #@test.rb:1 (1,0)-(1,17)> 0000 putobject :foo ( 1)[Li] 0002 putself 0003 opt_send_without_block 0005 newhash 2 0007 dup 0008 expandarray 1, 0 0011 putspecialobject 3 0013 setconstant :C 0015 leave ``` But there's no difference from: ```ruby # shareable_constant_value: literal C, = { foo: bar } ``` I would have expected: ``` == disasm: #@test.rb:1 (1,0)-(2,16)> 0000 putobject RubyVM::FrozenCore ( 2)[Li] 0002 putobject :foo 0004 putobject RubyVM::FrozenCore 0006 putself 0007 opt_send_without_block 0009 putobject "C" 0011 opt_send_without_block 0013 newhash 2 0015 opt_send_without_block 0017 dup 0018 expandarray 1, 0 0021 putspecialobject 3 0023 setconstant :C 0025 leave ``` Is this omission intentional? For context, I'm building this in prism and I need to know if I should explicitly disable this behavior. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/