* [ruby-core:110028] [Ruby master Feature#19018] uri/generic: Support comma-delimited entries in no_proxy
@ 2022-09-23 4:46 stanhu (Stan Hu)
2022-09-23 5:08 ` [ruby-core:110029] " stanhu (Stan Hu)
2022-09-23 5:25 ` [ruby-core:110030] [Ruby master Feature#19018] uri/generic: Support CIDR blocks in " stanhu (Stan Hu)
0 siblings, 2 replies; 3+ messages in thread
From: stanhu (Stan Hu) @ 2022-09-23 4:46 UTC (permalink / raw)
To: ruby-core
Issue #19018 has been reported by stanhu (Stan Hu).
----------------------------------------
Feature #19018: uri/generic: Support comma-delimited entries in no_proxy
https://bugs.ruby-lang.org/issues/19018
* Author: stanhu (Stan Hu)
* Status: Open
* Priority: Normal
----------------------------------------
Currently `URI::Generic.use_proxy?` does not treat the `no_proxy` strings as a comma-delimited value: https://github.com/ruby/ruby/blob/0ed71b37fa9af134fdd5a7fd1cebd171eba83541/lib/uri/generic.rb#L1545-L1564
That means that it's not possible to specify multiple rules, such as:
```
no_proxy=.example.com,192.168.0.0/8
```
While there's no official standard for `no_proxy`(https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/), [Python](https://github.com/python/cpython/blob/030a713183084594659aefd77b76fe30178e23c8/Lib/urllib/request.py#L2540) and [Golang](https://github.com/golang/go/blob/682a1d2176b02337460aeede0ff9e49429525195/src/vendor/golang.org/x/net/http/httpproxy/proxy.go#L216) split the comma.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:110029] [Ruby master Feature#19018] uri/generic: Support comma-delimited entries in no_proxy
2022-09-23 4:46 [ruby-core:110028] [Ruby master Feature#19018] uri/generic: Support comma-delimited entries in no_proxy stanhu (Stan Hu)
@ 2022-09-23 5:08 ` stanhu (Stan Hu)
2022-09-23 5:25 ` [ruby-core:110030] [Ruby master Feature#19018] uri/generic: Support CIDR blocks in " stanhu (Stan Hu)
1 sibling, 0 replies; 3+ messages in thread
From: stanhu (Stan Hu) @ 2022-09-23 5:08 UTC (permalink / raw)
To: ruby-core
Issue #19018 has been updated by stanhu (Stan Hu).
I submitted https://github.com/ruby/ruby/pull/6424. That method could use some cleanup.
----------------------------------------
Feature #19018: uri/generic: Support comma-delimited entries in no_proxy
https://bugs.ruby-lang.org/issues/19018#change-99279
* Author: stanhu (Stan Hu)
* Status: Open
* Priority: Normal
----------------------------------------
Currently `URI::Generic.use_proxy?` does not treat the `no_proxy` strings as a comma-delimited value: https://github.com/ruby/ruby/blob/0ed71b37fa9af134fdd5a7fd1cebd171eba83541/lib/uri/generic.rb#L1545-L1564
That means that it's not possible to specify multiple rules, such as:
```
no_proxy=.example.com,192.168.0.0/8
```
While there's no official standard for `no_proxy`(https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/), [Python](https://github.com/python/cpython/blob/030a713183084594659aefd77b76fe30178e23c8/Lib/urllib/request.py#L2540) and [Golang](https://github.com/golang/go/blob/682a1d2176b02337460aeede0ff9e49429525195/src/vendor/golang.org/x/net/http/httpproxy/proxy.go#L216) split the comma.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:110030] [Ruby master Feature#19018] uri/generic: Support CIDR blocks in comma-delimited entries in no_proxy
2022-09-23 4:46 [ruby-core:110028] [Ruby master Feature#19018] uri/generic: Support comma-delimited entries in no_proxy stanhu (Stan Hu)
2022-09-23 5:08 ` [ruby-core:110029] " stanhu (Stan Hu)
@ 2022-09-23 5:25 ` stanhu (Stan Hu)
1 sibling, 0 replies; 3+ messages in thread
From: stanhu (Stan Hu) @ 2022-09-23 5:25 UTC (permalink / raw)
To: ruby-core
Issue #19018 has been updated by stanhu (Stan Hu).
Ok, I'm wrong. This seems to work. We can close this issue.
----------------------------------------
Feature #19018: uri/generic: Support CIDR blocks in comma-delimited entries in no_proxy
https://bugs.ruby-lang.org/issues/19018#change-99281
* Author: stanhu (Stan Hu)
* Status: Open
* Priority: Normal
----------------------------------------
Currently `URI::Generic.use_proxy?` does not treat the `no_proxy` strings as a comma-delimited value: https://github.com/ruby/ruby/blob/0ed71b37fa9af134fdd5a7fd1cebd171eba83541/lib/uri/generic.rb#L1545-L1564
That means that it's not possible to specify multiple rules, such as:
```
no_proxy=.example.com,192.168.0.0/8
```
While there's no official standard for `no_proxy`(https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/), [Python](https://github.com/python/cpython/blob/030a713183084594659aefd77b76fe30178e23c8/Lib/urllib/request.py#L2540) and [Golang](https://github.com/golang/go/blob/682a1d2176b02337460aeede0ff9e49429525195/src/vendor/golang.org/x/net/http/httpproxy/proxy.go#L216) split the comma.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-23 5:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 4:46 [ruby-core:110028] [Ruby master Feature#19018] uri/generic: Support comma-delimited entries in no_proxy stanhu (Stan Hu)
2022-09-23 5:08 ` [ruby-core:110029] " stanhu (Stan Hu)
2022-09-23 5:25 ` [ruby-core:110030] [Ruby master Feature#19018] uri/generic: Support CIDR blocks in " stanhu (Stan Hu)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).