ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:105419] [Ruby master Misc#18192] Advertise that OpenSSL 3.0 is not supported
@ 2021-09-25 18:24 xtkoba (Tee KOBAYASHI)
  2021-09-26 10:23 ` [ruby-core:105421] " rhenium (Kazuki Yamaguchi)
  2021-10-16  8:41 ` [ruby-core:105655] " rhenium (Kazuki Yamaguchi)
  0 siblings, 2 replies; 3+ messages in thread
From: xtkoba (Tee KOBAYASHI) @ 2021-09-25 18:24 UTC (permalink / raw)
  To: ruby-core

Issue #18192 has been reported by xtkoba (Tee KOBAYASHI).

----------------------------------------
Misc #18192: Advertise that OpenSSL 3.0 is not supported
https://bugs.ruby-lang.org/issues/18192

* Author: xtkoba (Tee KOBAYASHI)
* Status: Open
* Priority: Normal
----------------------------------------
Can we document that OpenSSL 3.0 is not supported?

I believe at least we can make `extconf.rb` fail with OpenSSL 3.0:

```diff
--- a/ext/openssl/extconf.rb
+++ b/ext/openssl/extconf.rb
@@ -108,10 +108,12 @@
     try_static_assert("LIBRESSL_VERSION_NUMBER >= 0x30100000L", "openssl/opensslv.h") }
 else
   checking_for("OpenSSL version >= 1.0.2") {
-    try_static_assert("OPENSSL_VERSION_NUMBER >= 0x10002000L", "openssl/opensslv.h") }
+    try_static_assert("OPENSSL_VERSION_NUMBER >= 0x10002000L", "openssl/opensslv.h") } &&
+  checking_for("OpenSSL version < 3.0.0") {
+    try_static_assert("OPENSSL_VERSION_NUMBER < 0x30000000L", "openssl/opensslv.h") }
 end
 unless version_ok
-  raise "OpenSSL >= 1.0.2 or LibreSSL >= 3.1.0 is required"
+  raise "OpenSSL >= 1.0.2, < 3.0.0 or LibreSSL >= 3.1.0 is required"
 end
 
 # Prevent wincrypt.h from being included, which defines conflicting macro with openssl/x509.h
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:105421] [Ruby master Misc#18192] Advertise that OpenSSL 3.0 is not supported
  2021-09-25 18:24 [ruby-core:105419] [Ruby master Misc#18192] Advertise that OpenSSL 3.0 is not supported xtkoba (Tee KOBAYASHI)
@ 2021-09-26 10:23 ` rhenium (Kazuki Yamaguchi)
  2021-10-16  8:41 ` [ruby-core:105655] " rhenium (Kazuki Yamaguchi)
  1 sibling, 0 replies; 3+ messages in thread
From: rhenium (Kazuki Yamaguchi) @ 2021-09-26 10:23 UTC (permalink / raw)
  To: ruby-core

Issue #18192 has been updated by rhenium (Kazuki Yamaguchi).

Assignee set to rhenium (Kazuki Yamaguchi)

Adding OpenSSL 3.0 support is planned for the next Ruby/OpenSSL gem release, for inclusion in Ruby 3.1.

Given the amount of work required, doing so would be a sensible choice for Ruby 2.7 and 3.0 branches.

I will prepare new gem releases 2.1.x (for Ruby 2.7) and 2.2.x (for Ruby 3.0) and attach a patch here for ruby.git to import them.

----------------------------------------
Misc #18192: Advertise that OpenSSL 3.0 is not supported
https://bugs.ruby-lang.org/issues/18192#change-93839

* Author: xtkoba (Tee KOBAYASHI)
* Status: Open
* Priority: Normal
* Assignee: rhenium (Kazuki Yamaguchi)
----------------------------------------
Can we document that OpenSSL 3.0 is not supported?

I believe at least we can make `extconf.rb` fail with OpenSSL 3.0:

```diff
--- a/ext/openssl/extconf.rb
+++ b/ext/openssl/extconf.rb
@@ -108,10 +108,12 @@
     try_static_assert("LIBRESSL_VERSION_NUMBER >= 0x30100000L", "openssl/opensslv.h") }
 else
   checking_for("OpenSSL version >= 1.0.2") {
-    try_static_assert("OPENSSL_VERSION_NUMBER >= 0x10002000L", "openssl/opensslv.h") }
+    try_static_assert("OPENSSL_VERSION_NUMBER >= 0x10002000L", "openssl/opensslv.h") } &&
+  checking_for("OpenSSL version < 3.0.0") {
+    try_static_assert("OPENSSL_VERSION_NUMBER < 0x30000000L", "openssl/opensslv.h") }
 end
 unless version_ok
-  raise "OpenSSL >= 1.0.2 or LibreSSL >= 3.1.0 is required"
+  raise "OpenSSL >= 1.0.2, < 3.0.0 or LibreSSL >= 3.1.0 is required"
 end
 
 # Prevent wincrypt.h from being included, which defines conflicting macro with openssl/x509.h
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:105655] [Ruby master Misc#18192] Advertise that OpenSSL 3.0 is not supported
  2021-09-25 18:24 [ruby-core:105419] [Ruby master Misc#18192] Advertise that OpenSSL 3.0 is not supported xtkoba (Tee KOBAYASHI)
  2021-09-26 10:23 ` [ruby-core:105421] " rhenium (Kazuki Yamaguchi)
@ 2021-10-16  8:41 ` rhenium (Kazuki Yamaguchi)
  1 sibling, 0 replies; 3+ messages in thread
From: rhenium (Kazuki Yamaguchi) @ 2021-10-16  8:41 UTC (permalink / raw)
  To: ruby-core

Issue #18192 has been updated by rhenium (Kazuki Yamaguchi).

Status changed from Open to Third Party's Issue

openssl gem version 2.1.3 and 2.2.1 have been released with this change in addition to other bug fixes/improvements.

Backport to ruby core is requested in [Bug #18251] and [Bug #18252].

----------------------------------------
Misc #18192: Advertise that OpenSSL 3.0 is not supported
https://bugs.ruby-lang.org/issues/18192#change-94155

* Author: xtkoba (Tee KOBAYASHI)
* Status: Third Party's Issue
* Priority: Normal
* Assignee: rhenium (Kazuki Yamaguchi)
----------------------------------------
Can we document that OpenSSL 3.0 is not supported?

I believe at least we can make `extconf.rb` fail with OpenSSL 3.0:

```diff
--- a/ext/openssl/extconf.rb
+++ b/ext/openssl/extconf.rb
@@ -108,10 +108,12 @@
     try_static_assert("LIBRESSL_VERSION_NUMBER >= 0x30100000L", "openssl/opensslv.h") }
 else
   checking_for("OpenSSL version >= 1.0.2") {
-    try_static_assert("OPENSSL_VERSION_NUMBER >= 0x10002000L", "openssl/opensslv.h") }
+    try_static_assert("OPENSSL_VERSION_NUMBER >= 0x10002000L", "openssl/opensslv.h") } &&
+  checking_for("OpenSSL version < 3.0.0") {
+    try_static_assert("OPENSSL_VERSION_NUMBER < 0x30000000L", "openssl/opensslv.h") }
 end
 unless version_ok
-  raise "OpenSSL >= 1.0.2 or LibreSSL >= 3.1.0 is required"
+  raise "OpenSSL >= 1.0.2, < 3.0.0 or LibreSSL >= 3.1.0 is required"
 end
 
 # Prevent wincrypt.h from being included, which defines conflicting macro with openssl/x509.h
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-16  8:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-25 18:24 [ruby-core:105419] [Ruby master Misc#18192] Advertise that OpenSSL 3.0 is not supported xtkoba (Tee KOBAYASHI)
2021-09-26 10:23 ` [ruby-core:105421] " rhenium (Kazuki Yamaguchi)
2021-10-16  8:41 ` [ruby-core:105655] " rhenium (Kazuki Yamaguchi)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).