[ruby-core:103080] [Ruby master Bug#17759] Correct `ioctl_req_t` for musl

[ruby-core:103080] [Ruby master Bug#17759] Correct `ioctl_req_t` for musl

[xtkoba+ruby]

Issue #17759 has been reported by xtkoba (Tee KOBAYASHI).

----------------------------------------
Bug #17759: Correct `ioctl_req_t` for musl
https://bugs.ruby-lang.org/issues/17759

* Author: xtkoba (Tee KOBAYASHI)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
The definition of `ioctl(2)` in musl is `int ioctl (int, int, ...);`, and this makes `io.c` fail to build on 64-bit musl environments with Clang/LLVM due to `shorten-64-to-32` error.

A patch is attached for a workaround. It is expected to work with glibc, musl, bionic (Android), and uClibc (which defines `__GLIBC__`). I have no idea of other C libraries working on Linux.

Aside from this patch, it might be better if we could supply `./configure` with the definition of `ioctl_req_t` using e.g. `rb_cv_ioctl_req_t_convertible=...`.

---Files--------------------------------
ruby-ioctl_req_t.patch (473 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:103081] [Ruby master Bug#17759] Correct `ioctl_req_t` for musl

[nobu]

Issue #17759 has been updated by nobu (Nobuyoshi Nakada).


Seems more concise.
Would you commit it by yourself?

----------------------------------------
Bug #17759: Correct `ioctl_req_t` for musl
https://bugs.ruby-lang.org/issues/17759#change-91142

* Author: xtkoba (Tee KOBAYASHI)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
The definition of `ioctl(2)` in musl is `int ioctl (int, int, ...);`, and this makes `io.c` fail to build on 64-bit musl environments with Clang/LLVM due to `shorten-64-to-32` error.

A patch is attached for a workaround. It is expected to work with glibc, musl, bionic (Android), and uClibc (which defines `__GLIBC__`). I have no idea of other C libraries working on Linux.

Aside from this patch, it might be better if we could supply `./configure` with the definition of `ioctl_req_t` using e.g. `rb_cv_ioctl_req_t_convertible=...`.

---Files--------------------------------
ruby-ioctl_req_t.patch (473 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:103082] [Ruby master Bug#17759] Correct `ioctl_req_t` for musl

[mame]

Issue #17759 has been updated by mame (Yusuke Endoh).


> Would you commit it by yourself?

+1

----------------------------------------
Bug #17759: Correct `ioctl_req_t` for musl
https://bugs.ruby-lang.org/issues/17759#change-91143

* Author: xtkoba (Tee KOBAYASHI)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
The definition of `ioctl(2)` in musl is `int ioctl (int, int, ...);`, and this makes `io.c` fail to build on 64-bit musl environments with Clang/LLVM due to `shorten-64-to-32` error.

A patch is attached for a workaround. It is expected to work with glibc, musl, bionic (Android), and uClibc (which defines `__GLIBC__`). I have no idea of other C libraries working on Linux.

Aside from this patch, it might be better if we could supply `./configure` with the definition of `ioctl_req_t` using e.g. `rb_cv_ioctl_req_t_convertible=...`.

---Files--------------------------------
ruby-ioctl_req_t.patch (473 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:103462] [Ruby master Bug#17759] Correct `ioctl_req_t` for musl

[mame]

Issue #17759 has been updated by mame (Yusuke Endoh).


Hi @xtkoba

Are you ineterested in becoming a Ruby commiter?
At least, @nobu and I want you to have a commit bit.
If you don't mind, we will recommend that we add you as a committer.

----------------------------------------
Bug #17759: Correct `ioctl_req_t` for musl
https://bugs.ruby-lang.org/issues/17759#change-91557

* Author: xtkoba (Tee KOBAYASHI)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
The definition of `ioctl(2)` in musl is `int ioctl (int, int, ...);`, and this makes `io.c` fail to build on 64-bit musl environments with Clang/LLVM due to `shorten-64-to-32` error.

A patch is attached for a workaround. It is expected to work with glibc, musl, bionic (Android), and uClibc (which defines `__GLIBC__`). I have no idea of other C libraries working on Linux.

Aside from this patch, it might be better if we could supply `./configure` with the definition of `ioctl_req_t` using e.g. `rb_cv_ioctl_req_t_convertible=...`.

---Files--------------------------------
ruby-ioctl_req_t.patch (473 Bytes)


-- 
https://bugs.ruby-lang.org/