From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id AFEF21F4B4 for ; Tue, 22 Dec 2020 01:57:10 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A7751120A8D; Tue, 22 Dec 2020 10:56:16 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 93A3A120A65 for ; Tue, 22 Dec 2020 10:56:13 +0900 (JST) Received: by filterdrecv-p3las1-685fdc5bbc-r59bq with SMTP id filterdrecv-p3las1-685fdc5bbc-r59bq-20-5FE15266-2 2020-12-22 01:56:54.128066798 +0000 UTC m=+960881.482575056 Received: from herokuapp.com (unknown) by geopod-ismtpd-3-0 (SG) with ESMTP id Tk7sRCy4Sc-KsRmEfhZZug for ; Tue, 22 Dec 2020 01:56:53.950 +0000 (UTC) Date: Tue, 22 Dec 2020 01:56:54 +0000 (UTC) From: matz@ruby.or.jp Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 77489 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17423 X-Redmine-Issue-Author: matz X-Redmine-Issue-Assignee: jeremyevans0 X-Redmine-Sender: matz X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?bXEIHGfdFwsIlBTndiToCp=2Fmc2rfxRD2sZAksRKJIHV7cRcDSalPhxbknG5msv?= =?us-ascii?Q?I8r6EfLvu61D87KhR=2FH7KHNx0YMRtAFVGf6V=2FYf?= =?us-ascii?Q?F0Fpwnlkna=2F8X3aAUknklO8dhmvnLFXL00oHv+p?= =?us-ascii?Q?e7SHXTHoKaUA3SfhBoVA2=2FZ4hBWGDNRCOJWDXFx?= =?us-ascii?Q?5wCwFVTIoIZXkvLsvkedez=2FTQD8e=2FIpNadg=3D=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 101618 Subject: [ruby-core:101618] [Ruby master Bug#17423] `Prepend` should prepend a module before the class X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17423 has been reported by matz (Yukihiro Matsumoto). ---------------------------------------- Bug #17423: `Prepend` should prepend a module before the class https://bugs.ruby-lang.org/issues/17423 * Author: matz (Yukihiro Matsumoto) * Status: Open * Priority: Normal * Assignee: jeremyevans0 (Jeremy Evans) * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- I see ```ruby module M; end module A; end class B; include A; end A.prepend M B.prepend M p B.ancestors ``` gives `[B, M, A, Object, Kernel, BasicObject]` now. It used to be `[M, B, A, Object, Kernel, BasicObject]`. I think it should be prepended to class `B`. Probably it should be `[M, B, M, A, Object, Kernel, BasicObject]`. The reason behind this change may be duplication removing, but considering the following code, it is OK to duplicate prepende modules. ```ruby module M; end class A; end class B [M, B, M, A, Object, Kernel, BasicObject] ``` Am I missing something? Matz. -- https://bugs.ruby-lang.org/