[ruby-core:100163] [Ruby master Bug#17191] 3.0.0-preview1 fails to install using BSD make

[ruby-core:100163] [Ruby master Bug#17191] 3.0.0-preview1 fails to install using BSD make

[merch-redmine]

Issue #17191 has been reported by jeremyevans0 (Jeremy Evans).

----------------------------------------
Bug #17191: 3.0.0-preview1 fails to install using BSD make
https://bugs.ruby-lang.org/issues/17191

* Author: jeremyevans0 (Jeremy Evans)
* Status: Assigned
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* ruby -v: ruby 3.0.0preview1 (2020-09-25 master 0096d2b895) [x86_64-openbsd]
* Backport: 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED
----------------------------------------
On OpenBSD (which doesn't use GNU make by default), `./configure` and `make` work correctly for 3.0.0-preview1, but `make install` fails with:

```
Downloading bundled gem files...
executable host ruby is required. use --with-baseruby option.
```

This issue can be worked around by making this change in common.mk, but I'm sure it breaks other cases:

```diff
@@ -1296,7 +1296,7 @@ update-config_files: PHONY
            config.guess config.sub

 refresh-gems: update-bundled_gems prepare-gems
-prepare-gems: update-gems extract-gems
+prepare-gems: extract-gems

 update-gems$(gnumake:yes=-nongnumake): PHONY
        $(ECHO) Downloading bundled gem files...
```

There's obviously no need to update gems when installing 3.0.0-preview1 from the tarball as the gems are already included in the tarball.

I think this may be caused by commit:88f4ebac83a77f933e9da099eabdf05004767de9, and I don't think it affects GNU make.  It works correctly in earlier Ruby versions.



-- 
https://bugs.ruby-lang.org/

[ruby-core:100195] [Ruby master Bug#17191] 3.0.0-preview1 fails to install using BSD make

[nobu]

Issue #17191 has been updated by nobu (Nobuyoshi Nakada).


jeremyevans0 (Jeremy Evans) wrote:
> There's obviously no need to update gems when installing 3.0.0-preview1 from the tarball as the gems are already included in the tarball.

This is the point.

> I think this may be caused by commit:88f4ebac83a77f933e9da099eabdf05004767de9, and I don't think it affects GNU make.  It works correctly in earlier Ruby versions.

That is just a workaround; `update-gems` should be skipped when building from tarballs, even if gem files are not downloaded.
But the difference between them is not obvious. 

How about this?

```diff
```

----------------------------------------
Bug #17191: 3.0.0-preview1 fails to install using BSD make
https://bugs.ruby-lang.org/issues/17191#change-87766

* Author: jeremyevans0 (Jeremy Evans)
* Status: Assigned
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* ruby -v: ruby 3.0.0preview1 (2020-09-25 master 0096d2b895) [x86_64-openbsd]
* Backport: 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED
----------------------------------------
On OpenBSD (which doesn't use GNU make by default), `./configure` and `make` work correctly for 3.0.0-preview1, but `make install` fails with:

```
Downloading bundled gem files...
executable host ruby is required. use --with-baseruby option.
```

This issue can be worked around by making this change in common.mk, but I'm sure it breaks other cases:

```diff
@@ -1296,7 +1296,7 @@ update-config_files: PHONY
            config.guess config.sub

 refresh-gems: update-bundled_gems prepare-gems
-prepare-gems: update-gems extract-gems
+prepare-gems: extract-gems

 update-gems$(gnumake:yes=-nongnumake): PHONY
        $(ECHO) Downloading bundled gem files...
```

There's obviously no need to update gems when installing 3.0.0-preview1 from the tarball as the gems are already included in the tarball.

I think this may be caused by commit:88f4ebac83a77f933e9da099eabdf05004767de9, and I don't think it affects GNU make.  It works correctly in earlier Ruby versions.



-- 
https://bugs.ruby-lang.org/

[ruby-core:100202] [Ruby master Bug#17191] 3.0.0-preview1 fails to install using BSD make

[merch-redmine]

Issue #17191 has been updated by jeremyevans0 (Jeremy Evans).


nobu (Nobuyoshi Nakada) wrote in #note-1:
> That is just a workaround; `update-gems` should be skipped when building from tarballs, even if gem files are not downloaded.
> But the difference between them is not obvious. 
> 
> How about this?
> 
> ```diff
> diff --git i/common.mk w/common.mk
> index bfad80bc9ba..7e22720d8f1 100644
> --- i/common.mk
> +++ w/common.mk
> @@ -1296,7 +1296,7 @@ update-config_files: PHONY
>  	    config.guess config.sub
>  
>  refresh-gems: update-bundled_gems prepare-gems
> -prepare-gems: update-gems extract-gems
> +prepare-gems: $(HAVE_BASERUBY:yes=update-gems) $(HAVE_BASERUBY:yes=extract-gems)
>  
>  update-gems$(gnumake:yes=-nongnumake): PHONY
>  	$(ECHO) Downloading bundled gem files...

I tested this and it works.  Thank you!  Can you please commit it?

----------------------------------------
Bug #17191: 3.0.0-preview1 fails to install using BSD make
https://bugs.ruby-lang.org/issues/17191#change-87772

* Author: jeremyevans0 (Jeremy Evans)
* Status: Assigned
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* ruby -v: ruby 3.0.0preview1 (2020-09-25 master 0096d2b895) [x86_64-openbsd]
* Backport: 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED
----------------------------------------
On OpenBSD (which doesn't use GNU make by default), `./configure` and `make` work correctly for 3.0.0-preview1, but `make install` fails with:

```
Downloading bundled gem files...
executable host ruby is required. use --with-baseruby option.
```

This issue can be worked around by making this change in common.mk, but I'm sure it breaks other cases:

```diff
@@ -1296,7 +1296,7 @@ update-config_files: PHONY
            config.guess config.sub

 refresh-gems: update-bundled_gems prepare-gems
-prepare-gems: update-gems extract-gems
+prepare-gems: extract-gems

 update-gems$(gnumake:yes=-nongnumake): PHONY
        $(ECHO) Downloading bundled gem files...
```

There's obviously no need to update gems when installing 3.0.0-preview1 from the tarball as the gems are already included in the tarball.

I think this may be caused by commit:88f4ebac83a77f933e9da099eabdf05004767de9, and I don't think it affects GNU make.  It works correctly in earlier Ruby versions.



-- 
https://bugs.ruby-lang.org/