From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id AB6761F5AE for ; Wed, 24 Jun 2020 12:58:16 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C01901209B7; Wed, 24 Jun 2020 21:57:42 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 88404120976 for ; Wed, 24 Jun 2020 21:57:38 +0900 (JST) Received: by filter0130p3las1.sendgrid.net with SMTP id filter0130p3las1-3679-5EF34DD5-3E 2020-06-24 12:57:57.406180376 +0000 UTC m=+498484.398681523 Received: from herokuapp.com (unknown) by ismtpd0032p1iad2.sendgrid.net (SG) with ESMTP id 1hqlcNVRQw6O354Kl9sOzQ for ; Wed, 24 Jun 2020 12:57:57.283 +0000 (UTC) Date: Wed, 24 Jun 2020 12:57:57 +0000 (UTC) From: kuwabara@pocke.me Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74722 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 16983 X-Redmine-Issue-Author: pocke X-Redmine-Sender: pocke X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?j7HwCZ0aQf2pk3zHt6THCG3lqueHW5K1dfhmuzHPcSQ8DR6lzdGkRyDiXLMw8X?= =?us-ascii?Q?Lv4=2FUlpZfu9463NH9znmk=2F4+GgCqG301utbMPPx?= =?us-ascii?Q?YWTgbuDbqaa4J2H45Yv8PRXTptWv8xjXl+llZ9h?= =?us-ascii?Q?FJcLX2T0Lg8SM9btK+0Rc8IergTC3RFINCcSXDY?= =?us-ascii?Q?tDYpZMAkI3c023IDVsMQ7mBIP9gQJXz326g=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 98931 Subject: [ruby-core:98931] [Ruby master Bug#16983] RubyVM::AbstractSyntaxTree.of(method) returns meaningless node if the method is defined in eval X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16983 has been reported by pocke (Masataka Kuwabara). ---------------------------------------- Bug #16983: RubyVM::AbstractSyntaxTree.of(method) returns meaningless node if the method is defined in eval https://bugs.ruby-lang.org/issues/16983 * Author: pocke (Masataka Kuwabara) * Status: Open * Priority: Normal * ruby -v: ruby 2.8.0dev (2020-06-23T13:58:26Z master dc351ff984) [x86_64-linux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- # Problem `RubyVM::AST.of(method)` returns a meaningless node if the method is defined in eval. For example: ```ruby p 'blah' eval <<~RUBY, binding, __FILE__, __LINE__ + 1 def foo end RUBY method = method(:foo) pp RubyVM::AbstractSyntaxTree.of(method) # => (STR@3:5-3:12 "def foo\n" + "end\n") ``` I expect the node of `foo` method, or `nil`. But it returns a `STR` node. It becomes a big problem when `AST.of` receives arbitrary methods. Because we can't distinguish a method is defined in `eval` or not. It means we can't believe the returned value of `AST.of` if the method may receive a method defined in `eval`. For example: ```ruby def do_something_for_each_method_ast(klass) klass.instance_methods(false).each do |m| ast = RubyVM::AbstractSyntaxTree.of(klass.instance_method(m)) next unless ast do_something ast end end class A eval <<~RUBY, binding, __FILE__, __LINE__ + 1 def foo end RUBY end do_something_for_each_method_ast A ``` In the example, I expect the `do_something` method receives only node for a method definition, but it may pass a wrong node if any method is defined in `eval`. # Cause (I guess) I guess the cause is misleading node number. In and out of an `eval` block uses different sequences of node number. So if I specify `__FILE__` to `eval`, the actual file and code in `eval` may have the same node number. For example ```ruby p 'blah' # Node number for 'blah' is 1, file name is "test.rb" eval <<~RUBY, binding, __FILE__, __LINE__ + 1 def foo # Node number for `def` is also 1, file name is also "test.rb" end RUBY method = method(:foo) # It finds a node from node number 1 by reading "test.rb", so it get the str node. pp RubyVM::AbstractSyntaxTree.of(method) # => (STR@3:5-3:12 "def foo\n" + "end\n") ``` -- https://bugs.ruby-lang.org/