From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 547901F610 for ; Sat, 11 Apr 2020 22:17:51 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 16B791209E0; Sun, 12 Apr 2020 07:17:27 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 5E2D8120808 for ; Sun, 12 Apr 2020 07:17:24 +0900 (JST) Received: by filter0073p3las1.sendgrid.net with SMTP id filter0073p3las1-7488-5E924200-B0 2020-04-11 22:17:37.049942776 +0000 UTC m=+866763.852937005 Received: from herokuapp.com (unknown) by ismtpd0032p1iad2.sendgrid.net (SG) with ESMTP id VbAgET9qQG2b300pfe3_Tg for ; Sat, 11 Apr 2020 22:17:36.913 +0000 (UTC) Date: Sat, 11 Apr 2020 22:17:37 +0000 (UTC) From: ryan.gerard@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 73599 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 16780 X-Redmine-Issue-Author: rgerard X-Redmine-Sender: rgerard X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?aFekJlPWoWBgFcpG0YVK1ARDUmW2F5fticDAN9JVANUrrbFDOhe0kFBk2ZSJK2?= =?us-ascii?Q?zIPyGp2RgnofyF2DoF2J3O0eN+tSx4rUWtTBFKI?= =?us-ascii?Q?ihRjngQHPqpsoPBf7oegsYdLqPYuFGeeJZEuuLY?= =?us-ascii?Q?KiiO61TxNo8+vkZF2Y5Ied5Dfy+UykbUOtCbz1E?= =?us-ascii?Q?4jBkwuPRUn+KtIAVRygIaDH6C8OqohWNoDw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 97838 Subject: [ruby-core:97838] [Ruby master Bug#16780] Net::FTP PUT command issuing Net::ReadTimeout too quickly X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16780 has been reported by rgerard (Ryan Gerard). ---------------------------------------- Bug #16780: Net::FTP PUT command issuing Net::ReadTimeout too quickly https://bugs.ruby-lang.org/issues/16780 * Author: rgerard (Ryan Gerard) * Status: Open * Priority: Normal * ruby -v: 2.7.1 * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- This is my first time writing up an issue for this community, so I apologize if this is written in an abnormal way than your normal issues. We recently upgraded from ruby 2.6.5 to 2.7.1. Almost immediately, we started seeing issues with some of our application code that utilizes Net::FTP. All calls to #put to an external FTP server we communicate with were resulting in a Net::ReadTimeout exception being throw. Upon examination of the external FTP server, we can see that the file was successfully transferred, although the Net::ReadTimeout exception begin thrown caused confusion on our end. Looking over the changes that were part of the ruby 2.7.0 release, I believe this commit (https://github.com/ruby/ruby/commit/5be34d6a3310065850c0c530db6936415124b5d9), which was a fix for this bug (https://bugs.ruby-lang.org/issues/16413) is the root of the issue. I translated the japanese, and I understand that the change to add the `begin` and `ensure` blocks were to make sure the connection was closed in case an exception is thrown during the transfer. However, the additional change to the connection read_timeout to 1 second was a little puzzling. I can see that this logic was copied from `retrbinary` and `retrlines`, but I'm uncertain why the connection read_timeout should be changed to 1 second. I believe the right fix is to remove the change to the connection read_timeout. Here is the stack trace for the exception we're getting during the call to #put: Net::ReadTimeout with # /usr/local/lib/ruby/2.7.0/net/protocol.rb:217:in `rbuf_fill' /usr/local/lib/ruby/2.7.0/net/protocol.rb:159:in `read' /usr/local/lib/ruby/2.7.0/net/ftp.rb:1475:in `read' /usr/local/lib/ruby/2.7.0/net/ftp.rb:693:in `block (2 levels) in storbinary' /usr/local/lib/ruby/2.7.0/net/ftp.rb:308:in `with_binary' /usr/local/lib/ruby/2.7.0/net/ftp.rb:684:in `block in storbinary' /usr/local/lib/ruby/2.7.0/monitor.rb:202:in `synchronize' /usr/local/lib/ruby/2.7.0/monitor.rb:202:in `mon_synchronize' /usr/local/lib/ruby/2.7.0/net/ftp.rb:683:in `storbinary' /usr/local/lib/ruby/2.7.0/net/ftp.rb:843:in `putbinaryfile' /usr/local/lib/ruby/2.7.0/net/ftp.rb:871:in `put' -- https://bugs.ruby-lang.org/