From: tenderlove@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95576] [Ruby master Feature#16282] Add "call data" wrapper IMEMO object so inline cache can be updated
Date: Mon, 28 Oct 2019 23:26:16 +0000 (UTC) [thread overview]
Message-ID: <redmine.issue-16282.20191028232616.657062223c584f41@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16282.20191028232616@ruby-lang.org
Issue #16282 has been reported by tenderlovemaking (Aaron Patterson).
----------------------------------------
Feature #16282: Add "call data" wrapper IMEMO object so inline cache can be updated
https://bugs.ruby-lang.org/issues/16282
* Author: tenderlovemaking (Aaron Patterson)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
Hi,
Currently the compactor will invalidate all inline caches. I would like to update references in inline caches so we don't have to invalidate. Most inline caches are reachable from instruction sequences, but one cache is not:
https://github.com/ruby/ruby/blob/6147fa82a923e7318f493857023006801ed25eb5/internal.h#L2395
This static variable can't be reached from the GC. I'd like to introduce a new IMEMO object that wraps this cache, then the GC can reach the cache and update the value.
I've attached a patch that implements the new IMEMO object, and also removes the restriction on GCC so that all compilers get the cache hit.
Does this seem OK shyouhei, ko1?
---Files--------------------------------
0001-Wrap-call-data-with-an-IMEMO-object.patch (3.8 KB)
--
https://bugs.ruby-lang.org/
next parent reply other threads:[~2019-10-28 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-16282.20191028232616@ruby-lang.org>
2019-10-28 23:26 ` tenderlove [this message]
2019-10-29 0:01 ` [ruby-core:95577] [Ruby master Feature#16282] Add "call data" wrapper IMEMO object so inline cache can be updated tenderlove
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-16282.20191028232616.657062223c584f41@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).