From: wolf@wolfsden.cz
To: ruby-core@ruby-lang.org
Subject: [ruby-core:92633] [Ruby trunk Bug#15847] SecureRandom#gen_random becomes private after first invocation
Date: Mon, 13 May 2019 15:07:26 +0000 (UTC) [thread overview]
Message-ID: <redmine.issue-15847.20190513150725.bf1a8363d7ea9515@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15847.20190513150725@ruby-lang.org
Issue #15847 has been reported by graywolf (Gray Wolf).
----------------------------------------
Bug #15847: SecureRandom#gen_random becomes private after first invocation
https://bugs.ruby-lang.org/issues/15847
* Author: graywolf (Gray Wolf)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
There seems to be an issue with `SecureRandom#gen_random` becoming private after first invocation:
```
+ $ /tmp/my_ruby/bin/ruby -v
ruby 2.7.0dev (2019-05-13 trunk 082bbdc92e) [x86_64-linux]
```
```
$ /tmp/my_ruby/bin/ruby \
-e 'require "securerandom"' \
-e 'SecureRandom.gen_random(1)'
$ /tmp/my_ruby/bin/ruby \
-e 'require "securerandom"' \
-e 'SecureRandom.gen_random(1)' \
-e 'SecureRandom.gen_random(1)'
Traceback (most recent call last):
-e:3:in `<main>': private method `gen_random' called for SecureRandom:Module (NoMethodError)
```
This is caused by using alias since 2.5 ruby in secure random class. Both
`.gen_random_openssl` and `.gen_random_urandom` are private class method. Using
the `alias` on them does not remove the private property, so new `.gen_random`
is private as well. Patch fixing the issue:
```
diff --git a/lib/securerandom.rb b/lib/securerandom.rb
index 37835bf7df..2b0f3753b3 100644
--- a/lib/securerandom.rb
+++ b/lib/securerandom.rb
@@ -84,7 +84,8 @@ def gen_random(n)
@rng_chooser.synchronize do
class << self
remove_method :gen_random
- alias gen_random gen_random_openssl
+ alias_method(:gen_random, :gen_random_openssl)
+ public(:gen_random)
end
end
return gen_random(n)
@@ -93,7 +94,8 @@ class << self
@rng_chooser.synchronize do
class << self
remove_method :gen_random
- alias gen_random gen_random_urandom
+ alias_method(:gen_random, :gen_random_urandom)
+ public(:gen_random)
end
end
return gen_random(n)
```
This bug is not present in 2.4.6. First noticed on 2.5.5. Examples in this
ticket are from current trunk.
--
https://bugs.ruby-lang.org/
next parent reply other threads:[~2019-05-13 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15847.20190513150725@ruby-lang.org>
2019-05-13 15:07 ` wolf [this message]
2019-05-14 2:50 ` [ruby-core:92640] [Ruby trunk Bug#15847] SecureRandom#gen_random becomes private after first invocation shyouhei
2019-08-01 13:18 ` [ruby-core:94094] [Ruby master " nagachika00
2019-08-26 15:13 ` [ruby-core:94571] " usa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-15847.20190513150725.bf1a8363d7ea9515@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).