From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 3823A1F404 for ; Sat, 13 Jan 2018 19:33:35 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 45C9E120902; Sun, 14 Jan 2018 04:33:32 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0223C1208FF for ; Sun, 14 Jan 2018 04:33:29 +0900 (JST) Received: by filter0025p3iad2.sendgrid.net with SMTP id filter0025p3iad2-19727-5A5A5F05-42 2018-01-13 19:33:25.761756382 +0000 UTC Received: from herokuapp.com (ec2-54-167-19-147.compute-1.amazonaws.com [54.167.19.147]) by ismtpd0007p1iad2.sendgrid.net (SG) with ESMTP id 8l8Wv0nHSnqKe1X8ffCHlg for ; Sat, 13 Jan 2018 19:33:25.932 +0000 (UTC) Date: Sat, 13 Jan 2018 19:33:26 +0000 (UTC) From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 60083 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14353 X-Redmine-Issue-Author: Eregon X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4okR2WSGvh+vqMtCcigeqOjk/FCls9nSASWt nzLbV/lIwJ0Gp6eUFID1zAZs+VNJcUhqfJ2K1BRzE0vI0ve0E0nqOcNUJI22vU2bv6dVCeuQf6q1YV 4sJ1nOfEOykvLNF5hwCrTTnxvYyoZI2kR7YFraT8BOZQLWPgcZ8W11nVTw== X-ML-Name: ruby-core X-Mail-Count: 84850 Subject: [ruby-core:84850] [Ruby trunk Bug#14353] $SAFE should stay at least thread-local for compatibility X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14353 has been reported by Eregon (Benoit Daloze). ---------------------------------------- Bug #14353: $SAFE should stay at least thread-local for compatibility https://bugs.ruby-lang.org/issues/14353 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- In #14250 $SAFE changed from a frame+thread-local variable to a process-wide global variable. This feels wrong and breaks the most common usage of $SAFE in tests: ~~~ ruby Thread.new { $SAFE = 1 sth that should be checked to work under $SAFE==1 }.join ~~~ It is very clear this is incompatible given how many files (33!) had to be changed in r61510. And it has wide ranging confusing side-effects, one example: https://travis-ci.org/ruby/spec/jobs/328524568 I agree frame-local is too much for $SAFE. But removing thread-local seems to only introduce large incompatibilities. It also makes it impossible to use it in a thread-safe way. The common pattern (not necessarily for $SAFE, more often for $VERBOSE): ~~~ ruby begin old = $SAFE $SAFE = 1 something under SAFE==1 ensure $SAFE = old end ~~~ is unsafe if two threads run it concurrently (The last thread executing `$SAFE = old` might restore to 1 even though it should be 0). (Actually I believe most built-in variables (e.g. $VERBOSE) should be thread-local and not process-wide due to this) Since $SAFE is being deprecated and removed, I don't see any reason to make it more incompatible than needed. @ko1 Can we switch it back to thread-local for compatibility, avoiding headaches and keeping it usable with multiple threads? -- https://bugs.ruby-lang.org/