From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 1A8B71F406 for ; Sat, 6 Jan 2018 15:32:16 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A1A421209A0; Sun, 7 Jan 2018 00:32:12 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 6729712099F for ; Sun, 7 Jan 2018 00:32:10 +0900 (JST) Received: by filter0011p3las1.sendgrid.net with SMTP id filter0011p3las1-19878-5A50EBF6-1C 2018-01-06 15:32:06.522248417 +0000 UTC Received: from herokuapp.com (ec2-54-162-194-35.compute-1.amazonaws.com [54.162.194.35]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id Eh_vHMHVRqWmaGPFD6anLA for ; Sat, 06 Jan 2018 15:32:06.353 +0000 (UTC) Date: Sat, 06 Jan 2018 15:32:07 +0000 (UTC) From: zn@mbf.nifty.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 59907 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14325 X-Redmine-Issue-Author: znz X-Redmine-Issue-Assignee: knu X-Redmine-Sender: znz X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7NyzbRl/e2inmyRtk5Lp0hLvROUIPFxy69pu mZ579S6JPUQebzIi37Kqm4bZhQdpE+XkDss6XcpvYisnknnp4KS8dYCDZYIXLPqtUi82fw1Yjkem5k axSMZ9i560uh10+18SIu9RrHCAOBc1+dSa+DpKIk/FMjHPoMAV8kVBDvfg== X-ML-Name: ruby-core X-Mail-Count: 84677 Subject: [ruby-core:84677] [Ruby trunk Bug#14325] Set#reset raise RuntimeError instead of FrozenError X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14325 has been reported by znz (Kazuhiro NISHIYAMA). ---------------------------------------- Bug #14325: Set#reset raise RuntimeError instead of FrozenError https://bugs.ruby-lang.org/issues/14325 * Author: znz (Kazuhiro NISHIYAMA) * Status: Assigned * Priority: Normal * Assignee: knu (Akinori MUSHA) * Target version: * ruby -v: ruby 2.6.0dev (2018-01-06 trunk 61640) [x86_64-darwin16] * Backport: 2.3: DONTNEED, 2.4: DONTNEED, 2.5: UNKNOWN ---------------------------------------- I think it should use `FrozenError` instead of `RuntimeError`. I can't reproduce without modifying instance variable directly. ``` % ruby -v -r set -e 'Set[].tap{|s|s.instance_variable_set(:@hash, :dummy)}.freeze.reset' ruby 2.6.0dev (2018-01-06 trunk 61640) [x86_64-darwin16] Traceback (most recent call last): 1: from -e:1:in `
' .../lib/ruby/2.6.0/set.rb:527:in `reset': can't modify frozen Set (RuntimeError) % ruby -v -I ./lib -r set -e 'Set[].tap{|s|s.instance_variable_set(:@hash, :dummy)}.freeze.reset' ruby 2.6.0dev (2018-01-06 trunk 61640) [x86_64-darwin16] Traceback (most recent call last): 1: from -e:1:in `
' .../lib/set.rb:527:in `reset': can't modify frozen Set (FrozenError) ``` ```patch diff --git a/lib/set.rb b/lib/set.rb index 9642e74af4..d777b81b8f 100644 --- a/lib/set.rb +++ b/lib/set.rb @@ -524,7 +524,7 @@ def reset if @hash.respond_to?(:rehash) @hash.rehash # This should perform frozenness check. else - raise "can't modify frozen #{self.class.name}" if frozen? + raise FrozenError, "can't modify frozen #{self.class.name}" if frozen? end self end ``` -- https://bugs.ruby-lang.org/