[ruby-core:73840] [Ruby trunk Feature#12077] Consolidate SSLSocket interface with TCPSocket

[ruby-core:73840] [Ruby trunk Feature#12077] Consolidate SSLSocket interface with TCPSocket

[tonci.damjanic]

Issue #12077 has been reported by Tonči Damjanić.

----------------------------------------
Feature #12077: Consolidate SSLSocket interface with TCPSocket
https://bugs.ruby-lang.org/issues/12077

* Author: Tonči Damjanić
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hello,

Is there a reason why `SSLSocket#read` doesn't work the same as `SSLSocket#sysread` and why there is no `SSLSocket#recv`? Right now it is impossible to have code agnostic in regards to the socket type.

One solution is to monkey-patch `OpenSSL::SSL::SSLSocket` (see lower) to share the same interface as `TCPSocket`, but given the generic names of monkey-patched functions, I'm not sure if they could result with some leaks or strange behavior.

~~~
class OpenSSL::SSL::SSLSocket
  def read(*args)
    sysread(*args)
  end
  
  def write(*args)
    syswrite(*args)
  end
  
  def close
    sysclose
  end
end
~~~

Thoughts?



-- 
https://bugs.ruby-lang.org/

[ruby-core:73841] [Ruby trunk Feature#12077] Consolidate SSLSocket interface with TCPSocket

[tonci.damjanic]

Issue #12077 has been updated by Tonči Damjanić.

Description updated

----------------------------------------
Feature #12077: Consolidate SSLSocket interface with TCPSocket
https://bugs.ruby-lang.org/issues/12077#change-57016

* Author: Tonči Damjanić
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hello,

Is there a reason why `SSLSocket#read` doesn't work the same as `SSLSocket#sysread` and why there is no `SSLSocket#recv`? 

Right now it is impossible to have code agnostic in regards to the socket type.

One solution is to monkey-patch `OpenSSL::SSL::SSLSocket` (see lower) to share the same interface as `TCPSocket`, but given the generic names of monkey-patched functions, I'm not sure if they could result with some leaks or strange behavior.

~~~
class OpenSSL::SSL::SSLSocket
  def read(*args)
    sysread(*args)
  end
  
  def write(*args)
    syswrite(*args)
  end
  
  def close
    sysclose
  end
end
~~~

Thoughts?



-- 
https://bugs.ruby-lang.org/

[ruby-core:73842] [Ruby trunk Feature#12077] Consolidate SSLSocket interface with TCPSocket

[tonci.damjanic]

Issue #12077 has been updated by Tonči Damjanić.

Description updated

----------------------------------------
Feature #12077: Consolidate SSLSocket interface with TCPSocket
https://bugs.ruby-lang.org/issues/12077#change-57017

* Author: Tonči Damjanić
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hello,

Is there a reason why `SSLSocket#read` doesn't work the same as `SSLSocket#sysread` and why there is no `SSLSocket#recv`? 

Right now it is impossible to have code agnostic in regards to the socket type.

One solution is to monkey-patch `OpenSSL::SSL::SSLSocket` (see lower) to share the same interface as `TCPSocket`, but given the generic names of monkey-patched functions, I'm not sure if they could result with some leaks or strange behavior.

~~~ ruby
class OpenSSL::SSL::SSLSocket
  def read(*args)
    sysread(*args)
  end
  
  def write(*args)
    syswrite(*args)
  end
  
  def close
    sysclose
  end
end
~~~

Thoughts?



-- 
https://bugs.ruby-lang.org/

[ruby-core:73963] [Ruby trunk Feature#12077] Consolidate SSLSocket interface with TCPSocket

[tonci.damjanic]

Issue #12077 has been updated by Tonči Damjanić.

Assignee set to ruby-core

----------------------------------------
Feature #12077: Consolidate SSLSocket interface with TCPSocket
https://bugs.ruby-lang.org/issues/12077#change-57116

* Author: Tonči Damjanić
* Status: Open
* Priority: Normal
* Assignee: ruby-core
----------------------------------------
Hello,

Is there a reason why `SSLSocket#read` doesn't work the same as `SSLSocket#sysread` and why there is no `SSLSocket#recv`? 

Right now it is impossible to have code agnostic in regards to the socket type.

One solution is to monkey-patch `OpenSSL::SSL::SSLSocket` (see lower) to share the same interface as `TCPSocket`, but given the generic names of monkey-patched functions, I'm not sure if they could result with some leaks or strange behavior.

~~~ ruby
class OpenSSL::SSL::SSLSocket
  def read(*args)
    sysread(*args)
  end
  
  def write(*args)
    syswrite(*args)
  end
  
  def close
    sysclose
  end
end
~~~

Thoughts?



-- 
https://bugs.ruby-lang.org/

[ruby-core:74175] Re: [Ruby trunk Feature#12077] Consolidate SSLSocket interface with TCPSocket

[Eric Wong]

tonci.damjanic@gmail.com wrote:
> Is there a reason why `SSLSocket#read` doesn't work the same
> as `SSLSocket#sysread`

Because IO#read and IO#sysread are different, too.  The former
is read-in-full behavior (outside of EOF) while sysread matches
the low-level C interface and allows for partial reads.

Likewise with write vs syswrite regarding write-in-full
behavior.

> and why there is no `SSLSocket#recv`?

Currently, OpenSSL does not provide an interface to recv(2)
which handles flag arguments :<

I too wish for recv(2) and send(2) interfaces which lets me
use MSG_MORE|MSG_DONTWAIT flags.