From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 7DAA217DC893 for ; Tue, 22 Dec 2015 11:23:53 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 40642B5D91B for ; Tue, 22 Dec 2015 11:56:11 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 7D32C18CC7B8 for ; Tue, 22 Dec 2015 11:56:11 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EB8ED120528; Tue, 22 Dec 2015 11:56:09 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id D9A31120517 for ; Tue, 22 Dec 2015 11:56:05 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=es7g6lq9RImCd1aJR4I9U6lvGG4=; b=NwX02uHr43Xl6RYoQA t+m5VCAPsDZyr4wDuXI+it7ni1UT2K+zazM22TMGpG/2DL0CKHQ3gomRVQ9HDZAi 4zjLv2oT2riEKrtGj6fbAUTmGGs6xTOCJh/18BoG5sB8SnVLE7/GxGEkUtzy4ulo ZQw1SOq2R8jsfYgO2mLInpUbo= Received: by filter0819p1mdw1.sendgrid.net with SMTP id filter0819p1mdw1.16869.5678BBC28 2015-12-22 02:56:02.09672313 +0000 UTC Received: from herokuapp.com (ec2-54-161-237-60.compute-1.amazonaws.com [54.161.237.60]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id aWBy1m6RQhS-Xw6wELhhTA for ; Tue, 22 Dec 2015 02:56:01.795 +0000 (UTC) Date: Tue, 22 Dec 2015 02:56:01 +0000 From: tietew@tietew.net To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 47027 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11858 X-Redmine-Issue-Author: Tietew X-Redmine-Sender: Tietew X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS664f/Acmc+HD7TykLZhf0aIAl7hbVhTWQwmq 3PQTlgJmRDskn5XsGRsS+go33fHFQYIUhvGebLjryXF5WUxHwmqhl6XeBjlBpeZkps/7xCEutYdLkl eyhlwxMMhkrws0qfQRXWpl4lGzOTvRVKq5XE X-ML-Name: ruby-core X-Mail-Count: 72426 Subject: [ruby-core:72426] [Ruby trunk - Bug #11858] [Open] CGI.escapeHTML should NOT return frozen string X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11858 has been reported by Toru Iwase. ---------------------------------------- Bug #11858: CGI.escapeHTML should NOT return frozen string https://bugs.ruby-lang.org/issues/11858 * Author: Toru Iwase * Status: Open * Priority: Normal * Assignee: * ruby -v: ruby 2.3.0dev (2015-12-22 trunk 53233) [x86_64-linux] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- After r53220, following snippet fails. ~~~ $ ./ruby -rcgi -ve 'p CGI.escapeHTML("Hello, ".freeze) << "world."' ruby 2.3.0dev (2015-12-22 trunk 53233) [x86_64-linux] -e:1:in `
': can't modify frozen String (RuntimeError) ~~~ In preview2, works. ~~~ $ RBENV_VERSION=2.3.0-preview2 ruby -rcgi -ve 'p CGI.escapeHTML("Hello, ".freeze) << "world."' ruby 2.3.0preview2 (2015-12-11 trunk 53028) [x86_64-linux] "Hello, world." ~~~ I think this is backward incompatibility. `CGI.escapeHTML` should return different and unfreezed string from passed string as `String#gsub`. ~~~ $ ./irb ruby 2.3.0dev (2015-12-22 trunk 53233) [x86_64-linux] irb(main):001:0> str = "Ruby".freeze => "Ruby" irb(main):002:0> str.object_id => 70236871355920 irb(main):003:0> str.gsub(/\d/, '').frozen? => false irb(main):004:0> str.gsub(/\d/, '').object_id => 70236871220100 # different object irb(main):006:0> require 'cgi' => true irb(main):007:0> CGI.escapeHTML(str).frozen? => true irb(main):008:0> CGI.escapeHTML(str).object_id => 70236871355920 # same object ~~~ -- https://bugs.ruby-lang.org/