From: zach.dennis@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:69745] [Ruby trunk - Bug #11310] [Open] CSV::Table#to_csv should use concat not +
Date: Fri, 26 Jun 2015 15:16:15 +0000 [thread overview]
Message-ID: <redmine.issue-11310.20150626151615.bd887c7d2cfcd9f0@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11310.20150626151615@ruby-lang.org
Issue #11310 has been reported by Zach Dennis.
----------------------------------------
Bug #11310: CSV::Table#to_csv should use concat not +
https://bugs.ruby-lang.org/issues/11310
* Author: Zach Dennis
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux-gnu]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The current implementation of CSV::Table#to_a method uses Array#+ to which is really bad on performance. It seems like it should use Array#concat.
Relevant Github PR: https://github.com/ruby/ruby/pull/946
--
https://bugs.ruby-lang.org/
next parent reply other threads:[~2015-06-26 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11310.20150626151615@ruby-lang.org>
2015-06-26 15:16 ` zach.dennis [this message]
2017-05-10 11:38 ` [ruby-core:81091] [Ruby trunk Bug#11310][Assigned] CSV::Table#to_csv should use concat not + hsbt
2017-09-19 8:52 ` [ruby-core:82869] [Ruby trunk Bug#11310][Closed] " hsbt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-11310.20150626151615.bd887c7d2cfcd9f0@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).