From: apollon+ruby@skroutz.gr
To: ruby-core@ruby-lang.org
Subject: [ruby-core:69610] [Ruby trunk - Bug #11269] [Open] ruby_init_setproctitle() should be called before require_libraries()
Date: Tue, 16 Jun 2015 15:00:18 +0000 [thread overview]
Message-ID: <redmine.issue-11269.20150616150017.46f1d72c807c9b20@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11269.20150616150017@ruby-lang.org
Issue #11269 has been reported by Apollon Oikonomopoulos.
----------------------------------------
Bug #11269: ruby_init_setproctitle() should be called before require_libraries()
https://bugs.ruby-lang.org/issues/11269
* Author: Apollon Oikonomopoulos
* Status: Open
* Priority: Low
* Assignee:
* ruby -v: ruby 2.1.5p273
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
We have come across an issue where `setproctitle` fails to use the whole length of the process's initial environment. It turns out that this is because modules loaded using `-r` are processed before `ruby_init_setproctitle()`. This is easily reproducible using bundler, given the following test script under Linux:
~~~
File.open('/proc/self/cmdline') do |f|
@argv_len = f.read.size
end
File.open('/proc/self/environ') do |f|
@env_len = f.read.size
end
total = @argv_len + @env_len
$0 = 'a' * (total + 2) # should not overflow
File.open('/proc/self/environ') do |f|
env = f.read
puts env
puts env.size
end
~~~
Calling the script directly, we see that setproctitle works correctly:
~~~
$ env -i A_VAR=some_value PATH=/bin:/usr/bin ruby test.rb
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
36
~~~
In this case setproctitle correctly overwrites the whole environment space available. However, if we require `bundler/setup` (which is what `bundle exec` essentially does), the following happens:
~~~
$ env -i A_VAR=some_value PATH=/bin:/usr/bin ruby -rbundler/setup test.rb
aaaaaaaaaaaaaaaPATH=/bin:/usr/bin
36
~~~
This is because `require 'bundler/setup'` is processed before `ruby_init_setproctitle()` is called and attempts to manipulate `PATH`. While doing so, the new `PATH` string is allocated on the heap and the original pointer in `environ` replaced, thus breaking `ruby_init_setproctitle()`'s expectation to find a contiguous environment block.
Perhaps `ruby_init_setproctitle()` can be called before `process_options()`, so that it can process the environment block before a library gets a chance of modifying it.
--
https://bugs.ruby-lang.org/
next parent reply other threads:[~2015-06-16 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11269.20150616150017@ruby-lang.org>
2015-06-16 15:00 ` apollon+ruby [this message]
2015-06-17 3:01 ` [ruby-core:69626] [Ruby trunk - Bug #11269] [Assigned] ruby_init_setproctitle() should be called before require_libraries() kosaki.motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-11269.20150616150017.46f1d72c807c9b20@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).