From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:69577] [Ruby trunk - Bug #11260] [Open] [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails
Date: Sun, 14 Jun 2015 10:12:59 +0000 [thread overview]
Message-ID: <redmine.issue-11260.20150614101259.c63a51d7ef227963@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11260.20150614101259@ruby-lang.org
Issue #11260 has been reported by Benoit Daloze.
----------------------------------------
Bug #11260: [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails
https://bugs.ruby-lang.org/issues/11260
* Author: Benoit Daloze
* Status: Open
* Priority: Normal
* Assignee: Shugo Maeda
* ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
`Net::FTP` will keep the `TCPServer` created in `makeport` opened if `sendport` fails.
The patch sends the port in its (only) caller instead, so the TCPServer is appropriately closed no matter the outcome.
This was detected with RubySpec and a leak checker based on test/lib/leakchecker.rb.
---Files--------------------------------
0001-lib-net-ftp.rb-makeport-close-the-TCPServer.patch (3.43 KB)
--
https://bugs.ruby-lang.org/
next parent reply other threads:[~2015-06-14 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11260.20150614101259@ruby-lang.org>
2015-06-14 10:12 ` eregontp [this message]
2015-06-14 10:14 ` [ruby-core:69578] [Ruby trunk - Bug #11260] [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails eregontp
2015-06-27 9:04 ` [ruby-core:69753] [Ruby trunk - Bug #11260] [Assigned] " shugo
2015-06-27 10:13 ` [ruby-core:69755] [Ruby trunk - Bug #11260] [Closed] " eregontp
2015-06-30 3:11 ` [ruby-core:69786] [Ruby trunk - Bug #11260] " usa
2015-08-12 16:40 ` [ruby-core:70354] " nagachika00
2015-08-17 8:43 ` [ruby-core:70417] " usa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-11260.20150614101259.c63a51d7ef227963@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).