ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: ko1@atdot.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:69425] [Ruby trunk - Bug #11203] [Open] Change method entries into VALUE
Date: Mon, 01 Jun 2015 10:48:49 +0000	[thread overview]
Message-ID: <redmine.issue-11203.20150601104848.c6b33f12fb179e4c@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11203.20150601104848@ruby-lang.org

Issue #11203 has been reported by Koichi Sasada.

----------------------------------------
Bug #11203: Change method entries into VALUE
https://bugs.ruby-lang.org/issues/11203

* Author: Koichi Sasada
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: 
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Now, rb_method_entry_t is an allocated data pointed from method tables (class/module has) and from control frame stacks.

I will change this data structure to make VALUE (T_IMEMO/ment).
And I put them onto value frames instead of control frame stacks.

This change has several advantages.

* Solve these issues.
  * [Bug #11200] Memory leak of method entries
  * [Bug #11046] __callee__ returns incorrect method name in orphan proc
* Simplify sweeping process of method entry
* We can remove rb_control_frame_t::me
* No need to push CREF for every method invocation. Method entries know required CREF.
* We can share per method CREF only for make them public visibility scope.
* We can introduce other optimization techniques.
  * We can remove rb_control_frame_t::klass field because method entries can manipulate this information.
  * We can introduce new method cache mechanism (maybe).

The following pictures show how SVAR/CREF/MENT are located at value stacks.

![before-value-stack](1.PNG)
![after-value-stack](2.PNG)

The following picture shows how alias was implemented.

![alias-relation](3.PNG)



---Files--------------------------------
1.PNG (46.6 KB)
2.PNG (43.4 KB)
3.png (31.8 KB)


-- 
https://bugs.ruby-lang.org/

       reply	other threads:[~2015-06-01 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-11203.20150601104848@ruby-lang.org>
2015-06-01 10:48 ` ko1 [this message]
2015-06-01 17:17   ` [ruby-core:69433] Re: [Ruby trunk - Bug #11203] [Open] Change method entries into VALUE Eric Wong
2015-06-01 11:02 ` [ruby-core:69426] [Ruby trunk - Bug #11203] " nobu
2015-06-30  4:08 ` [ruby-core:69801] " usa
2015-07-02  0:14 ` [ruby-core:69834] " nagachika00

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.issue-11203.20150601104848.c6b33f12fb179e4c@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).