* [ruby-core:68486] [Ruby trunk - Feature #10958] [Open] remove "initial_state" argument of Enumerable#{slice_before, chunk}
[not found] <redmine.issue-10958.20150310124928@ruby-lang.org>
@ 2015-03-10 12:49 ` akr
2015-03-10 16:28 ` [ruby-core:68488] [Ruby trunk - Feature #10958] " eregontp
2015-04-06 13:55 ` [ruby-core:68768] " akr
2 siblings, 0 replies; 3+ messages in thread
From: akr @ 2015-03-10 12:49 UTC (permalink / raw
To: ruby-core
Issue #10958 has been reported by Akira Tanaka.
----------------------------------------
Feature #10958: remove "initial_state" argument of Enumerable#{slice_before,chunk}
https://bugs.ruby-lang.org/issues/10958
* Author: Akira Tanaka
* Status: Open
* Priority: Normal
* Assignee:
----------------------------------------
I'd like to remove "initial_state" argument of Enumerable#{slice_before,chunk}.
I think a state management can be implemented using local variable without the argument.
So I'd like to remove it because it is too complex and
not consistent with Enumerable#{slice_when,slice_after} which doesn't have the argument.
Note that I added deprecated warning since Ruby 2.2.
It seems no one complained the warning until now.
---Files--------------------------------
chunk_slice_before_remove_initial_state.patch (8 KB)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:68488] [Ruby trunk - Feature #10958] remove "initial_state" argument of Enumerable#{slice_before, chunk}
[not found] <redmine.issue-10958.20150310124928@ruby-lang.org>
2015-03-10 12:49 ` [ruby-core:68486] [Ruby trunk - Feature #10958] [Open] remove "initial_state" argument of Enumerable#{slice_before, chunk} akr
@ 2015-03-10 16:28 ` eregontp
2015-04-06 13:55 ` [ruby-core:68768] " akr
2 siblings, 0 replies; 3+ messages in thread
From: eregontp @ 2015-03-10 16:28 UTC (permalink / raw
To: ruby-core
Issue #10958 has been updated by Benoit Daloze.
+1, making these two simpler is definitely an improvement!
----------------------------------------
Feature #10958: remove "initial_state" argument of Enumerable#{slice_before,chunk}
https://bugs.ruby-lang.org/issues/10958#change-51823
* Author: Akira Tanaka
* Status: Open
* Priority: Normal
* Assignee:
----------------------------------------
I'd like to remove "initial_state" argument of Enumerable#{slice_before,chunk}.
I think a state management can be implemented using local variable without the argument.
So I'd like to remove it because it is too complex and
not consistent with Enumerable#{slice_when,slice_after} which doesn't have the argument.
Note that I added deprecated warning since Ruby 2.2.
It seems no one complained the warning until now.
---Files--------------------------------
chunk_slice_before_remove_initial_state.patch (8 KB)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:68768] [Ruby trunk - Feature #10958] remove "initial_state" argument of Enumerable#{slice_before, chunk}
[not found] <redmine.issue-10958.20150310124928@ruby-lang.org>
2015-03-10 12:49 ` [ruby-core:68486] [Ruby trunk - Feature #10958] [Open] remove "initial_state" argument of Enumerable#{slice_before, chunk} akr
2015-03-10 16:28 ` [ruby-core:68488] [Ruby trunk - Feature #10958] " eregontp
@ 2015-04-06 13:55 ` akr
2 siblings, 0 replies; 3+ messages in thread
From: akr @ 2015-04-06 13:55 UTC (permalink / raw
To: ruby-core
Issue #10958 has been updated by Akira Tanaka.
It seems no one against this. I committed.
----------------------------------------
Feature #10958: remove "initial_state" argument of Enumerable#{slice_before,chunk}
https://bugs.ruby-lang.org/issues/10958#change-52051
* Author: Akira Tanaka
* Status: Closed
* Priority: Normal
* Assignee:
----------------------------------------
I'd like to remove "initial_state" argument of Enumerable#{slice_before,chunk}.
I think a state management can be implemented using local variable without the argument.
So I'd like to remove it because it is too complex and
not consistent with Enumerable#{slice_when,slice_after} which doesn't have the argument.
Note that I added deprecated warning since Ruby 2.2.
It seems no one complained the warning until now.
---Files--------------------------------
chunk_slice_before_remove_initial_state.patch (8 KB)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-06 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <redmine.issue-10958.20150310124928@ruby-lang.org>
2015-03-10 12:49 ` [ruby-core:68486] [Ruby trunk - Feature #10958] [Open] remove "initial_state" argument of Enumerable#{slice_before, chunk} akr
2015-03-10 16:28 ` [ruby-core:68488] [Ruby trunk - Feature #10958] " eregontp
2015-04-06 13:55 ` [ruby-core:68768] " akr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).