[ruby-core:65091] [ruby-trunk - Bug #10252] [Open] [PATCH] digest/rmd160 looks for wrong OpenSSL function

[ruby-core:65091] [ruby-trunk - Bug #10252] [Open] [PATCH] digest/rmd160 looks for wrong OpenSSL function

[luizluca]

Issue #10252 has been reported by Luiz Angelo Daros de Luca.

----------------------------------------
Bug #10252: [PATCH] digest/rmd160 looks for wrong OpenSSL function
https://bugs.ruby-lang.org/issues/10252

* Author: Luiz Angelo Daros de Luca
* Status: Open
* Priority: Normal
* Assignee: 
* Category: ext
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux-gnu]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hello,

At ext/digest/rmd160/extconf.rb, there is:

 OpenSSL.check_func("RMD160_Transform", "openssl/ripemd.h")

However, there is no RMD160_Transform at the header file since ever (see: http://git.openssl.org/gitweb/?p=openssl.git;a=history;f=crypto/ripemd/ripemd.h;h=5942eb61808fe2ccdf9fbe4f3238271e55451567;hb=HEAD)

The correct name should be RIPEMD160_Transform.

The result is that ext/digest/rmd160 never uses OpenSSL implementation.

The attached patch fixes that.

BTW, all hashes that can optionaly use openssl (md5, sha1, sha1 and rmd160) check for xxx_Transform function in extconf.rb
in order to detect that OpenSSL is present. However, they only use xxx_Init, xxx_Update and xxx_Finish.
Shouldn't it check for them instead?

---Files--------------------------------
003-digest_rmd160_wrong_name_fix.patch (642 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:65406] [ruby-trunk - Bug #10252] [Closed] [PATCH] digest/rmd160 looks for wrong OpenSSL function

[nobu]

Issue #10252 has been updated by Nobuyoshi Nakada.

Status changed from Open to Closed
% Done changed from 0 to 100

Applied in changeset r47801.

----------
rmd160/extconf.rb: fix function name

* ext/digest/rmd160/extconf.rb: fix transform function name to
  check.  [ruby-core:65091] [Bug #10252]

----------------------------------------
Bug #10252: [PATCH] digest/rmd160 looks for wrong OpenSSL function
https://bugs.ruby-lang.org/issues/10252#change-49200

* Author: Luiz Angelo Daros de Luca
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: ext
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux-gnu]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hello,

At ext/digest/rmd160/extconf.rb, there is:

 OpenSSL.check_func("RMD160_Transform", "openssl/ripemd.h")

However, there is no RMD160_Transform at the header file since ever (see: http://git.openssl.org/gitweb/?p=openssl.git;a=history;f=crypto/ripemd/ripemd.h;h=5942eb61808fe2ccdf9fbe4f3238271e55451567;hb=HEAD)

The correct name should be RIPEMD160_Transform.

The result is that ext/digest/rmd160 never uses OpenSSL implementation.

The attached patch fixes that.

BTW, all hashes that can optionaly use openssl (md5, sha1, sha1 and rmd160) check for xxx_Transform function in extconf.rb
in order to detect that OpenSSL is present. However, they only use xxx_Init, xxx_Update and xxx_Finish.
Shouldn't it check for them instead?

---Files--------------------------------
003-digest_rmd160_wrong_name_fix.patch (642 Bytes)


-- 
https://bugs.ruby-lang.org/