From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 8C3FD17D000D for ; Tue, 29 Jul 2014 00:21:15 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id CA1BDB5D8AE for ; Mon, 28 Jul 2014 23:59:02 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id CAE9B97A832 for ; Mon, 28 Jul 2014 23:59:05 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H43kYtA9Oq7U for ; Mon, 28 Jul 2014 23:59:05 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 8FAD297A827 for ; Mon, 28 Jul 2014 23:59:05 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 5E4A095243A for ; Mon, 28 Jul 2014 23:59:01 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 90EEE12043F; Mon, 28 Jul 2014 23:58:53 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id D37B9120434 for ; Mon, 28 Jul 2014 23:58:50 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=epyK6q+AWHRIas40/D7OPFrFHSs=; b=LbGnEUqxu1obUK1IZ6 ZHiEFr7mUjL7ymdtjGdA/B2eRI40MyLpEF5jcps31NeuV7oQx3H9uKPQUJM9qEGX 4Hyo6TFx5HA95qGjdis98zNIvbGSaYLiDEfO2AHEx4XwtaXi042wu1AQvaLaOSIg s1ojfqQIsFSd9c8+75/e7jvUA= Received: by mf132.sendgrid.net with SMTP id mf132.961.53D6652616 2014-07-28 14:58:46.351507541 +0000 UTC Received: from herokuapp.com (ec2-54-204-227-220.compute-1.amazonaws.com [54.204.227.220]) by ismtpd-015.iad1.sendgrid.net (SG) with ESMTP id 1477d7ac055.238c.647e4f for ; Mon, 28 Jul 2014 14:58:22 +0000 (GMT) Date: Mon, 28 Jul 2014 14:58:22 +0000 From: arrtchiu@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 38259 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10098 X-Redmine-Issue-Author: arrtchiu X-Redmine-Sender: arrtchiu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS48wjIgFq2KPCFjajouzDj8trMTVA8OXuJ11MG42T+dkfWQ3EIHA2VknGBmR9P9JM+Xb1y70QBG/rE3rcRvaOpZcp/3fGy6TirkHF8DruClRrnXIuLu7H/22OEVuiaiU3Q= X-ML-Name: ruby-core X-Mail-Count: 64101 Subject: [ruby-core:64101] [ruby-trunk - Feature #10098] [Open] [PATCH] Timing-safe string comparison for OpenSSL::HMAC X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10098 has been reported by Matt U. ---------------------------------------- Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC https://bugs.ruby-lang.org/issues/10098 * Author: Matt U * Status: Open * Priority: Normal * Assignee: * Category: ext/openssl * Target version: next minor ---------------------------------------- I could be totally wrong, but it seems the standard library doesn't provide a reliable way of comparing hashes in constant-time. * The docs for `OpenSSL::HMAC` encourage the use of `Digest#to_s` (see: http://ruby-doc.org/stdlib-2.1.0/libdoc/openssl/rdoc/OpenSSL/HMAC.html#method-c-new ) * Ruby's string comparison uses memcmp, which isn't timing safe (see: http://rxr.whitequark.org/mri/source/string.c#2382 ) With this patch I propose to add an additional method, `OpenSSL::HMAC#verify`, which takes a binary string with a digest and compares it against the computed hash. ---Files-------------------------------- hmac-timing.patch (2.5 KB) -- https://bugs.ruby-lang.org/