From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS,T_DKIM_INVALID shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 17013202AB for ; Thu, 6 Jul 2017 20:22:09 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 30EBB12082E; Fri, 7 Jul 2017 05:22:05 +0900 (JST) Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by neon.ruby-lang.org (Postfix) with ESMTPS id C692512082D for ; Fri, 7 Jul 2017 05:22:00 +0900 (JST) Received: by mail-oi0-f43.google.com with SMTP id p188so11929094oia.0 for ; Thu, 06 Jul 2017 13:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acts246-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=TYtrqSbVITAuY66e0xHlL5pVN6f4YkWIWRapBzUBPb0=; b=kVBqrHZmg9sDFIfEj1M1nEnbfbjtNZNSqnKOEaQhxP21IbUs4duDSWvio3HdTfWGR7 mW/vc9O1pEQYGakGThhhcKoo+ztAGLxaSUDyHQvINvKLLyoIr6FhZo3HFRHe1Ovl058n /ZJ+MheoL4RuyYJD8P4P5Debnz4DHZoMCfo0N4d7SEGPHHHzwfJkqQ2jXWYybBvmbSO+ vz4aU9eRT0PVCEvhK4hv8gO2J5LczOu27eoIXFOTUR5YEEfMvLK4GBtWHWI42IuZ50eI NURq1bs2IDxejAWxQdbH1CJOYan0HGOPg0TVt2aGsWTApIyO5M/6kvdzs3GpyPHoWwDN Ljsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=TYtrqSbVITAuY66e0xHlL5pVN6f4YkWIWRapBzUBPb0=; b=ijLgxfEcx2PmVjPGjBH77hRvOXfpGr/hb6fmrUPlXYeQgddCG513WBn+C4FHHyCW7w W9jlGiftSXKR7AiNxIUQYvitAu4Co5g1cELCmUivNT+V7zYUOosdc0gfoez/21R5PaZA 7BRtfjiA7UYdeEELjHakI0o5eSUVQrgpyw8wYt/KIzZuuD/jz4XAQrvIt+wS7F0/o7Jh DsEQ0IQbJsyayGHxiYzuqIMpCUfHgVmYn1MrsKa3dYUiXHIvDwm6g7a/WNSxwQG/Yp8+ ujJjKbAKMRaZnN5gDIuOYqFA6G8ZW9tbW5SQ+0ptJ0VkcV0eNfGnmlrvXwNARVXwNCZo 5niQ== X-Gm-Message-State: AKS2vOwkLhljYrPej3I728MLxAVJStK2exLdeMkyVEmF/UXizZe6gr3S 4LIx+BMJ9G3qfbXDz/A02OcFM6jeKIuy X-Received: by 10.202.204.149 with SMTP id c143mr34365562oig.211.1499372518350; Thu, 06 Jul 2017 13:21:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.217.213 with HTTP; Thu, 6 Jul 2017 13:21:57 -0700 (PDT) In-Reply-To: References: From: Eduardo Souza Date: Thu, 6 Jul 2017 16:21:57 -0400 Message-ID: To: Ruby developers X-ML-Name: ruby-core X-Mail-Count: 81941 Subject: [ruby-core:81941] Re: [Ruby trunk Feature#12733] Bundle bundler to ruby core X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1936735821==" Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" --===============1936735821== Content-Type: multipart/alternative; boundary="001a1135333857b49a0553abde22" --001a1135333857b49a0553abde22 Content-Type: text/plain; charset="UTF-8" unsubscribe On Thu, Jul 6, 2017 at 2:49 PM, wrote: > Issue #12733 has been updated by Eregon (Benoit Daloze). > > > hsbt (Hiroshi SHIBATA) wrote: > > We can choose some strategy. > > > > * Rewrite bundler's rspec to minitest/spec > > * Ruby core bundle rspec and integrate rspec and test suite of ruby core. > > * Prepare isolation environment for bundler and rspec without test suite > of ruby core. We add new test task named "make test-bundler` and iinvoke it > on rubyci. > > * etc... > > > > These are only technical side problem. > > > > I'm going to solve this problem used `isolation environment` as first. > > > I think isolation environment is the best strategy (or the only > reasonable). > > Rewriting tests is not an option for upstream development and is very > time-consuming/error-prone (minitest/spec is a tiny subset of RSpec). > > I am not sure what you mean by bundling rspec, but rspec should not be > available to normal Ruby users like default gems. > It's a private dependency needed to run tests, and it probably makes most > sense to install it as a gem when running the tests. > > I suspect it might also be difficult to run the tests in-tree. > In that case I think it makes sense to require an installed Ruby to run > more integration-like tests. > > ---------------------------------------- > Feature #12733: Bundle bundler to ruby core > https://bugs.ruby-lang.org/issues/12733#change-65660 > > * Author: hsbt (Hiroshi SHIBATA) > * Status: Assigned > * Priority: Normal > * Assignee: hsbt (Hiroshi SHIBATA) > * Target version: 2.5 > ---------------------------------------- > rubygems team has plan to migrate bundler into rubygems at rubygems 3.0. > > ref. https://github.com/rubygems/rubygems/issues/1681 > > In current status, rubygems only use `Bundler` module on test suites. > But we should track rubygems upstream step by step. I propose to bundle > bundler > for stdlib as default gem on ruby core repository. > > but we have some consideration. such as > > * bundler uses rspec for test suites. How to use rspec on ruby core > repository? > * Who are maintain bundler on ruby core repository? > > This issue is epic topic. Please comment your concerns or idea. > > > > -- > https://bugs.ruby-lang.org/ > > Unsubscribe: > > -- Eduardo Souza www.acts246.com --001a1135333857b49a0553abde22 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
unsubscribe=C2=A0

On Thu, Jul 6, 2017 at 2:49 PM, &= lt;eregontp@gmail.c= om> wrote:
Issue #12733 has= been updated by Eregon (Benoit Daloze).


hsbt (Hiroshi SHIBATA) wrote:
> We can choose some strategy.
>
> * Rewrite bundler's rspec to minitest/spec
> * Ruby core bundle rspec and integrate rspec and test suite of ruby co= re.
> * Prepare isolation environment for bundler and rspec without test sui= te of ruby core. We add new test task named "make test-bundler` and ii= nvoke it on rubyci.
> * etc...
>
> These are only technical side problem.
>
> I'm going to solve this problem used `isolation environment` as fi= rst.


I think isolation environment is the best strategy (or the only reas= onable).

Rewriting tests is not an option for upstream development and is very time-= consuming/error-prone (minitest/spec is a tiny subset of RSpec).

I am not sure what you mean by bundling rspec, but rspec should not be avai= lable to normal Ruby users like default gems.
It's a private dependency needed to run tests, and it probably makes mo= st sense to install it as a gem when running the tests.

I suspect it might also be difficult to run the tests in-tree.
In that case I think it makes sense to require an installed Ruby to run mor= e integration-like tests.

----------------------------------------
Feature #12733: Bundle bundler to ruby core
https://bugs.ruby-lang.org/issues/12= 733#change-65660

* Author: hsbt (Hiroshi SHIBATA)
* Status: Assigned
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 2.5
----------------------------------------
rubygems team has plan to migrate bundler into rubygems at rubygems 3.0.
ref. https://github.com/rubygems/rubygems/issue= s/1681

In current status, rubygems only use `Bundler` module on test suites.
But we should track rubygems upstream step by step. I propose to bundle bun= dler
for stdlib as default gem on ruby core repository.

but we have some consideration. such as

=C2=A0* bundler uses rspec for test suites. How to use rspec on ruby core r= epository?
=C2=A0* Who are maintain bundler on ruby core repository?

This issue is epic topic. Please comment your concerns or idea.



--
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:= ruby-core-request@ruby-lang.org?subject=3Dunsubscribe>
<http://lists.ruby-lang.org/cgi-= bin/mailman/options/ruby-core>



--
=
Eduardo Souza

--001a1135333857b49a0553abde22-- --===============1936735821== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Unsubscribe: --===============1936735821==--