From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruby-core-bounces@ruby-lang.org>
X-Original-To: poffice@blade.nagaokaut.ac.jp
Delivered-To: poffice@blade.nagaokaut.ac.jp
Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24])
	by blade.nagaokaut.ac.jp (Postfix) with ESMTP id BE3E819C0036
	for <poffice@blade.nagaokaut.ac.jp>; Mon, 26 Oct 2015 16:58:39 +0900 (JST)
Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100])
	by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 5D0EDB5D916
	for <poffice@blade.nagaokaut.ac.jp>; Mon, 26 Oct 2015 17:26:18 +0900 (JST)
Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75])
	by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 77FFC952439
	for <poffice@blade.nagaokaut.ac.jp>; Mon, 26 Oct 2015 17:26:18 +0900 (JST)
Received: from [221.186.184.76] (localhost [IPv6:::1])
	by neon.ruby-lang.org (Postfix) with ESMTP id 26614120441;
	Mon, 26 Oct 2015 17:26:17 +0900 (JST)
X-Original-To: ruby-core@ruby-lang.org
Delivered-To: ruby-core@ruby-lang.org
Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com
 [209.85.192.50])
 by neon.ruby-lang.org (Postfix) with ESMTPS id A26DA120400
 for <ruby-core@ruby-lang.org>; Mon, 26 Oct 2015 17:26:12 +0900 (JST)
Received: by qgbb65 with SMTP id b65so113183785qgb.2
 for <ruby-core@ruby-lang.org>; Mon, 26 Oct 2015 01:26:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :content-type; bh=zFiPsTe1b4oTuKeyfkMbCnRok8J47YC+GWv3Xufgzuw=;
 b=crn0fGlBycNWRvgSO8XYYi8cBh2oULtJxWsaNE4eTPi0GsbHT22Oz2MpnYwNekR8p6
 EAdMGw02D7cnI5VZbnpIiprZebkRpte5e98YMVoGJ0MWly65H5gq+Bf/jmv5UTIa2pqA
 vOn0Egy2vLKCi/H7I0oNaSqCt5/JsaZ0BJQN0mZOH3xjx3m2aUs5K8wf+7ZVc/ffPuQv
 QzF+PkYteW5zgDqeJkRfO0IEm7V+MtEH8cxRDcdYrZDYwu9+doC0tz+4QLKKRV+dbFkW
 Rj0381mEfMlDo8wzcbJj03etNpRYNKH+qdIPhB8M9Rm9FEdE2eX01DjOjigdVjtsBqeR
 yUzQ==
X-Received: by 10.140.108.245 with SMTP id j108mr42106531qgf.9.1445847969753; 
 Mon, 26 Oct 2015 01:26:09 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.140.104.6 with HTTP; Mon, 26 Oct 2015 01:25:50 -0700 (PDT)
In-Reply-To: <redmine.journal-54498.20151020222826.051f4277e89fb08e@ruby-lang.org>
References: <redmine.issue-11607.20151019214639@ruby-lang.org>
 <redmine.journal-54498.20151020222826.051f4277e89fb08e@ruby-lang.org>
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Date: Mon, 26 Oct 2015 04:25:50 -0400
Message-ID: <CAHGf_=pifLuPpVSAPhbJgSrKZ3=CciV-_zoyQOaCUeEX2d1LFg@mail.gmail.com>
To: Ruby developers <ruby-core@ruby-lang.org>
Content-Type: text/plain; charset=UTF-8
X-ML-Name: ruby-core
X-Mail-Count: 71183
Subject: [ruby-core:71183] Re: [Ruby trunk - Feature #11607] [PATCH] fiddle:
 release GVL for ffi_call
X-BeenThere: ruby-core@ruby-lang.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Ruby developers <ruby-core@ruby-lang.org>
List-Id: Ruby developers <ruby-core.ruby-lang.org>
List-Unsubscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
List-Post: <mailto:ruby-core@ruby-lang.org>
List-Help: <mailto:ruby-core-request@ruby-lang.org?subject=help>
List-Subscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/listinfo/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=subscribe>
Errors-To: ruby-core-bounces@ruby-lang.org
Sender: "ruby-core" <ruby-core-bounces@ruby-lang.org>

On Tue, Oct 20, 2015 at 6:28 PM,  <normalperson@yhbt.net> wrote:
> Issue #11607 has been updated by Eric Wong.
>
> File fiddle-release-GVL-for-ffi_call-v2.patch added
>
> v2 fixes a warning I did not notice before, interdiff:
> ~~~
> --- a/ext/fiddle/closure.c
> +++ b/ext/fiddle/closure.c
> @@ -64,7 +64,7 @@ struct callback_args {
>      void *ctx;
>  };
>
> -static void
> +static void *
>  with_gvl_callback(void *ptr)
>  {
>      struct callback_args *x = ptr;
> @@ -177,6 +177,7 @@ with_gvl_callback(void *ptr)
>        default:
>         rb_raise(rb_eRuntimeError, "closure retval: %d", type);
>      }
> +    return 0;

This interdiff is really ugly to me. Do we really have no other way?