* [ruby-core:25027] [Bug #1978] fixed crash in lib/logger.rb from dependency on svn keywork expansion
@ 2009-08-21 21:26 Stephen Bannasch
2009-08-21 21:38 ` [ruby-core:25028] " Stephen Bannasch
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Bannasch @ 2009-08-21 21:26 UTC (permalink / raw
To: ruby-core
Bug #1978: fixed crash in lib/logger.rb from dependency on svn keywork expansion
http://redmine.ruby-lang.org/issues/show/1978
Author: Stephen Bannasch
Status: Open, Priority: Normal
ruby -v: ruby 1.8.6 (2009-08-05 patchlevel 384) [i686-linux]
When I build Ruby 1_8_6 from a git checkout logger.rb crashes because it operates on a string that it expects to be expanded when the sources are checked out with Subversion.
This is a problem when building Ruby from source when cloned from a git repository such as: git://github.com/rubyspec/matzruby.git.
Without this fix logger.rb:174 throws this error:
private method `chomp' called for nil:NilClass (NoMethodError)
The problem occurs because line 173 looks something like this in the source when checked out with subversion:
id, name, rev = %w$Id: logger.rb 11708 2007-02-12 23:01:19Z shyouhei $
but it looks like this when checked out with git:
id, name, rev = %w$Id$
I haven't looked yet but I suspect this is a problem in 1_8_7 and the 1_9 series.
If logger.rb hasn't changed then this patch should work for those branches also.
----------------------------------------
http://redmine.ruby-lang.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ruby-core:25028] [Bug #1978] fixed crash in lib/logger.rb from dependency on svn keywork expansion
2009-08-21 21:26 [ruby-core:25027] [Bug #1978] fixed crash in lib/logger.rb from dependency on svn keywork expansion Stephen Bannasch
@ 2009-08-21 21:38 ` Stephen Bannasch
2009-08-21 22:04 ` [ruby-core:25029] " Kirk Haines
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Bannasch @ 2009-08-21 21:38 UTC (permalink / raw
To: ruby-core
Issue #1978 has been updated by Stephen Bannasch.
While the dependence on the subversion keyword expansion has been present for a while the crash only started after this commit by shyouhei:
svn rev: 22283
branch: ruby_1_8_6
Fri Feb 13 2009 05:18:12 GMT-0500 (EST)
merge revision(s) 20245,20247: * lib/logger.rb (ProgName): fixed for svn, based on a patch from Nobuhiro IMAI at [ruby-dev:37108].
Which was the resolution for this earlier issue:
http://redmine.ruby-lang.org/issues/show/759
----------------------------------------
http://redmine.ruby-lang.org/issues/show/1978
----------------------------------------
http://redmine.ruby-lang.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ruby-core:25029] Re: [Bug #1978] fixed crash in lib/logger.rb from dependency on svn keywork expansion
2009-08-21 21:38 ` [ruby-core:25028] " Stephen Bannasch
@ 2009-08-21 22:04 ` Kirk Haines
2009-09-10 21:41 ` [ruby-core:25524] " Stephen Bannasch
0 siblings, 1 reply; 4+ messages in thread
From: Kirk Haines @ 2009-08-21 22:04 UTC (permalink / raw
To: ruby-core
On Fri, Aug 21, 2009 at 3:38 PM, Stephen Bannasch<redmine@ruby-lang.org> wrote:
> Issue #1978 has been updated by Stephen Bannasch.
>
>
> While the dependence on the subversion keyword expansion has been present for a while the crash only started after this commit by shyouhei:
>
> svn rev: 22283
> branch: ruby_1_8_6
> Fri Feb 13 2009 05:18:12 GMT-0500 (EST)
> merge revision(s) 20245,20247: * lib/logger.rb (ProgName): fixed for svn, based on a patch from Nobuhiro IMAI at [ruby-dev:37108].
>
> Which was the resolution for this earlier issue:
>
> http://redmine.ruby-lang.org/issues/show/759
> ----------------------------------------
> http://redmine.ruby-lang.org/issues/show/1978
>
> ----------------------------------------
> http://redmine.ruby-lang.org
Thanks Stephen. I'll take a look at this shortly.
Kirk Haines
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ruby-core:25524] [Bug #1978] fixed crash in lib/logger.rb from dependency on svn keywork expansion
2009-08-21 22:04 ` [ruby-core:25029] " Kirk Haines
@ 2009-09-10 21:41 ` Stephen Bannasch
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Bannasch @ 2009-09-10 21:41 UTC (permalink / raw
To: ruby-core
Issue #1978 has been updated by Stephen Bannasch.
Kirk,
Can you let me know if there is anything else I need to do to get this patch into 1_8_6?
I'd like to use git to manage the deployment of ruby to several servers and it would be easier to be able to refer to a tag where this problem was fixed.
In the meantime I'll maintain a separate branch named: '1_8_6_383_fix_logger' here
https://github.com/stepheneb/matzruby
----------------------------------------
http://redmine.ruby-lang.org/issues/show/1978
----------------------------------------
http://redmine.ruby-lang.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-09-10 21:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-21 21:26 [ruby-core:25027] [Bug #1978] fixed crash in lib/logger.rb from dependency on svn keywork expansion Stephen Bannasch
2009-08-21 21:38 ` [ruby-core:25028] " Stephen Bannasch
2009-08-21 22:04 ` [ruby-core:25029] " Kirk Haines
2009-09-10 21:41 ` [ruby-core:25524] " Stephen Bannasch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).