ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:89755] Re: [Ruby trunk Bug#14968] [PATCH] io.c: make all pipes nonblocking by default
Date: Thu, 8 Nov 2018 03:35:15 +0000	[thread overview]
Message-ID: <20181108033515.GA11701@dcvr> (raw)
In-Reply-To: <redmine.journal-74762.20181106041418.f314b0b4d051df57@ruby-lang.org>

Greg.mpls@gmail.com wrote:
> Yes.  Below is a summary of all builds from r64892 2018-10-01 thru r65558, except TestJIT.  I assume TestIO & TestThread are the only tests possibly affected by anything you're working on...
> 
> Since the patch, `TestIO#test_readpartial_lock` has failed in parallel testing both times (r65555 & r65558).

Thanks for that info; I don't know how test_readpartial_lock
would've passed on Windows at all, since it seems like IO#nonblock=
isn't available on Windows...

Here's a new version of the patch which adds a guard around
test_readpartial_lock and includes some test-spec fixes:

https://80x24.org/spew/20181108033144.11416-1-e@80x24.org/raw

It goes on top of r65619 (which is necessary for this patch
under rubyspec).

  reply	other threads:[~2018-11-08  3:35 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-14968.20180806044602@ruby-lang.org>
2018-08-06  4:46 ` [ruby-core:88305] [Ruby trunk Bug#14968] [PATCH] io.c: make all pipes nonblocking by default normalperson
2018-08-06  5:36   ` [ruby-core:88309] " Eric Wong
2018-08-06 21:12     ` [ruby-core:88314] " Eric Wong
2018-11-05 23:22   ` [ruby-core:89713] " Eric Wong
2018-12-07  7:18     ` [ruby-core:90359] " Eric Wong
2018-08-06 22:04 ` [ruby-core:88315] " Greg.mpls
2018-08-06 23:33   ` [ruby-core:88317] " Eric Wong
2018-08-07  2:44 ` [ruby-core:88319] " Greg.mpls
2018-08-07  4:07   ` [ruby-core:88320] " Eric Wong
2018-08-09  8:30 ` [ruby-core:88377] " usa
2018-08-09  8:46   ` [ruby-core:88379] " Eric Wong
2018-08-09  8:57 ` [ruby-core:88382] " usa
2018-08-10  0:48 ` [ruby-core:88405] " shyouhei
2018-08-10  2:04   ` [ruby-core:88410] " Eric Wong
2018-11-06  0:28 ` [ruby-core:89714] " Greg.mpls
2018-11-06  0:59   ` [ruby-core:89715] " Eric Wong
2018-11-06  4:14 ` [ruby-core:89717] " Greg.mpls
2018-11-08  3:35   ` Eric Wong [this message]
2018-11-08 23:04 ` [ruby-core:89760] " Greg.mpls
2018-11-22  6:12 ` [ruby-core:89950] " ko1
2018-11-22  8:55   ` [ruby-core:89963] " Eric Wong
2018-11-29 21:21   ` [ruby-core:90174] " Eric Wong
2018-11-22  9:44 ` [ruby-core:89965] " takashikkbn
2018-11-22 10:16   ` [ruby-core:89967] " Eric Wong
2018-11-22 13:07 ` [ruby-core:89971] " takashikkbn
2018-11-22 14:29 ` [ruby-core:89973] " takashikkbn
2018-11-22 15:15 ` [ruby-core:89976] " Greg.mpls
2018-11-22 15:39 ` [ruby-core:89977] " Greg.mpls
2018-11-22 20:10   ` [ruby-core:89983] " Eric Wong
2018-11-22 20:28     ` [ruby-core:89984] " Eric Wong
2018-11-22 22:59 ` [ruby-core:89990] " Greg.mpls
2018-11-23  0:41 ` [ruby-core:89993] " Greg.mpls
2018-11-23  4:39 ` [ruby-core:89997] " Greg.mpls
2018-11-24  8:43   ` [ruby-core:90030] " Eric Wong
2018-11-24 17:11 ` [ruby-core:90042] " Greg.mpls
2018-11-24 18:02 ` [ruby-core:90044] " Greg.mpls
2018-11-24 20:12   ` [ruby-core:90045] " Eric Wong
2019-06-20 23:09 ` [ruby-core:93292] " samuel
2019-06-24  1:51   ` [ruby-core:93327] " Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108033515.GA11701@dcvr \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).